From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=X3hjEdlC; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 6C6395A026F for ; Fri, 03 Oct 2025 07:33:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759469623; bh=HCwDX50nryPUL3ns8Bkhzlr1bXF+5spW3jg87DStCQQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3hjEdlCtrfuck7w5bzt8PF5qqRsGLrBdXVelusw3n3mk13iyFRisVRxKuuxNbM1g CEeYTnF4NNRHv8YBJXb2cyX/tLjNjkkvzbMfOOnTvJYa7oxmrEE8JfWbnDijscKayY FVC02LRjUqAzRAeQ4iL3lEnVmhGNyhOX5rM2yu0aHMcNFVU5LOZCaSRMbHLT7sk1FF /oNwnf/nu/pEeuirsTAnzdb00OYM1kOBURmdAZ9QDNewMaSvXdCD0PHjRHtmAr6HAN JqwD1tj8sgSnBZr0lgLVxXRhwaBpKpO9LM1SrofomY4cbkKgeydIrj5lZc3BtGEpzN xVdeXfz3ulpFg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cdHQH6Rmlz4wCH; Fri, 3 Oct 2025 15:33:43 +1000 (AEST) Date: Fri, 3 Oct 2025 14:54:18 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v12 7/9] tcp: forward external source MAC address through tap interface Message-ID: References: <20251003003412.588801-1-jmaloy@redhat.com> <20251003003412.588801-8-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rrnHRjv7NhReX2iW" Content-Disposition: inline In-Reply-To: <20251003003412.588801-8-jmaloy@redhat.com> Message-ID-Hash: W4P5JRNEHI4QOAH36U5QF3MADWM226JJ X-Message-ID-Hash: W4P5JRNEHI4QOAH36U5QF3MADWM226JJ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --rrnHRjv7NhReX2iW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 02, 2025 at 08:34:10PM -0400, Jon Maloy wrote: > We forward the incoming mac address through the tap interface when > receiving incoming packets from network local hosts. >=20 > This is a part of the solution to bug > https://bugs.passt.top/show_bug.cgi?id=3D120 >=20 > Signed-off-by: Jon Maloy > Reviewed-by: David Gibson [snip] > + /* Find if neighbour table has a recorded MAC address */ > + if (MAC_IS_UNDEF(omac)) > + fwd_neigh_mac_get(c, &tapside->oaddr, omac); Again, this is looking up with a guest side address, not host side. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --rrnHRjv7NhReX2iW Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjfVvkACgkQzQJF27ox 2GcQvQ/+N+iKR2XlgjtaVXQMI1Bt+PMJp5AtG14CTjVdBVmZ3Sn9bs+4RVRbEszM Ty1Y64xt+l4aDiv86OCcJv0uQNQ0atoA47EZtIUmRrh7Hc1iOIJjZ8Q/osE93MC9 gQHNg8Mqxn9bDAP67tQk5ush0eD5UQsQn72g7JlI5H8bmJC9vs1kJCVEsQwKAXrw sfvGj9qRchDH5G87XtBoghtLTYx1U4NtKkCGZe9/AHUkYS/2NoZ7h7i3NxE1M43g gD1MpWa1rKHIsDBdxh/cHBD2oWT7erY70hJScjU2+3IisWbkfHpHLOFSLJk1AAYc STDTh0QoGbmmHkSW5HbZzYcP2NqOGKxzbemGNOpm6LrgD8LaEDd56YpI/VZCZmSO awc7YtSW2ugV/gVzzvSTaPikIpyZYKpDel7oOiwXsCYr6mCWkgSQX7va5UBznzQb uNLQtlBpO8Xf9avZoBAYHfoMId1L6BG4e8IGFoDc52K7yZlrAT1177Q39+bkaaJq C8yYrxQFnYx2B+gObSu1QHmhvI4vmTQ70Jz2N0UzNcy/PL9CyfRofKYF24AtarEY RRp3H5eOzESMkxarqHQh+lQYxisI0bmd8htCMZj+kr6ZL9NQHGl0wdqtRlegqoNv l9aQVeFZG0+wpAhq+7vspjgAvEuQcaj/b8OWpMmXapTwSf/JcFU= =cwXt -----END PGP SIGNATURE----- --rrnHRjv7NhReX2iW--