From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=pFwS9grF; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 723795A0275 for ; Fri, 03 Oct 2025 07:33:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759469623; bh=5zRkmyOoGVvwmXLA5iL1eJeGOgZXpKptlajvfzAHxI8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pFwS9grFrYtH3kUXkk7pBrhUDUMW6djL+aZqxTPzc22aB+629fxPF2wy6LR7Tkv8g pUjWaB36yO+JpGosf9DTOolo5IwKTzoSg6bHg4LoWbIXopX6lkZcKJe4sRjxDEMHaz 6nHWTPJ8KKy0iDSF+T4aZFb+PfPgnamYWZdA+SkqG/c9CdVNv0BBcrEkd/vxl8RDJQ vR2n+yy7M4rRyXclrWZAQTHiynEnY7CJhL11Go/7OCTxTfqIHpnAX9KmhKQbk9dNZ0 L3qPElZoJLg0MxhB/Wt56vgQlkHoR0IhbMHstUxz8XqVxvKwLduTgANccNpkFvNypu BCBHlWzArRaHA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cdHQH6cVpz4wCf; Fri, 3 Oct 2025 15:33:43 +1000 (AEST) Date: Fri, 3 Oct 2025 15:33:38 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v12 0/9] Use true MAC address of LAN local remote hosts Message-ID: References: <20251003003412.588801-1-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Z+kFRavX14baOAl1" Content-Disposition: inline In-Reply-To: <20251003003412.588801-1-jmaloy@redhat.com> Message-ID-Hash: E347KZ66UJDOA2ENBMK4RHWPSDLR5WE5 X-Message-ID-Hash: E347KZ66UJDOA2ENBMK4RHWPSDLR5WE5 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Z+kFRavX14baOAl1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 02, 2025 at 08:34:03PM -0400, Jon Maloy wrote: >=20 >=20 > Bug #120 asks us to use the true MAC addresses of LAN local > remote hosts, since some programs need this information. > These commits introduces this for ARP, NDP, UDP, TCP and > ICMP. I have a bunch of more detailed comments on the patches, but they're a bit confused, because for the earlier ones I hadn't read the whole series to get the whole context. There is a problem here in that you're not consistent about whether the neighbour table is indexed by host side addresses or guest side addresses. You'll mostly get away with this, because they're usually the same. But it will result in bugs on the edge cases. Having read the whole series now, I think it will be simplest to standardize on indexing by guest side addresses. That invalidates some of my earlier comments, but instead you'll need to use nat_inbound() when you populate the table from netlink updates. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Z+kFRavX14baOAl1 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjfYCMACgkQzQJF27ox 2Gddkg//Wo2l3fFRXIjiGWBx6aElXRTrBAfHf3gus0Uk6yzVCRD52xLdxKAtPUEN Y9F7etbB5+usxKG3EKX9cWqsCQdIhShawnRacnsXCPxkMl4Y/KfDq+TA1Dpc//CJ FmpJdLuzGrLqdKZzbitSrt9bKcKsIYWd3bgwDo4V3fqPdB9MD+ZceQadooWZlNPJ jifUmeLbEkIhcSbmpFCn7zn+7zkSkk8zadc/mZBlUVjp5DWYCmUrz4dTqN385r6P y2pMelWK5R8kmee88kRpfMqBn1GsmwSf1ER1aOsSmckxli1qB4d5XvsJLRrN0KW8 9P2gJ6MIqipbwhVPOzDX+9dASgLhN5rToBBujczg2oQwa1t/XUJ98Amn6kAz+sMR 6pAt6LSEJdc7NBwytIHMRhiM0mYPFsQ2YHUGGt+O5yUxdhIiFikU8uQsDOy5mFA/ BuZ8OexZo6MKUUDFwvES4dYV+19YWqbCY/QpxWAz76XxoSGEHWbVBHkEUg23X/lx t1Bw/4WU+A5yzfphPQzCQlVRvwSffnRRzJswXrkuAGFB4v6Wj33xxp7UM2ZwPUpf KyFT6wi0iTJG6s2JmAcn221em225/Y/ouFFKPr402UmpBkL3OlmdEJM3SgKU7ure k0k0S25E4v5FaJjPor6KG8+X8deNOoFHLzqd6JIoiPcVWJZwZbA= =pFNL -----END PGP SIGNATURE----- --Z+kFRavX14baOAl1--