From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=ipgLM17v; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 3CB635A026F for ; Tue, 23 Sep 2025 10:09:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758614966; bh=mDTRxmvWxWjtSrBfHzz7ozKxB9beMR4BE2Xm/rzbJ+I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ipgLM17vHn0Kd44H2lfqkIV/ewdYNJhZFQKSgDhek8hbf0keRfatupcyYJOSAPxPb AbUsK+MAQ7fm1ee3eC2efmnPIvZcRw5UgawkYWOF7pwcp51fcMgbQGmjGCllbvO8tL sv8P3NZB6om3KG32gmdmgpVHZOtv16OI6nNd6hMsEUOkBnAs1hzDd7NYhHlcDs4SzE rp01sxkjMYrb2QBSUGb4QMAnY/FJfGdsmZH0Ord0arngedEkZgnr72u6SrhJKAMRHw LSFLi/PCOj2fUFS95231IExRNkjo/0vVvEHb4w697iPCUotZwxk0OLd2ROeKjT2DZS rBiAMWoHJy9KQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cWCLZ0p58z4w21; Tue, 23 Sep 2025 18:09:26 +1000 (AEST) Date: Tue, 23 Sep 2025 17:49:44 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] test: Update README.md Message-ID: References: <20250919014329.6007-1-yuhuang@redhat.com> <20250919115822.4e3aab21@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CT1NRaW+AHCkvrgj" Content-Disposition: inline In-Reply-To: <20250919115822.4e3aab21@elisabeth> Message-ID-Hash: GVMCTE2G2U3E4SE6HUG5F5ZMKUC2W7UK X-Message-ID-Hash: GVMCTE2G2U3E4SE6HUG5F5ZMKUC2W7UK X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Yumei Huang , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --CT1NRaW+AHCkvrgj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Sep 19, 2025 at 11:58:22AM +0200, Stefano Brivio wrote: > On Fri, 19 Sep 2025 09:43:29 +0800 > Yumei Huang wrote: >=20 > > Signed-off-by: Yumei Huang > > --- > > test/README.md | 31 +++++++++++++++++++++++++++++-- > > 1 file changed, 29 insertions(+), 2 deletions(-) > >=20 > > diff --git a/test/README.md b/test/README.md > > index 91ca603..e3e9d37 100644 > > --- a/test/README.md > > +++ b/test/README.md > > @@ -32,7 +32,7 @@ Example for Debian, and possibly most Debian-based di= stributions: > > git go iperf3 isc-dhcp-common jq libgpgme-dev libseccomp-dev linux= -cpupower > > lm-sensors lz4 netavark netcat-openbsd psmisc qemu-efi-aarch64 > > qemu-system-arm qemu-system-misc qemu-system-ppc qemu-system-x86 > > - qemu-system-x86 sipcalc socat strace tmux uidmap valgrind > > + sipcalc socat strace tmux uidmap valgrind > > =20 > > NOTE: the tests need a qemu version >=3D 7.2, or one that contains com= mit > > 13c6be96618c ("net: stream: add unix socket"): this change introduces = support > > @@ -81,7 +81,12 @@ The following additional packages are commonly neede= d: > > =20 > > ## Regular test > > =20 > > -Just issue: > > +Before running the tests, you need to prepare the required assets: > > + > > + cd test > > + make assets > > + > > +Then issue: > > =20 > > ./run > > =20 > > @@ -91,6 +96,28 @@ variable settings: DEBUG=3D1 enables debugging messa= ges, TRACE=3D1 enables tracing > > =20 > > PCAP=3D1 TRACE=3D1 ./run > > =20 > > +**Note:** > > + > > +* It's recommended to run the commands as a non-root user. > > + Due to [Bug 967509](https://bugzilla.redhat.com/show_bug.cgi?id=3D96= 7509), > > + if you switch users with `su` or `sudo`, the directory `/run/user/ID= ` may > > + not be created. In that case, `XDG_RUNTIME_DIR` will incorrectly poi= nt to > > + `/run/user/0` instead of `/run/user/ID`, which can cause error. >=20 > Thanks for the research, I wasn't aware of that, and recently spent > quite some time figuring that out (for other reasons): >=20 > https://issues.redhat.com/browse/RHEL-70222 >=20 > in that case, XDG_RUNTIME_DIR was simply not set. Things were working > with 'machinectl shell' instead. >=20 > At the same time: running this whole stuff as root sounds rather crazy, > unless it's a throw-away VMs with absolutely nothing important on it. That might be more common than us old-school Unix heads tend to think. > That is, regardless of the issue with XDG_RUNTIME_DIR. I would maybe > make the wording stronger, something like: >=20 > * Don't run the tests as root, it's not needed! > * If you really need to, note that ... Right. The whole point of passt/pasta is not to require root, so testing it as root means you're not really testing what it's intended to do. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --CT1NRaW+AHCkvrgj Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjSURIACgkQzQJF27ox 2GcpmhAAhdXTqfeOafUmn6fzP+t+YLd6fuhTVjqx0HZK9rmGYzeLST1voROUR0To dtKuCBF7uapKPiPcbHLG5Qha70DhwP0FotyPnBqzH/I3JhTD0JUUo9Siegh+JQoA OIOavp+Uq/DRDVeVqqAv6kFUjIX8w/nGoYx+Sw3sBq4stWjZa2kWfb2SPp7++wsH 9/ZpZbdX2OBZxUenKmQu4NyKWfUZ/+L2VaRYimmRKdvms+6Ssj8AyRlDmA1O6JDT /+ZxjSyT84cVJkWBKZXMAzE3lVg0//d7QZHQ3OkNsyXkiXO2DYyaYt6MaXZ8/eoq 3Fwgz1oBX7BR+tVSkYRYipu6DyS/4Vz+pLcN2UMAbz4oNnbbhMCVOlhGglu61/o2 wEVnH2hXYaJklt8KHwUFLd/Eu+bvuioDXjWxyjredGhWPezX+J2k42pnyrn5NfKu hYOqScZI7ff2vjo+tZnszjjG/BeVmFrmRG2WM6kSYmnflbm2S9Slkf/MstBSf39I dcYTBlcXgokkbQchOaqfpYpH0zch0AF0zCVJiU8p3ybQgXt4xezeiBJJD0GI3jmp kf6dRAovNoDEY7MYLaJHnUhqGJNt7pDaNv1rFrNjG2boRSldzYXnfT5VEw/bi2Zn CV8Br6OXX1AC+ncpHqiGejCKIyyW9TEc+/lSelnC0rzJWYaAzlE= =McUE -----END PGP SIGNATURE----- --CT1NRaW+AHCkvrgj--