From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=iJ5fpjm5; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1367C5A026F for ; Thu, 25 Sep 2025 08:25:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758781504; bh=ZYC4y/Cb/AIOedsIod4DtHVW24H32CvN6akTNEeZvEw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iJ5fpjm5safOWUP3vt8MAoPEOhrPjoxG9c+GLzeqiXMUNnWb8y7QXlmZ4DGlUR7Jk P3m0Kzm+PGybXIwt1/CSX2mzS28X+XXqOnTK0LxlH3Kotyq5cFGXs6FwpOfMdi2Xet ATSrMKUgwWls0cDISRnAnKhlM9qBY2/mxhfAdMKc9v12Pet9KDhl5rBHaxbE6J5UnP 5MupZ1UCXyYlGlAQZDKIYjBDFhDCP/7YZZ1Ad2eiKHFoyUQu6D7Rg9L3UH+NZH8tY4 TxF0ho5JaQMvGPlsivp0xai1RCBd+14FJnzLPrq+JfvLUAOLXH+DzdvEYFtRSVS9AF r7N5sYOnEn4Ww== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cXNxD6kxzz4wCj; Thu, 25 Sep 2025 16:25:04 +1000 (AEST) Date: Thu, 25 Sep 2025 16:25:00 +1000 From: David Gibson To: Yumei Huang Subject: Re: [PATCH] test: fix 'make assets' failure as root Message-ID: References: <20250925054306.15964-1-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2MeH8vxXbNAFstbO" Content-Disposition: inline In-Reply-To: <20250925054306.15964-1-yuhuang@redhat.com> Message-ID-Hash: Y7L54BY4GKZ2AFMKH6SFPUWCDS4S7WFK X-Message-ID-Hash: Y7L54BY4GKZ2AFMKH6SFPUWCDS4S7WFK X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com, rjones@redhat.com, berrange@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --2MeH8vxXbNAFstbO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 25, 2025 at 01:43:06PM +0800, Yumei Huang wrote: > Running `make assets` under `test` as root fails with a "Permission denie= d" > error when `prepare-distro-img.sh` invokes `virt-edit` and `guestfish`. T= his > is due to a known bug in libvirt. >=20 > Work around the issue by switching to the direct backend. >=20 > Signed-off-by: Yumei Huang Reviewed-by: David Gibson The libvirt & libguestfs people don't particularly like this approach, but I think it's reasonable for our needs. > --- > test/prepare-distro-img.sh | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/test/prepare-distro-img.sh b/test/prepare-distro-img.sh > index 0d967c9..423eea7 100755 > --- a/test/prepare-distro-img.sh > +++ b/test/prepare-distro-img.sh > @@ -3,6 +3,8 @@ > IMG=3D"$1" > PASST_FILES=3D"$(echo ../*.c ../*.h ../*.sh ../*.1 ../Makefile ../README= =2Emd)" > =20 > +export LIBGUESTFS_BACKEND=3Ddirect > + > virt-edit -a $IMG /lib/systemd/system/serial-getty@.service -e 's/ExecSt= art=3D.*/ExecStart=3D\/sbin\/agetty --autologin root -8 --keep-baud 115200,= 38400,9600 %I $TERM/g' > =20 > guestfish --rw -a $IMG -i < --=20 > 2.47.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --2MeH8vxXbNAFstbO Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjU4DAACgkQzQJF27ox 2GcOHA//QS7gsh/yh+LnmYrXCB9VOGk4WOeDmL4u0FpDMg1C6aWJtHD2d1EJK2Si lV34hIwfdCNUGK1a6F8mrvj0Edl4Hx37OYUEhL/4XvCfna3US2RxXfToYMwcBjAo 1cbTjUjUmdDkuHTw67oBAcbiZvBoj74Oej6CkmiX81hqRNdcOm+ds6TqBis7K7UC 5dnsWHoqxouR5sUhBq4wVaxdgIqxx+Ruk02I7aRpp1la3sLG9/hbqk0sq4PN0rc4 ln8NCcde1HaLLXKHpLK3+j5ke1nmN18em0Ch0HsWE9mKr+13CNCOKMFcXfAqyM5C iesjYKq8JaS3vE+XjoESJG8mepvc0J00pZozl4hz0d6kxaOBfFb+NnAYg/73ywtj 7YW0brZ9rSS8NHJpI3RSXMlYG39DiCv88n0pBwd1o5sYw282w3/wdpVmbWKFrX2X 8De2ed48xIdpO7dCDlaRkZCThmxOJqVvuLI/ffaOLSnQSx9mEsixSEFf6M2Xs4Vs jz+n1jPs8Y+NYGKbGA4nDqlSzkIe+P72BP1rMjKqsfyO3RNLLxj1g3P8a0Ri5Dd7 IafcE0PFkQ373cnuJ2j0aM33lFQAsK0nMCZzlOz/TYymilTzhrL5+nQmxBwb64e3 Vca1Tku9vp6jcs7BLbnPnK8L/TbkKpvQfAqcYuXJbA6KtL7wcMk= =8TqP -----END PGP SIGNATURE----- --2MeH8vxXbNAFstbO--