From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=vSiNu2uq; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id A54C95A0275 for ; Thu, 25 Sep 2025 08:38:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1758782317; bh=K9F2bSPdg6HpqmVtQMKlQi8T+eU4TA0nmnIEihTvIU0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vSiNu2uqF+AKOMOHyvfhvuO+N4lwt40YEt865OCClYgJHk/5vADhcTv1eDCqmJ0Pu dt0eRwwhxeLpXDigWUy+hqXdFWQuIkz95ga4xEMmM4sz8jVSQbjJPWhXs9dTl6zyJt WkOR3pnHZv0fhePRSq8zNx1WnkMZ13NW7OxOF3XAKOwNmkOdzJtxtBSq0VpBWKkU9a kP4iPZm1tQ1vQlhfxI2Fn/wGrrL00Thwge1aNCtKpmGIaslCVNRnsWiXpufJ3X1twE TNbZnpZJHwlqcRxssU6NYEq0Y5L9z7wS8fWYBmoxeoUm+KPWPU6c2wltr/jbzRm0X7 1GEyUgJNjDaLA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cXPDs2KRvz4wD5; Thu, 25 Sep 2025 16:38:37 +1000 (AEST) Date: Thu, 25 Sep 2025 16:38:32 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v9 9/9] arp/ndp: send gratuitous ARP / unsolicitated NA when MAC cache entry added Message-ID: References: <20250924011330.1168921-1-jmaloy@redhat.com> <20250924011330.1168921-10-jmaloy@redhat.com> <5dda48fc-d854-436d-acd1-734d461efd59@redhat.com> <702508a5-2853-4aad-b527-63d47b9f5988@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pEvcxzT5Z2B0TKmb" Content-Disposition: inline In-Reply-To: <702508a5-2853-4aad-b527-63d47b9f5988@redhat.com> Message-ID-Hash: QZJW25FW5U7WUAYELLDYYRZ5DQMXPMGL X-Message-ID-Hash: QZJW25FW5U7WUAYELLDYYRZ5DQMXPMGL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --pEvcxzT5Z2B0TKmb Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 24, 2025 at 07:32:43PM -0400, Jon Maloy wrote: >=20 >=20 > On 2025-09-24 18:18, Jon Maloy wrote: > >=20 > >=20 > > On 2025-09-23 23:22, David Gibson wrote: > > > On Tue, Sep 23, 2025 at 09:13:30PM -0400, Jon Maloy wrote: >=20 > [...] >=20 > > > > --- a/fwd.c > > > > +++ b/fwd.c > > > > @@ -26,6 +26,8 @@ > > > > =A0 #include "passt.h" > > > > =A0 #include "lineread.h" > > > > =A0 #include "flow_table.h" > > > > +#include "arp.h" > > > > +#include "ndp.h" > > > > =A0 /* Empheral port range: values from RFC 6335 */ > > > > =A0 static in_port_t fwd_ephemeral_min =3D (1 << 15) + (1 << 14); > > > > @@ -129,6 +131,15 @@ void fwd_neigh_mac_cache_alloc(const struct ct= x *c, > > > > =A0=A0=A0=A0=A0 memcpy(&e->addr, addr, sizeof(*addr)); > > > > =A0=A0=A0=A0=A0 memcpy(e->mac, mac, ETH_ALEN); > > > > + > > > > +=A0=A0=A0 /* Send gratuitous ARP / unsolicited NA for the new mapp= ing */ > > >=20 > > > AFAICT this doesn't actually implement what the commit message > > > describes - it seems to always send an ARP/NA when the neighbour table > > > is updated. >=20 > No. Check the code again. Still not seeing it, I'm going to need a more specific pointer to what I've missed. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --pEvcxzT5Z2B0TKmb Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjU42cACgkQzQJF27ox 2GcclQ//TJKt1MEAA8pqLYH21t1BgrtcS9SbvdSdJBKtjAEQXlT1TLfUqRdd3KT3 c2yiJtUU+zyHS2r31uEyczCfhm3NAKTmuPtkAklvBzHzqwGehDIb8BoOXXoGYy4b 6PD4swfzuIZEtooLGOIGsSNl16/ajByQSm7sA8QoNGj4vCHwlCchoDqMfgjtuJ78 W7/QvWQR4F13OVnRXcC4ftFrIEBB7ek4/xGciK1oA0ih5yJWxtvVI6B7ApSnv26V 6gYT/09QWFogACJrcJKPNJnN9d7HHcC4szLE9x8AMlk7iJoyhb9m2UNHd+4Gd6zQ G9UAY0387xPOoMy3vrpChOfjacct0U92UUJbU48k7CH5nmzU9wr4nUuw0L7U0vWm 9H6HRYNNvVOGLjIc6iMQt6ufCuHQmkGeRHG/fXGE0OHC+bOoBIPkcsmzFnXpHYCL MxJgXrU8oyZqYnek8gNHOoissmzT/DYLuYZGGozNwHlk5vLoiC2jFXEFGLE6WwW3 28b479VkhmIl0CNzQPiiCcZ5dtELS/eqxsVkafJYYCCnlC4qSaVJ1XpiVXObbAvj 1ebWOb9cQ/oeri9+Hc/wMY4ICy5EEgw2TG8Nx0c1hvR3hofa6dK9xjloiTmIw6Zq /FTOk46Wh2yIKYKqaVBW9YcX33tG7urN1nP8GvJsFOK4ioiwsfA= =c8fG -----END PGP SIGNATURE----- --pEvcxzT5Z2B0TKmb--