Re: [PATCH 1/2] tcp: Rename "retrans" of struct tcp_tap_conn and tcp_tap_transfer

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1091 bytes --]

On Sun, Sep 28, 2025 at 03:29:45PM +0800, Yumei Huang wrote:
> Rename "retrans" of struct tcp_tap_conn and tcp_tap_transfer to
> "retries", so it can be reused to retry for SYN_TIMEOUT.
> 
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

One nit,

[snip]
> diff --git a/tcp_conn.h b/tcp_conn.h
> index 38b5c54..885d54a 100644
> --- a/tcp_conn.h
> +++ b/tcp_conn.h
> @@ -13,7 +13,7 @@
>   * struct tcp_tap_conn - Descriptor for a TCP connection (not spliced)
>   * @f:			Generic flow information
>   * @in_epoll:		Is the connection in the epoll set?
> - * @retrans:		Number of retransmissions occurred due to ACK_TIMEOUT
> + * @retries:		Number of retries occurred due to ACK_TIMEOUT or SYN_TIMEOUT

This comment now goes past column 80.  I'd suggest shortening to
"Number of retries occurred due to timeouts".

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]