From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=oUgNf23o; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id E222F5A026F for ; Mon, 29 Sep 2025 08:25:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759127148; bh=RDRrSrvyz3Ai1KBOzkgmEAxbSdTFU6Gcwo0exqgfbHw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oUgNf23oQ3KU/3Y43f1fjYenPw9HAqNNCjPscwLYZ+nnqmvE0Vu17Qyp38ZUU7hDT ES3ET3Z90BQyjvgJWEWRgARk6ECqQOnBl96JbOXwYUQAzTxOlz3/jKZqKWt4cqEo16 Yq8OHJn7LNG2+iLUcuvHghme74gNdV/TTB6BPAz1+WdKMBU0+j0yheEZpQZ7vSNfKQ ZZL7wFZQpPpqbG3G4bECmqRKkFMFV2Gd7uzEjH0XUgRPrMgZMDrmFJCU1N7ejuIfj4 T+PvjL9kDab4z7lZoGXcrb7H2Ut4gBEkGNXV4YxRImxcotmQ7dukX9SqsHhvG/cTyY gi8EcUtan2m3A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cZrmD6M1hz4w2Q; Mon, 29 Sep 2025 16:25:48 +1000 (AEST) Date: Mon, 29 Sep 2025 16:06:48 +1000 From: David Gibson To: Yumei Huang Subject: Re: [PATCH 1/2] tcp: Rename "retrans" of struct tcp_tap_conn and tcp_tap_transfer Message-ID: References: <20250928072946.15284-1-yuhuang@redhat.com> <20250928072946.15284-2-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m7K0kcN+vRlU/cim" Content-Disposition: inline In-Reply-To: <20250928072946.15284-2-yuhuang@redhat.com> Message-ID-Hash: R4D2QIUNCQ3PL5QTZZW5JWDD3QHP5TR7 X-Message-ID-Hash: R4D2QIUNCQ3PL5QTZZW5JWDD3QHP5TR7 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --m7K0kcN+vRlU/cim Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 28, 2025 at 03:29:45PM +0800, Yumei Huang wrote: > Rename "retrans" of struct tcp_tap_conn and tcp_tap_transfer to > "retries", so it can be reused to retry for SYN_TIMEOUT. >=20 > Signed-off-by: Yumei Huang Reviewed-by: David Gibson One nit, [snip] > diff --git a/tcp_conn.h b/tcp_conn.h > index 38b5c54..885d54a 100644 > --- a/tcp_conn.h > +++ b/tcp_conn.h > @@ -13,7 +13,7 @@ > * struct tcp_tap_conn - Descriptor for a TCP connection (not spliced) > * @f: Generic flow information > * @in_epoll: Is the connection in the epoll set? > - * @retrans: Number of retransmissions occurred due to ACK_TIMEOUT > + * @retries: Number of retries occurred due to ACK_TIMEOUT or SYN_TIMEO= UT This comment now goes past column 80. I'd suggest shortening to "Number of retries occurred due to timeouts". --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --m7K0kcN+vRlU/cim Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjaIfcACgkQzQJF27ox 2GdlWQ//dUrDSyuvbpRj2wP075/hMtRCAVSQPUo6mvQbFRI0h5eqoG2wybXZZN1t vhPJV5stx04wOOvuIt+993HrTD5pu1DI5kwi//PUVKTgQTPQ1cDzHpfL/N7RyANl T8EAxAqB4vN91DdnWIRuxHkVWk2LLuI4WpSfvLKy5hZCicr5TJpkVG1smvYMR5Vk o/eEW/djBVH9dcRMMZyEgnMJtdeW3WrVvmKUSLDlHnY8EzTJpDEyaxzdZu7pA39Y uro6XckeyaX7pzwlk51nWc1Kh3Qcpvm8QpUI5jai3900y7v3HmURLj7u+22C1jC4 ir0T+l/THc07d0QvGro4HKs/QH0CcbL+eQMFA6kw2uvJ1PbibGt/DQs8LI2tfrP6 tzGb024uFhx7ato3dCOkmk17bEaaM6cgWov2jRjRPiY4hwRvjUj59LqYAc8mtAtU BN8QNdlhFXK1tSpazQUlzNMlK8DFem7H2QnnodNJHBPMIZKs2HiJNJVgMFeq3nX1 0b4akwFb1bzcUslU5HCEzwl0TbXRigWszHatyFVfq0RE6TBxKQvdRZxWdzYXkZwc vRyF+tTAGAAKSM98R+j90+AqZQJazREBkYYUQTdKnC3gTtEs0yhc02Y7Z1vlRkpS Wn5JEqZEfllGo66tmEOuE5xlZLTR0x01MDPE9RUpvg2IHJIMyWI= =+fj6 -----END PGP SIGNATURE----- --m7K0kcN+vRlU/cim--