public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
* [PATCH] test: Fix printf error when debug is enabled
@ 2025-09-29  6:30 Yumei Huang
  2025-09-29  6:41 ` David Gibson
  2025-09-29 22:24 ` Stefano Brivio
  0 siblings, 2 replies; 6+ messages in thread
From: Yumei Huang @ 2025-09-29  6:30 UTC (permalink / raw)
  To: passt-dev, sbrivio; +Cc: david, yuhuang

Running test pasta/tcp with debug enabled would get stuck with
below error:

  + printf 'DEBUG: ns     socat -u OPEN:__BASEPATH__/big.bin TCP6:[__GW6__%__IFNAME__]:10003\n'
  lib/term: line 38: printf: `_': invalid format character

The error occurs because printf interprets the % character as the
start of a format specifier, and the following '_' isn't one of
them.

Fix it by replacing 'printf "${*}\n"' with 'printf "%s\n" "$*"'.
Also update the docstring.

Link: https://bugs.passt.top/show_bug.cgi?id=154
Fixes: de28c20d8051 ("test: Update lib/term for clearer output when DEBUG is enabled")
Signed-off-by: Yumei Huang <yuhuang@redhat.com>
---
 test/lib/term | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/test/lib/term b/test/lib/term
index 6400746..2293474 100755
--- a/test/lib/term
+++ b/test/lib/term
@@ -29,32 +29,32 @@ PR_NC='\033[0m'
 PR_DELAY_INIT=100 # ms
 
 # info() - Highlight test log pane, print message to it and to log file
-# $@:	Message to print
+# $*:	Message to print
 info() {
 	tmux select-pane -t ${PANE_INFO}
-	printf "${*}\n" >> $STATEBASE/log_pipe
-	printf "${*}\n" >> "${LOGFILE}"
+	printf "%s\n" "$*" >> $STATEBASE/log_pipe
+	printf "%s\n" "$*" >> "${LOGFILE}"
 }
 
 # info_n() - Highlight, print message to pane and to log file without newline
-# $@:	Message to print
+# $*:	Message to print
 info_n() {
 	tmux select-pane -t ${PANE_INFO}
-	printf "${*}" >> $STATEBASE/log_pipe
-	printf "${*}" >> "${LOGFILE}"
+	printf "%s\n" "$*" >> $STATEBASE/log_pipe
+	printf "%s\n" "$*" >> "${LOGFILE}"
 }
 
 # info_nolog() - Highlight test log pane, print message to it
-# $@:	Message to print
+# $*:	Message to print
 info_nolog() {
 	tmux select-pane -t ${PANE_INFO}
-	printf "${*}\n" >> $STATEBASE/log_pipe
+	printf "%s\n" "$*" >> $STATEBASE/log_pipe
 }
 
 # info_nolog() - Print message to log file
-# $@:	Message to print
+# $*:	Message to print
 log() {
-	printf "${*}\n" >> "${LOGFILE}"
+	printf "%s\n" "$*" >> "${LOGFILE}"
 }
 
 # info_nolog_n() - Send message to pane without highlighting it, without newline
@@ -363,8 +363,8 @@ status_test_start() {
 info_check() {
 	switch_pane ${PANE_INFO}
 
-	printf "${PR_YELLOW}?${PR_NC} ${*}" >> $STATEBASE/log_pipe
-	printf "? ${*}" >> "${LOGFILE}"
+	printf "%s" "${PR_YELLOW}?${PR_NC} ${*}" >> $STATEBASE/log_pipe
+	printf "? %s" "${*}" >> "${LOGFILE}"
 }
 
 # info_check_passed() - Display and log a new line when a check passes
-- 
2.47.0


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-30 11:13 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-29  6:30 [PATCH] test: Fix printf error when debug is enabled Yumei Huang
2025-09-29  6:41 ` David Gibson
2025-09-29 22:24 ` Stefano Brivio
2025-09-30  0:23   ` David Gibson
2025-09-30  1:32     ` Yumei Huang
2025-09-30 11:13     ` Stefano Brivio

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).