From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=EXWjhMbf; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4BCFD5A0274 for ; Wed, 01 Oct 2025 02:24:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759278286; bh=ttwDTK0NNzPC4v8+UZLkgLp1Qb8MBXoBsAGmerfuHMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EXWjhMbfUlKQRfBHunb5UiUM8X/xNxbUDizUugwLGB4+sOX2QjBnQhgc+q22nSaAR m1og30S6Cyq91mO1JqRPhQYxPTl3JZsV4X7mb6ukT8sJmR/CPlg/921mXz7G1kOQ73 2VmUf646zfqVOKGaaf6wOidGzxRadTfJsIvY42o3IvhB+wy7rX6y3PPQNoNGUAflsE 8P7gEvS+Q/tnK33BAmEtUv7Zrgd1aXLl8npjkB806ZDG6+EInJeF7rbi2PjDFjoDUr XQ8wScH1jv4I1PSrHNi77IFEmfiWLp0AyxqvgJWxMAMuAHX/4p9bHErgYFRHB99vs/ MZDfSFDM9aeJA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cbwfk0VXlz4wCp; Wed, 1 Oct 2025 10:24:46 +1000 (AEST) Date: Wed, 1 Oct 2025 10:23:28 +1000 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v11 8/9] tap: change signature of function tap_push_l2h() Message-ID: References: <20250927192522.3024554-1-jmaloy@redhat.com> <20250927192522.3024554-9-jmaloy@redhat.com> <20250930233015.752d6ed5@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/HpgBYMoX1ZPmsJH" Content-Disposition: inline In-Reply-To: <20250930233015.752d6ed5@elisabeth> Message-ID-Hash: EJOVFM5UZUGMJD3GHZU756TWOT3VEOFG X-Message-ID-Hash: EJOVFM5UZUGMJD3GHZU756TWOT3VEOFG X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --/HpgBYMoX1ZPmsJH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 30, 2025 at 11:30:15PM +0200, Stefano Brivio wrote: > On Sat, 27 Sep 2025 15:25:21 -0400 > Jon Maloy wrote: [snip] > > -void *tap_push_l2h(const struct ctx *c, void *buf, uint16_t proto) > > +void *tap_push_l2h(const struct ctx *c, void *buf, > > + const void *src_mac, uint16_t proto) > > { > > struct ethhdr *eh =3D (struct ethhdr *)buf; > > =20 > > - /* TODO: ARP table lookup */ > > + /* TODO: ARP lookup on tap side */ >=20 > Why? I mean, what would we do with guest-side MAC addresses, as we > don't control Layer-2 host-side? I actually have some loose plans in this area. We could repurpose the ARP cache data structure to track MAC addresses on the guest side. That would be one piece we'd need in order to handle multiple bridged guests simultaneously. Obviously it would be populated by different means than the host side cache. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --/HpgBYMoX1ZPmsJH Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjcdH8ACgkQzQJF27ox 2GdBRA//aG9B/Bu9VZx0twVIfsgudSJ7rGFcZiY+OqpjX3/wUDwDKc71dvViXLiA daW0EDheHsFVHHMv1A9GOs/vLO4KkTlW8VITFwxRl//GNnXCDpn/7yIwc6prUVBf dizhlETHmfi/9AMGpADRtyP96gBx8xLvOHXq6n88wK552sR8TiT/w6hh3ZEiHrdf AsPOW9z9qmDA86YAJ3ayO5ne6J8xVy0rCWxtQwOIOOHy2dZwbnyDQ/WqnWW8XBJH 1+/BMGGPeV0LhXuEqbIg+f14gux2cvEEiWbPtWTLcT8NJ0IlvaqIY1psa+6mgmb4 8emZvNvlmB3sZLeoRjMBt91dI6f4SjEHmGqr+L6ofwWujhR1z+1VBl+LEk1LKN1P jeUFs7IoC+38X8+AJYeMdxpDDqDySpwePGQ7uQFjhVQyv6aY/4mPUIO2oyD2+E8Y t8yK7CO+ImAkqpTTd/8kUG7HjAO3ODvRFhi02RH6UQFAXkPLPILCxU4dE04YBdEQ VmHYi6xy+4A6W4KHxF+Ffi98aGpeFGvHgdcT+5EK/xPu7WQQn2m5Fqj2EXj/IJ4y 6XkD2GOc3226NUIrnY30WgsYaOFpJAyQi1FHRiDgHPmzAz7NP+CMAOqjX9f0KLp/ 1iSYc6+yWBblvM7HnN6hqkoPT+rzlOO537la82S/H/LkBKpQ9IA= =hqXf -----END PGP SIGNATURE----- --/HpgBYMoX1ZPmsJH--