From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=kmkJonWH; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 88F595A0272 for ; Wed, 01 Oct 2025 02:31:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759278675; bh=S1PC8TQpjfiMT+cTNDrelwVlM19d77q8n+UwYLtEjLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kmkJonWHOmk82VToZ6ZUlFb2P40NXWxHcP7zurQPwM4v6zHzHlHjGXgprCpPNToMJ x6ruxCSZz5MIeaUqNjkx9B6Xn/XKowRKIvheO8SIM/r/kHIiFBkLSqeqCYbj9SKCsl zWRwYjNtTX0AUwTYdblNF8ZtlaMpVPXu22hWGAfEKeS2WAtmO0X6TT0HGZ1hOWV+7E M8NCf+nzFKYBhq0jMpmY3Rq2sjstVMyMUho5aPlItewneB05oHPQES3eAXY2/0exGS CtqZ8DJ7oS1+Pe72LiqPzplexuR6uFnn3eaqxFFV8hrOuWqAVllBtDU1E88SFDnenL BJqLvBHZU133A== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cbwpC2d7Kz4wCf; Wed, 1 Oct 2025 10:31:15 +1000 (AEST) Date: Wed, 1 Oct 2025 10:31:10 +1000 From: David Gibson To: Yumei Huang Subject: Re: [PATCH] test: Update passt.mbuto and passt.mem.mbuto Message-ID: References: <20250930062952.17036-1-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hw1x77JAuJEhbwHm" Content-Disposition: inline In-Reply-To: <20250930062952.17036-1-yuhuang@redhat.com> Message-ID-Hash: UQIFSYLBQYBY7F4LA3PUIL6CL3WD3WBA X-Message-ID-Hash: UQIFSYLBQYBY7F4LA3PUIL6CL3WD3WBA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --hw1x77JAuJEhbwHm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 30, 2025 at 02:29:52PM +0800, Yumei Huang wrote: > If /bin is in the PATH of host, /usr/bin may not exist in mbuto > guest, which causes some binaries failing to move to /usr/bin. > As a result, tests fail as binaries not found. >=20 > Fix it by adding /usr/bin to DIRS. Also create the same symlink > for mbuto.mem.img. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D158 > Fixes: f4729be7a56b("test: Update mbuto profile to fix the symlink of /bi= n") > Suggested-by: David Gibson > Signed-off-by: Yumei Huang > --- > test/passt.mbuto | 2 +- > test/passt.mem.mbuto | 8 +++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/test/passt.mbuto b/test/passt.mbuto > index 231b9c9..598c254 100755 > --- a/test/passt.mbuto > +++ b/test/passt.mbuto > @@ -33,7 +33,7 @@ LINKS=3D"${LINKS:- > dhclient /usr/sbin/dhclient > sysctl /usr/sbin/sysctl}" > =20 > -DIRS=3D"${DIRS} /tmp /usr/sbin /usr/share /var/log /var/lib /etc/ssh /ru= n/sshd /root/.ssh" > +DIRS=3D"${DIRS} /tmp /usr/sbin /usr/bin /usr/share /var/log /var/lib /et= c/ssh /run/sshd /root/.ssh" > =20 > COPIES=3D"${COPIES} small.bin,/root/small.bin medium.bin,/root/medium.bi= n big.bin,/root/big.bin rampstream,/bin/rampstream rampstream-check.sh,/bin= /rampstream-check.sh" > =20 > diff --git a/test/passt.mem.mbuto b/test/passt.mem.mbuto > index 532eae0..7554a43 100755 > --- a/test/passt.mem.mbuto > +++ b/test/passt.mem.mbuto > @@ -12,7 +12,7 @@ > =20 > PROGS=3D"${PROGS:-ash,dash,bash chmod ip mount insmod mkdir ln cat chmod= modprobe > grep mknod sed chown sleep bc ls ps mount unshare chroot cp kill = diff > - head tail sort tr tee cut nm which switch_root}" > + head tail sort tr tee cut nm which switch_root mv rm}" > =20 > KMODS=3D"${KMODS:- dummy}" > =20 > @@ -22,12 +22,14 @@ LINKS=3D"${LINKS:- > ash,dash,bash /init > ash,dash,bash /bin/sh}" > =20 > -DIRS=3D"${DIRS} /tmp /sbin" > +DIRS=3D"${DIRS} /tmp /sbin /usr/bin" While we're changing this, we should probably standardize on using /usr/sbin for passt.mem.mbuto as well. I don't think it needs it at the moment, but since it bit us for passt.mbuto, it's just a problem waiting to happen. In fact, I wonder if it would make sense to have mbuto unify /bin, /usr/bin, /sbin and /usr/sbin as part of its core. > COPIES=3D"${COPIES} ../passt.avx2,/bin/passt.avx2" > =20 > FIXUP=3D"${FIXUP}"' > -ln -s /bin /usr/bin > +mv /bin/* /usr/bin || : > +rm -rf /bin > +ln -s /usr/bin /bin > chmod 777 /tmp > sh +m > ' > --=20 > 2.47.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --hw1x77JAuJEhbwHm Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjcdk0ACgkQzQJF27ox 2GerVg/7B9oA79YI1abTakytA54T53DBIzKCZKTLD2vX5pLL6d+banmAfEdCt/Hu joythnU/BTcqS/HnDod1jFwwZAE89QmU0fE8ZNob4Y8ECt7zf41zHvv37uN6EiV0 mV6ZM6W5KcNeqimxyVKmi27/l+nHLPsId3bUx/SpceU4efAVSuB60OkcygyqzmsL 1HNu4TGn3eGjXrdNT008oGagMvnHAKiQmnYmzYZFSMtQP0srYQBCXU5K/skKiRNf 1hWnv9tfLA49gX3brpjCfTuDMpdKQt4OjL4KfJM5RKUC5wo1CNMQTW0aiB6OsFaQ fECcw1U0IKqP2c4a0hEEhHdBtRpCwX77pKm+pfkapu9FOzz4m7rbArQxUveq6l+T 6E89k9ajFwqdC/e2jjIcthPSK4Z1dfYzqOCnAeruBl1ESFP8UBaCycosM4HmhgUF R3862Jew/4AEyberElD3JCnglwbsc7m6g+ZMQyliB/lK4Bz7FiiiGb1kM0aNd67K fIkPPTTg9tmeYYmzP3lHqHk17vDzv3N5dDrT+iLq22OnCHZoT+W5Ua/iTL+38ein 5BMe4HFFMLe1ZY2KVC0MrcU7bJGa8bbJd9GeXP3GXkSPY/Jbk9hnt/N9kg04h4Wo STyUKTvtBuNbWJGiCUMTybCp7GLD9T7q5tg81PtURPrjVcwezIc= =feew -----END PGP SIGNATURE----- --hw1x77JAuJEhbwHm--