From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202508 header.b=S4t259Lm; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id E7BB85A0272 for ; Wed, 01 Oct 2025 02:37:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202508; t=1759279023; bh=6S75MA14PtD92HEKapZulHOc/+Q+nCw3SSowyRCfvug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S4t259Lm/496jag3DSdqvRskEjf/JpoQbTEDsNERUZsQ0CRxAafU4Org9U8wtpMK2 obMX0uYbVXoczoby298sKunCDmvHXiUUxMDMQdNoQnQXIQmGc/2wM0ppzOBlUpJZ0w tDSpRbBylLAZLaraANN00EpCt2+kir0m6l/M27oCuP9CuLpOeU/lgFK/6nViapY5T/ 5zgpOhoZiV36/osopUimvxotIiOuh8KoBdD1sfux9mDEat3ZNypws+n7TbeebAcfYE a+FOg/ka9Q41cpp4npFYW5tw6sC5Zem/TLzVi8C9y+GNJtq9tHn9WKJLfbW+9BZ8KI 3enqjCOL1QBEQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cbwwv6T3Kz4wCp; Wed, 1 Oct 2025 10:37:03 +1000 (AEST) Date: Wed, 1 Oct 2025 10:34:30 +1000 From: David Gibson To: Yumei Huang Subject: Re: [PATCH] test: Update passt.mbuto and passt.mem.mbuto Message-ID: References: <20250930062952.17036-1-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vDjp8xcpDU88kuM+" Content-Disposition: inline In-Reply-To: Message-ID-Hash: TP6OZVIC6FABTQIWDVOJZ24YCKUQC7ZD X-Message-ID-Hash: TP6OZVIC6FABTQIWDVOJZ24YCKUQC7ZD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --vDjp8xcpDU88kuM+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 01, 2025 at 10:31:10AM +1000, David Gibson wrote: > On Tue, Sep 30, 2025 at 02:29:52PM +0800, Yumei Huang wrote: > > If /bin is in the PATH of host, /usr/bin may not exist in mbuto > > guest, which causes some binaries failing to move to /usr/bin. > > As a result, tests fail as binaries not found. > >=20 > > Fix it by adding /usr/bin to DIRS. Also create the same symlink > > for mbuto.mem.img. > >=20 > > Link: https://bugs.passt.top/show_bug.cgi?id=3D158 > > Fixes: f4729be7a56b("test: Update mbuto profile to fix the symlink of /= bin") > > Suggested-by: David Gibson > > Signed-off-by: Yumei Huang > > --- > > test/passt.mbuto | 2 +- > > test/passt.mem.mbuto | 8 +++++--- > > 2 files changed, 6 insertions(+), 4 deletions(-) > >=20 > > diff --git a/test/passt.mbuto b/test/passt.mbuto > > index 231b9c9..598c254 100755 > > --- a/test/passt.mbuto > > +++ b/test/passt.mbuto > > @@ -33,7 +33,7 @@ LINKS=3D"${LINKS:- > > dhclient /usr/sbin/dhclient > > sysctl /usr/sbin/sysctl}" > > =20 > > -DIRS=3D"${DIRS} /tmp /usr/sbin /usr/share /var/log /var/lib /etc/ssh /= run/sshd /root/.ssh" > > +DIRS=3D"${DIRS} /tmp /usr/sbin /usr/bin /usr/share /var/log /var/lib /= etc/ssh /run/sshd /root/.ssh" > > =20 > > COPIES=3D"${COPIES} small.bin,/root/small.bin medium.bin,/root/medium.= bin big.bin,/root/big.bin rampstream,/bin/rampstream rampstream-check.sh,/b= in/rampstream-check.sh" > > =20 > > diff --git a/test/passt.mem.mbuto b/test/passt.mem.mbuto > > index 532eae0..7554a43 100755 > > --- a/test/passt.mem.mbuto > > +++ b/test/passt.mem.mbuto > > @@ -12,7 +12,7 @@ > > =20 > > PROGS=3D"${PROGS:-ash,dash,bash chmod ip mount insmod mkdir ln cat chm= od modprobe > > grep mknod sed chown sleep bc ls ps mount unshare chroot cp kil= l diff > > - head tail sort tr tee cut nm which switch_root}" > > + head tail sort tr tee cut nm which switch_root mv rm}" > > =20 > > KMODS=3D"${KMODS:- dummy}" > > =20 > > @@ -22,12 +22,14 @@ LINKS=3D"${LINKS:- > > ash,dash,bash /init > > ash,dash,bash /bin/sh}" > > =20 > > -DIRS=3D"${DIRS} /tmp /sbin" > > +DIRS=3D"${DIRS} /tmp /sbin /usr/bin" >=20 > While we're changing this, we should probably standardize on using > /usr/sbin for passt.mem.mbuto as well. I don't think it needs it at > the moment, but since it bit us for passt.mbuto, it's just a problem > waiting to happen. >=20 > In fact, I wonder if it would make sense to have mbuto unify /bin, > /usr/bin, /sbin and /usr/sbin as part of its core. Remembered Yumei will be away for the next week or so. Maybe we want to merge as a partial fix anyway? So, Reviewed-by: David Gibson --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --vDjp8xcpDU88kuM+ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjcdxYACgkQzQJF27ox 2GeHYw//bJmdXgKVHrtyI9oddB8oBePFfPdy1br6ZfypBi9JQ+ceLKFwNXGbJ9RM fATiZkzdvAgxKo5ondtOGJYpWXaDqpOKUT099yevEX5pARV4qndcuWifn+MQ3M5G a1oud2A+cWYezPeIJOVopcsKLuPo/w4rdFIRXisijFJGoUEHvovitNbZLr2CQZqY f6hLJFqDY4lDIKXQq+fc4dfy4MO67ZSAfIhOY04KOIUHFsZermjuKxAUnwMLNxwE GtlYNAbSuFDrcqyHl7bVQYAkynveu1LalkhzhSWyNKf3IW/VhlJUu4daGbT4ZANX OTxabXP8G/71osgL9xOJdm+5ds7Tn7aEcz0ZPCLrRKeTbk5VozQh1Sivsyb+Pw/u bjg/bnRfnKHMel1UrLzZ/Dp3+vRPTTg6HN3vgoa3ojRcgt6SUeO4wXDxLfw0cmMp OyYwo9MyfphiMgMEFhUYDlkpMPXx9qVnSH9o8UyzLKMrAGAYQYsZAcQRjBsUfEOv UZdmQElBYefmzoTOBHZAFkH6SmiAv6pJtjGSbwPk6RYdmyUnoqeUnc230wDtAAps MIZfWX7tcDswgAUC3JjdBflDATfC8BeBpWORjfBt3r8uMwncnorVpmT1u9Mp3h/E s95ZiniUY5iMkNpNikZJBVDraSwzztLhz1HmIsy2JD3XoKAjGjI= =z4we -----END PGP SIGNATURE----- --vDjp8xcpDU88kuM+--