From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=GJjCnQZt; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C4FBF5A0619 for ; Tue, 07 Oct 2025 02:57:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1759798673; bh=/yv6jIR7wtQpTnyg6W2edSnrRgwSFPcLwCfleC8pIJs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GJjCnQZt2ruAT73NFFWM33cZrfZEN6UUw/iSrKvo+U2qjLhR+DcHrH/9895gKm4wl C7bm2OcTLu7rGBh8/e9Ys/qAYsMWqkaDTxS6zUztMBhADBiDxz67kEkKPvE62Z/etQ m6Y3BcNt2tPVV2HBXRAxKScXlxTmITMP630rNwJhO6u0wsiZ91bXimQDlxXfRyaYkq 4Azdx+B/FyfOHNUMotGhySnkEPSGxLkTgpjo/mohx64yv+y4Z2x+7qtOGzfDgbZRr0 cfML8cejt/411/0jJSi4Dtrid98qikJWBamfgflNtGKh45IE5hIrNGjioSqNeqxlzU rK4x5Kq8O68mg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cgd692R1Qz4w9Q; Tue, 7 Oct 2025 11:57:53 +1100 (AEDT) Date: Tue, 7 Oct 2025 11:56:37 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v12 0/9] Use true MAC address of LAN local remote hosts Message-ID: References: <20251003003412.588801-1-jmaloy@redhat.com> <3adef423-c353-43db-947d-fa76f9224d06@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2F5Wtv9d7TLKJf+X" Content-Disposition: inline In-Reply-To: <3adef423-c353-43db-947d-fa76f9224d06@redhat.com> Message-ID-Hash: H6XWQ6GR2L5JOYU64LU6Z4D26V6P43FV X-Message-ID-Hash: H6XWQ6GR2L5JOYU64LU6Z4D26V6P43FV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --2F5Wtv9d7TLKJf+X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 05, 2025 at 09:39:37AM -0400, Jon Maloy wrote: >=20 >=20 > On 2025-10-03 01:33, David Gibson wrote: > > On Thu, Oct 02, 2025 at 08:34:03PM -0400, Jon Maloy wrote: > > >=20 > > >=20 > > > Bug #120 asks us to use the true MAC addresses of LAN local > > > remote hosts, since some programs need this information. > > > These commits introduces this for ARP, NDP, UDP, TCP and > > > ICMP. > >=20 > > I have a bunch of more detailed comments on the patches, but they're a > > bit confused, because for the earlier ones I hadn't read the whole > > series to get the whole context. > >=20 > > There is a problem here in that you're not consistent about whether > > the neighbour table is indexed by host side addresses or guest side > > addresses. You'll mostly get away with this, because they're > > usually the same. But it will result in bugs on the edge cases. > >=20 > > Having read the whole series now, I think it will be simplest to > > standardize on indexing by guest side addresses. That invalidates > > some of my earlier comments, but instead you'll need to use > > nat_inbound() when you populate the table from netlink updates. > >=20 >=20 > I think I agree. After all this is all about what we are showing the > guest in the form of IP and MAC addresses, so it is conceptually clearer. >=20 > It doesn't change the implementation much, but it makes it easier > to understand which special cases we need to consider. Agreed. I think it will also make this easier to extend for guest-side ARP lookups in future, which we'll want for handling multiple guests. > See my next email. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --2F5Wtv9d7TLKJf+X Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjkZTEACgkQzQJF27ox 2Gc6Xg/+NeYg41H03lTB1vAQZbM6xuDv0P46jqXc/pewx9Gs+SR1aPje9Bj8MyaR K+4ANDDGnTVIWpZsCFyOx6Z0CDKAiJB0vj3kFIJfUC+Qr/kTl8fBeolnl5OfvOiR GGTReZiauvNPF+BLG4V/RZhzMqxnGiWdg5Z+Ct8XhBmB/fKmR9Ou8nociJWEU0w+ bawK1v85ESCJ2ZLj9YVPpQLDHe8dB5hPW619LssfOJ3dJD7CY5hr7wmljAPjXLHG JbvmbohELQVdVj8sJBGQhSoWMvmvwaf9XTR2pc3u+PoW2vZbm6TVrbksVpQxqUod T8l4K562gd750iyb5aQldu3xCyM9hODr8DBioT2dntUJi0S5zV8rrsoZYA955CQQ +tmj2U+Z8r74Jb7mF1CI27imIiukG/Wgo0Vc+UOjidVcQsrYTYDOjm0ElEYgEk0y LF9nGKCRfliwj6noRqf2PZ981mU2NxXjBmjceWYUrNfT9YWJtVH2WhgjnTj+nD1y XxQC4SIHp+pvUizTMjCjAxSa/rCUXPNwbSBEnVUkg/mUBXMJhw2bNwbghU30mv7Z To1EWLq8JUCec6gvoFbT8FIbuq/FJvlU9yvlOf+ndM4WNhS1LXAria2fKcHftW8y F5DNiQXrQz/5f30bY3W24KhsAsiAsDhDJcZbWoZSZZ+0+m1Bjtc= =igPX -----END PGP SIGNATURE----- --2F5Wtv9d7TLKJf+X--