From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=CrYS239A; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id C11185A061C for ; Wed, 08 Oct 2025 02:39:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1759883936; bh=5EhvtAUTgQ4KYJimvCJ/f/LZBbaCmeBWvkTbSWV5Ryg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CrYS239AB5/MzXlacqoVMl3P2oy532e+DfVfrl+FO1Jv/ryYEscuUapxS7jTIYtth vki4LuRua6gp1ieopED1BGwwYknwQvsLNZC01/HK5CVP1yL1GTYuEJfvbw3+UEOlXT QcBPrE6e3c6fgv3BAQRFDjd+LIgQ3DXtdaklcihCL84KzR09oAoRyTBwA9qpKFjUk1 5zkAAGG31H4snDhBX1Qm4h6M2EEWyVj3ELkMViwwDk7covbmTx/PLRpQtBoeTrkPII r4aIQEz3iMqQO4Id+MSV7Hy2yndNHRaym4i60wWkMOOMOTCuB4HZEuVbPukPKi1VUK dwpZ5xBaOWANQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4chDdr6l6vz4wB7; Wed, 8 Oct 2025 11:38:56 +1100 (AEDT) Date: Wed, 8 Oct 2025 11:22:25 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 0/6] Test and linter fixups Message-ID: References: <20251002050437.4175553-1-david@gibson.dropbear.id.au> <20251007161346.7771a4f1@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qwaatOkUMxAwlfqn" Content-Disposition: inline In-Reply-To: <20251007161346.7771a4f1@elisabeth> Message-ID-Hash: GZHLVMXK3VIHFR5AG723OMF3CHXZIVJV X-Message-ID-Hash: GZHLVMXK3VIHFR5AG723OMF3CHXZIVJV X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --qwaatOkUMxAwlfqn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 07, 2025 at 04:13:46PM +0200, Stefano Brivio wrote: > On Thu, 2 Oct 2025 15:04:31 +1000 > David Gibson wrote: >=20 > > Before starting to convert testcases to use tunbridge, I wanted to add > > linting for the Python test scripts. While doing that I discovered a > > new crop of cppcheck and clang-tidy false positives, and a Makefile > > bug. > >=20 > > Here's a batch of fixes. > >=20 > > I didn't manage to get through the whole testsuite with this. I keep > > getting hangs on rampstream_out, which I *think* are unrelated. >=20 > I saw this once too, a couple of weeks ago. >=20 > Maybe it's the same issue I've been trying to find the time to work on > for a while now, that is, the kernel not freezing queues of the sockets > from the source instance once they switch to repair mode. Maybe. > But it happened just once so I didn't try re-running with PCAP=3D1. I > might, if it happens again. >=20 > > v3: > > * Delete mypy's cache on make clean > > v2: > > * Actually understood why exetool was being deleted, and fixed it > > properly. > >=20 > > David Gibson (6): > > clang-tidy: Suppress redundant expression warning > > cppcheck: Suppress the suppression of a suppression > > cppcheck: Suppress a buggy cppcheck warning > > cppcheck: Suppress variable scope warnings in dhcpv6() > > test: Don't delete exetool on make clean > > test: Add linting of Python test scripts >=20 > I'm applying this now, even though, strictly speaking, this breaks tests > because test/README.md doesn't mention one needs to install flake8 and > mypy, and I don't think they're very commonly installed, so I think you > should update it. Ah, good point. Beter yet, I should skip rather than failing if the linters aren't available. I'll send a follow up for this. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --qwaatOkUMxAwlfqn Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjlrsAACgkQzQJF27ox 2GfY+hAAhIujiU9K2+KjQ8CdEI6fr+8PXLxpqg0s0yjDcpTG11I25wXC3KSOUu0O n+NOd6huiP4kWVUrJ/ix+DPtfl8o5AWRoAaIbxoFojgld3Chz5d6nrpb7SxdewwD zk8hXr4jQtF2HSrmXF8pI2IGA/GndM6qiEMfn2B+fs35ZCtzwv8zxLKCaRbHu3Jn OzjUiYOqPbi55E+ThA9IZs2iMZFZ+H0xhz6Q39kyrr94Xo539d7JIZvfNtY+aRCx uChnuj/3PhN8QTV0cowFBjm1eojXegccRXJnw6ih/M9zVxYp4hEZ1gyl0hEgmMKe 9Ac40USkPC+otfWMtySqzAsrYgXFNOI89Qq7+E1kdAAJdAA3jusljKs8CWE4Da6g yXrcf+oQAmzaxcyANvH12AskJGdwC+VPMrq5POgEbCKA4OLKsT/lrpiEKW0Kh5Vl SRUDRnsGxsTcZtbS1MiA8m46XKvuRmwQxhpcKZrdzf+2K9k3p9kcpdsKSUm7TvQ0 //59moCgOEBt4ByE8MHwpka0Ecy2P5vDsXgBL2BKV4atzuDMe4MK5Nyr9MKNUxPo quoPpWY+iw1QkGO/L++0n0VLw0jnZKyhGqonJiEMWjM409PjYFBMRmTD02JMU0uK uaFsA8U9QKQLBq+FcdXPlgYGiAQzEHfN3DwzyVXODdTnhJtJy4c= =OkYm -----END PGP SIGNATURE----- --qwaatOkUMxAwlfqn--