From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=QNQw4ggI; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 5F3FC5A061A for ; Fri, 10 Oct 2025 05:40:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760067653; bh=DIGqKIjcWivLhYX6q/+eObN1KfwPbzJ3e3kgUq8n+a0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QNQw4ggIpJNj3DDgH7lvPTxyDJtKpQVcMjXGBUNKMdOawjARAraKCULxYBkJb9CK9 0URTmtucW6GLAeqNUNnAik79qexFjSfOyO9zvZgCXjwPrCQ+wi0fLZ9/40oui/qQ3j AjLBx9nmXwW5XmnR6WKIf1SwaXxOR+6YxlPCV+hvVp9Zsz4vyLCF9AElYKU9cZRhYI 4bvz3RB0+0J0CLEx/gmiCWF7pH6XfCJYj2oIjRxrAAl4pw2s5ndJBH1et9oCo2jp2N H1okq7uxUtzhSTwXDc0rA3U7VrLoxvCX7AMl8MRBGvncxHEYvEu7TiwlRYouUqkPDz T0LaXCDSa2IrA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cjXZs4vQXz4wCl; Fri, 10 Oct 2025 14:40:53 +1100 (AEDT) Date: Fri, 10 Oct 2025 13:28:06 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 1/2] test: Add some missing quoting in exeter runner Message-ID: References: <20251009034358.1256908-1-david@gibson.dropbear.id.au> <20251009034358.1256908-2-david@gibson.dropbear.id.au> <20251009212856.6d0aa833@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WIAlfhrxWGCaw/VJ" Content-Disposition: inline In-Reply-To: <20251009212856.6d0aa833@elisabeth> Message-ID-Hash: 7GLCWW7N5NP7QUWSQ335UKCAUJOEOJBI X-Message-ID-Hash: 7GLCWW7N5NP7QUWSQ335UKCAUJOEOJBI X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --WIAlfhrxWGCaw/VJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 09, 2025 at 09:28:56PM +0200, Stefano Brivio wrote: > On Thu, 9 Oct 2025 14:43:57 +1100 > David Gibson wrote: >=20 > > exeter() quoted ${__testid}, but in some places we use it there's an > > extra level of shell, which needs another layer of quoting. This breaks > > if testids include ';', which is quite common in exeter tests created as > > a composition/pipeline of two functions. Add the required extra quotin= g. > >=20 > > Signed-off-by: David Gibson > > --- > > test/lib/exeter | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/test/lib/exeter b/test/lib/exeter > > index 3b19beaa..530c6909 100644 > > --- a/test/lib/exeter > > +++ b/test/lib/exeter > > @@ -47,9 +47,9 @@ exeter() { > > [ ${CI} -eq 1 ] && video_link "${1}" > > =20 > > for __testid in $($EXETOOL list -- "$@"); do > > - __desc=3D"$($EXETOOL desc -- "$@" -- ${__testid})" > > + __desc=3D"$($EXETOOL desc -- "$@" -- "${__testid}")" > > status_test_start "${__desc}" > > - context_run host "$@" "${__testid}" && status_test_ok || status_test= _fail > > + context_run host "$* '${__testid}'" && status_test_ok || status_test= _fail >=20 > Nit: for consistency, given that @ and * are variable names, I would > enclose them in curly brackets as well, while at it. Good point, done. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --WIAlfhrxWGCaw/VJ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjobzUACgkQzQJF27ox 2GcXZQ//W7vNq7OYZQ4cH9UQoC4v6QtkgPkle6ZA8ZIAvCuyQH3oTNIEqnQ06cU4 JN5fHzw5EC9/He4zdQLAAamA+F9NFQEcSDRQhRImAYud+7JdbQ0PQMiSdDED7PXa WvwJOfmO5+n0+1RlmgnYP+kOsQH2JFs3x0D20H1X5LyGl+VTGKq3lUxvhbIxkdmk nFt2wOovyQEqv+BpI560LP3YnluG6QxbsvZSzjvKRwDDZDcnMiapu1K5kJd2LUFr RTeYDVelVe/m2JNPsvB9sHrt/RXKqVYolPRrqVYuZ6mIiF2HUU8FW8+KTuAA/C+p hgebd7bgRW4qFe/n5aXckZ1jWYfUqVP/JSLYx5Bj3BvcabLS2PEdZg2r88Au+oiS Ju4lDUZRVgePbfPMAa5VprzgcqGX9T0vEMXztRzfvfAjhXMkO39UKOhgk6FJkdXk cOyNw4wWLazWGhUqmRODlZrHUF/v6+3xwdUXENVckXTOjxurj/P+qeOC+V+cBRH2 AEGSKQw+3qXzeJ645ITTgaOU3XNTbqoaeD6bDS59PoP49j0xD2gb6HpMfJc23dbs GvM1fWNJ9MehAUDl1Ev166ApokSFdnvQhp0PjDrcBLh4bL6i87hhyv6a5DZvZpCX 79DiyTVl/Ig8RxAF8daVzXWc/D6QUKm+C7lEc9S0uQ5Fljzp5P8= =wPra -----END PGP SIGNATURE----- --WIAlfhrxWGCaw/VJ--