From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=CM+BeglL; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id E69835A026F for ; Thu, 16 Oct 2025 02:59:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760576396; bh=oNyzS6ScOIlqwlZX1N0lGZfebi8fnUcE/yzzvCZ41Cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CM+BeglLZVqsJmD9ffz/UUnpxkIgWUAdJbqXQN/3FsBOluYjW0kNudzibE/CsnmgU hFkHynpotjALqVu70H8Ds8wPuoGkhdxGLMToUQITO4vN2jGcZR4GQeETOX7tX7ku4n Qbat3ZT6SHnn4ekDGxpM2Srw+VwjKH6sAGu/NF0oEefIRj+X1ypsrTEjNMe9H8ijFo CSzYoNItn3haif9tjwolr3ZvrNDs9RcBZNDILcByNOVcUWSH9si+Pwz00JmIjOiL1W QBF+Ja23yZrVF6kiY1y22HwaxFjBXwbV36L2WyvKVEuet1d8IlRQ90Fi3tjSy2xjcO NRqIMPvuBSWkg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cn8kN2RQRz4wC4; Thu, 16 Oct 2025 11:59:56 +1100 (AEDT) Date: Thu, 16 Oct 2025 11:47:22 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2] tap: Update some function comments for accuracy Message-ID: References: <20251012234941.1433683-1-david@gibson.dropbear.id.au> <20251016014624.4e2e9bc8@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7GNzR17r2XkEwqdh" Content-Disposition: inline In-Reply-To: <20251016014624.4e2e9bc8@elisabeth> Message-ID-Hash: KDMWKRXLDJBLR2IMMQX62KEBJKWZ7GYN X-Message-ID-Hash: KDMWKRXLDJBLR2IMMQX62KEBJKWZ7GYN X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --7GNzR17r2XkEwqdh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2025 at 01:46:24AM +0200, Stefano Brivio wrote: > On Mon, 13 Oct 2025 10:49:41 +1100 > David Gibson wrote: >=20 > > Several of the tap_push_*() functions have doc comments claiming they t= ake > > the context pointer, but don't. Some (tap_push_uh[46]) were broken fai= rly > > recently, but others (tap_push_ip[46]h) have been broken for a long tim= e. > >=20 > > Regardless, fix all the doc comments. > >=20 > > Reported-by: Stefano Brivio > > Fixes: 82a839be9 ("tap: break out building of udp header from tap_udp4_= send function") > > Fixes: 87e6a4644 ("tap: break out building of udp header from tap_udp6_= send function") > > Fixes: 2dbc622f5 ("tap: Split tap_ip4_send() into UDP and ICMP variants= ") > > Fixes: 9d8dd8b6f ("tap: Split tap_ip6_send() into UDP and ICMP variants= ") > >=20 > > Signed-off-by: David Gibson >=20 > Applied, with one minor change to tags (I plan to add some stuff, > including this bit, to the new CONTRIBUTING.md). >=20 > For consistency with the Linux kernel, we use SHAs abbreviated to 12 > digits there, even though 9-digit abbreviations (produced by default > git-publish settings, I guess) No, git-publish doesn't manage Fixes tags. It is the default for git blame, though, which is where I would have copied them from > are unlikely to ever lead to any > conflict for us. >=20 > Well, that's true at least until the day you all discover > https://github.com/not-an-aardvark/lucky-commit, but at that point the > number of digits wouldn't make a difference. >=20 > So, to keep the consistency consistent, I changed those to 12-digit > forms and dropped the extra newline (also added by git-publish). If > you fancy a script checking that for you, see: >=20 > https://lore.kernel.org/all/20190220213729.49deb54f@redhat.com/ Thanks, I've put that into my local hooks. > I pondered about adding that to hooks/, but it feels a bit like > overstepping. And I can "fix" those in seconds anyway (I regularly do, > I'm just pointing it out on this example as it's rather visible here). >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --7GNzR17r2XkEwqdh Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjwQJkACgkQzQJF27ox 2Gf6Dw//fm8MW/0loYuhKMBohPkR31+A6QYEaq0nC8BU3Y0ltLDg8RPbPKnG/ov1 vpIK9OriVHbaINY9Edm26EXq4H4EZ87dM/PxU0iknosxx9J/MarJtb3MiK0WlDTj iJgUsE+uFsZGDMiYa3l8CrOIea3CJx1C2br87o6jkDpsc3uaK6RF7xLWwHT6PgvW YmlwvbqqQrEeGi0c+SCQBTcKp0+VumE687EXJ4cp2KB4a7Fn+Qv3VFeaDJm28D7G ysOjKodoVpHVnWDvzEO39UZ4hj0gxntbD++bs9IpdLzsH6mg8Q4A6IaH/mOzb5wL feRLpa9LNECVAV1+/nesD6e1h1Z9LdvcDQy3XLlL/9yseqpVKm3/H9me+CDvatcL o06hDKxRYsGRXMAi0ABwU5rKNx6eNkrwvbS4blLtxxHPaRvb7Oj48X8lBbLM2wfg GzKVEmxjbGBMIc9w86a3Z92ygswvFfFwlRRMI36YuBD/jJqW2b4gW7Vwb1Ms+siq C0Gpz0mnyaauPS7Fu70Jv1DZ2g1oydwbcye6KV/LrSr3t33wG+els0dsU0ou2iWv H6BtQ/wiTLEHiqPQ5CEXoCSDg3ngJCgl7/U3mY3y8SGto+2WdYWTAJ+3JioNnJ+T oo83brzv+EKebF36YU57qyNdaKWRdOU1acpckHIxBDSxeUfV160= =AgWm -----END PGP SIGNATURE----- --7GNzR17r2XkEwqdh--