Re: [PATCH] test: Fix the escaping issue in memory/passt test

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1806 bytes --]

On Wed, Oct 15, 2025 at 04:04:02PM +0800, Yumei Huang wrote:
> Test memory/passt failed with error "objsize: No such file or
> directory" because of an escaping issue. Fix it.

It would be useful for the commit message to spell out in more detail
what exactly is going wrong.  How is the missing escape resulting in
the error we see.

What is the extra escape for, specifically?  '\1' is what we want to
give to sed, the '' should escape it for the shell.  I'm assuming
something else in the test scripts is removing one of these escapes,
but it's not obvious to me what exactly.

> 
> Link: https://bugs.passt.top/show_bug.cgi?id=155
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
> ---
>  test/memory/passt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/memory/passt b/test/memory/passt
> index 7e45724..c5142ea 100644
> --- a/test/memory/passt
> +++ b/test/memory/passt
> @@ -51,7 +51,7 @@ guest	sed /proc/slabinfo -ne 's/^\([^ ]* *[^ ]* *[^ ]* *[^ ]*\).*/\\\1/p' > /tmp
>  guest	kill \$(cat /tmp/pid)
>  guest	diff -y --suppress-common-lines /tmp/meminfo.before /tmp/meminfo.after || :
>  guest	nm -td -Sr --size-sort -P /bin/passt.avx2 | head -30 | tee /tmp/nm.size
> -guest	sed /proc/slabinfo -ne 's/\(.*<objsize>\).*$/\1/p' | tail -1; (diff -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.after | sort -grk8)
> +guest	sed /proc/slabinfo -ne 's/\(.*<objsize>\).*$/\\\1/p' | tail -1; (diff -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.after | sort -grk8)
>  endef
>  
>  def	summary
> -- 
> 2.47.0
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]