From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=CjqdySth; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 657255A026F for ; Thu, 16 Oct 2025 03:05:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760576710; bh=SN6J0IDGmfoE4gsCDZ3WJUj0lZggIDvRIxxROTdXytE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CjqdySthtRcJkGhUNrRHvqdVZJKS5hv3RvyL0svoZE4VThytBbrqXlPAnkjv2gRP0 eM1rDtBIrGeiZcclteaRQEj6AO/80Yy+TS/sbeGvg+GqI67P5ZwJYvp1iHKfo8ThIc LwVzeuAcqV8SpVLwpYEiSPpPL/YgWoKtIn/LPOFNfNL4jgcGv2wFmwRK1B7XLzeIoB UFIjsBHzWGVwDaPI0Z5ERNzNZUDT7sx1E2lXf4aUz3QrE8DJKZ9vsyP6XCpTcEugir xl7awWftwQHKb96QqGyEUpSKcICEDTmG93p9NvxH+pwK4gwNri8jegVN6nAV/nxFrq Up0m3j0L3qfcw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cn8rQ2GGhz4wC8; Thu, 16 Oct 2025 12:05:10 +1100 (AEDT) Date: Thu, 16 Oct 2025 12:05:08 +1100 From: David Gibson To: Yumei Huang Subject: Re: [PATCH] test: Fix the escaping issue in memory/passt test Message-ID: References: <20251015080402.18822-1-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aW7Sb9gkF6On6K1F" Content-Disposition: inline In-Reply-To: <20251015080402.18822-1-yuhuang@redhat.com> Message-ID-Hash: QGV5QYHWSD42RCC5SKXCVKTC3CL7JVIS X-Message-ID-Hash: QGV5QYHWSD42RCC5SKXCVKTC3CL7JVIS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --aW7Sb9gkF6On6K1F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 15, 2025 at 04:04:02PM +0800, Yumei Huang wrote: > Test memory/passt failed with error "objsize: No such file or > directory" because of an escaping issue. Fix it. It would be useful for the commit message to spell out in more detail what exactly is going wrong. How is the missing escape resulting in the error we see. What is the extra escape for, specifically? '\1' is what we want to give to sed, the '' should escape it for the shell. I'm assuming something else in the test scripts is removing one of these escapes, but it's not obvious to me what exactly. >=20 > Link: https://bugs.passt.top/show_bug.cgi?id=3D155 > Signed-off-by: Yumei Huang > --- > test/memory/passt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/test/memory/passt b/test/memory/passt > index 7e45724..c5142ea 100644 > --- a/test/memory/passt > +++ b/test/memory/passt > @@ -51,7 +51,7 @@ guest sed /proc/slabinfo -ne 's/^\([^ ]* *[^ ]* *[^ ]* = *[^ ]*\).*/\\\1/p' > /tmp > guest kill \$(cat /tmp/pid) > guest diff -y --suppress-common-lines /tmp/meminfo.before /tmp/meminfo.a= fter || : > guest nm -td -Sr --size-sort -P /bin/passt.avx2 | head -30 | tee /tmp/nm= =2Esize > -guest sed /proc/slabinfo -ne 's/\(.*\).*$/\1/p' | tail -1; (dif= f -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.after | sor= t -grk8) > +guest sed /proc/slabinfo -ne 's/\(.*\).*$/\\\1/p' | tail -1; (d= iff -y --suppress-common-lines /tmp/slabinfo.before /tmp/slabinfo.after | s= ort -grk8) > endef > =20 > def summary > --=20 > 2.47.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --aW7Sb9gkF6On6K1F Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjwRMMACgkQzQJF27ox 2GdIKQ/5AaBWqZ9zuf1gvUeDqsupicA1SSXjxlbhufly0qc+bjhVMPoLej/RGSwL JoXXFRtSky8Zl6+k2WtUz2DC1iA8L42F7cei8aOiT3F57/9Q7GuUcPEZNRUH6d9K VVSZRuEHDIzeWbJITO8vPckF+RSCPBCDyQUmZU9/sLkvf/wF598JY92YQmbaTCYk +2WQ1W+CQz2Y1ZrdVB5/Ti26EKntb6osTwETAWMq+8VAOY7NhqBs6Sn/WGf9UTnu pnn8KxgXhYndQTL5LeJxPju0U7tBxFa9+6Q42kNDTJPZ1JdZjX0e6OwnoztmDiTr A/beZcfOZdHRtzUKzVAVlNrePuStz0ph3l7sLNrsruwyLyfeNeXYYZnZDOOVX58o dCzaG8g5vYGfLjEbEA9b11CCEa4woUCyxJ1T+19Ub3exYHeE+dzwQ8AcngM9GZv1 HVlSFmD+YA5jLNwOYfPRMyM1z719SQ1GbegF+Vtx7IGoSJu+gEfk2grz5fFfWjbl NYWf43RVUaLXkre4lueG4pDV3BBPZfUKhZV5C3VtgGEzu/SFbZxrFEuk4u621yrV DtVNdc5TWCb/Esl+DjR6tfokrp4Bmf3y4vHYOmh3FJhgXqq6TiNgbGbkdPn+6Tlu XoxumltOx9PaOm0cEgW67LgbwyXFkaVbiptAesM6HzKytebPA1Y= =BTrU -----END PGP SIGNATURE----- --aW7Sb9gkF6On6K1F--