From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=ammndgUK; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 1B58D5A0619 for ; Fri, 17 Oct 2025 01:16:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760656590; bh=Nzt0TSp1HKQ23yT735hzali7oi4Viywc7Y4Cecmpa7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ammndgUKeickBG4+qvSqrSCe9k7//aegXW7+ndxlUVBqSUu6IarzdnnvT/NgUbdjq qr24unnyz4iOGkImxcPb32s/vndoD7P0kBaDXsf0NhZwGaGQfpTvmDVBv+r5ZoZ/sa sJ4SRGixLt8axRaAVZjKyLd2/c//MFRAxLU4GlGXuiB64WlvUrg2i+PLUVaibgT7zz iOi5Qt12IukT5PPwDWuqoqqxAa8+sSmqESzzJgfOiy1yiEB9Tm0H0cu/uDG1UHuOKK EuooKfK+ANwYbDTpUagzKpKP72wk3GVVvtdnvMUvI+EDdnWIhS2RvPTTgc5HFTvYB+ lej6rQfbdOXhw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cnkNZ71hcz4wCw; Fri, 17 Oct 2025 10:16:30 +1100 (AEDT) Date: Fri, 17 Oct 2025 10:07:04 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 2/6] epoll_ctl: Extract epoll operations Message-ID: References: <20251009130409.3931795-1-lvivier@redhat.com> <20251009130409.3931795-3-lvivier@redhat.com> <20251016233128.2ef96233@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4g/PYS2ZOI0FZyFa" Content-Disposition: inline In-Reply-To: <20251016233128.2ef96233@elisabeth> Message-ID-Hash: IAPUBBRYNZPZBFDI5AU74EXYPF76B2C5 X-Message-ID-Hash: IAPUBBRYNZPZBFDI5AU74EXYPF76B2C5 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Laurent Vivier , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --4g/PYS2ZOI0FZyFa Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2025 at 11:31:28PM +0200, Stefano Brivio wrote: > On Thu, 9 Oct 2025 15:04:05 +0200 > Laurent Vivier wrote: [snip] > > + union { > > + uint32_t flow; > > + flow_sidx_t flowside; > > + union tcp_listen_epoll_ref tcp_listen; > > + union udp_listen_epoll_ref udp; > > + uint32_t data; > > + int nsdir_fd; > > + int queue; > > + }; > > + }; > > + uint64_t u64; > > +}; > > +static_assert(sizeof(union epoll_ref) <=3D sizeof(union epoll_data), > > + "epoll_ref must have same size as epoll_data"); >=20 > Either the comment is misleading, or it should be sizeof(...) !=3D ... I believe <=3D is correct, but the comment is misleading. What we care about here is that our custom structure/union fits in space available in the epoll_event structure. In practice it will have equal size, but <=3D is what we care about. > The rest of the patch looks good to me, I didn't finish reviewing the > series though. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --4g/PYS2ZOI0FZyFa Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjxeokACgkQzQJF27ox 2GcKQA//XUWHvQkWCRCQhOJDyVVH6H0UaMPp66mdsYVSCCZFkU+hkKrNSa0G/dAD n3T7HviBJ+WCQwRg6Mh5hhtpK5IWUej0WvmpXPSlIXJA6SqeliChBtsY62C6s7t7 0s1eaRnkMCpXXEyG97tinHwj0p5jGycrIdqW580sGCE9MXOua0RIZBBBzuqvUlbf 4gzl3aqBXzWwfIq0Ky0M8Ucz3M8DJ/5Nkloay+3F8OxHzfUTO9OVlMZ4kUcada9N 8ZoplF6q0Dt9fu6tCgLESmL258r5ZXCJX7G/Zu3r/dlVYDG1fSz9xALiEhWbQ0L9 iqhDAF7JOKPb7p1nqzzsODW5/sgFGnXYJ7bxb5nFpfBadllMD2wsnZXHIHkdF7Fu LEr88C6Sx9PYymK+BVnuyO6paW09K6qDQ4u2snlHybdGSK0T1IW74Dpi6Sm73xx+ rFkxe1ifAtF1+YI2bhexVFnM883UHX8igo/Wc8GdVeasx5E5tdP6pVLu7AZ0h3D1 v/szB18XhLUKtI3Yg0lCluNbuu4bPNU2T/wa6bG3WlOtqiiT72KSYD1AHOdsk966 wJDnIyOqGRAs11pAOFJdVwrUQP4vvLoFn1MpAL27FLXR/BKvkWk1V/6CmOlZotgb g8nMyeMJR2Gb6JBtZXM3pBRSxEaEl2nDpE3GUnB7C8jleV4krCE= =pSNn -----END PGP SIGNATURE----- --4g/PYS2ZOI0FZyFa--