From: David Gibson <david@gibson.dropbear.id.au>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, sbrivio@redhat.com
Subject: Re: [PATCH v4 3/4] tcp: Resend SYN for inbound connections
Date: Fri, 17 Oct 2025 10:49:42 +1100 [thread overview]
Message-ID: <aPGElhRdXgoBmtgD@zatzit> (raw)
In-Reply-To: <20251016023423.8923-4-yuhuang@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
On Thu, Oct 16, 2025 at 10:34:22AM +0800, Yumei Huang wrote:
> If a client connects while guest is not connected or ready yet,
> resend SYN instead of just resetting connection after 10 seconds.
>
> Use the same backoff calculation for the timeout as linux kernel.
>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
LGTM. Stefano's suggestions make sense, plus one more nit below:
[snip]
> +/**
> + * tcp_syn_params_init() - Get initial syn params for inbound connection
> + * @c: Execution context
> +*/
> +void tcp_syn_params_init(struct ctx *c)
> +{
> + long tcp_syn_retries, syn_linear_timeouts;
These should be intmax_t to match read_file_integer().
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-10-16 23:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 2:34 [PATCH v4 0/4] Retry SYNs " Yumei Huang
2025-10-16 2:34 ` [PATCH v4 1/4] tcp: Rename "retrans" to "retries" Yumei Huang
2025-10-16 2:34 ` [PATCH v4 2/4] util: Introduce read_file() and read_file_integer() function Yumei Huang
2025-10-16 6:30 ` David Gibson
2025-10-16 7:49 ` Yumei Huang
2025-10-16 22:22 ` Stefano Brivio
2025-10-16 23:16 ` David Gibson
2025-10-17 2:11 ` Yumei Huang
2025-10-17 2:29 ` David Gibson
2025-10-17 2:44 ` Yumei Huang
2025-10-19 10:07 ` Stefano Brivio
2025-10-16 2:34 ` [PATCH v4 3/4] tcp: Resend SYN for inbound connections Yumei Huang
2025-10-16 22:22 ` Stefano Brivio
2025-10-16 23:34 ` David Gibson
2025-10-16 23:49 ` David Gibson [this message]
2025-10-16 2:34 ` [PATCH v4 4/4] tcp: Update data retransmission timeout Yumei Huang
2025-10-16 23:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPGElhRdXgoBmtgD@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).