From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=FQ5AB6Xt; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 99BDF5A061A for ; Fri, 17 Oct 2025 01:59:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760659157; bh=ovtMHJdPx+wb6NWeve57xhqYhHjBNusk6Mt7TQjkcEo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FQ5AB6Xt5F3rBSmRVR0Y8h9xpQ9DRbLbEdtQZ9ZwBBI+GXpazYq6+lvMwPxJWVE7A 0/LszU4oWtzPScmvm6d2xJ9rWmiCDHShdqC3r/csTghi/EhU3d4iD7qEQseTeGAKpr 9yeM99D48qTAnIL+dsIu6AXLDbVEuKycHWoDcblFrgnmrOvZiazzoLUDaoNGZG5HU5 L4nw6VcE71gRmgm8igMNZ7JGH6sJcP53PxY+iJf+Nw/jww1s8jYdeXiKA7hTp8stY2 OvKIxxAebK1W8PqXILwf2wfiYOWHTMgoVD0o3m6BVS4WKPOoB8CdESc1qCxDXj5vhY WVMKMwSdMorxw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cnlKx3SGpz4wCw; Fri, 17 Oct 2025 10:59:17 +1100 (AEDT) Date: Fri, 17 Oct 2025 10:49:42 +1100 From: David Gibson To: Yumei Huang Subject: Re: [PATCH v4 3/4] tcp: Resend SYN for inbound connections Message-ID: References: <20251016023423.8923-1-yuhuang@redhat.com> <20251016023423.8923-4-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8MH/SvyHYM/IHqV9" Content-Disposition: inline In-Reply-To: <20251016023423.8923-4-yuhuang@redhat.com> Message-ID-Hash: HQAGPLMJVT7OCLHR4U2MJRV2XXEKLUPE X-Message-ID-Hash: HQAGPLMJVT7OCLHR4U2MJRV2XXEKLUPE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --8MH/SvyHYM/IHqV9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 16, 2025 at 10:34:22AM +0800, Yumei Huang wrote: > If a client connects while guest is not connected or ready yet, > resend SYN instead of just resetting connection after 10 seconds. >=20 > Use the same backoff calculation for the timeout as linux kernel. >=20 > Signed-off-by: Yumei Huang LGTM. Stefano's suggestions make sense, plus one more nit below: [snip] > +/** > + * tcp_syn_params_init() - Get initial syn params for inbound connection > + * @c: Execution context > +*/ > +void tcp_syn_params_init(struct ctx *c) > +{ > + long tcp_syn_retries, syn_linear_timeouts; These should be intmax_t to match read_file_integer(). --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --8MH/SvyHYM/IHqV9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmjxhJUACgkQzQJF27ox 2Gd5Jw//aSS9cwWW7vX9csYb/phg66JntHAB2YpcEXQ1q5QXURQQnwk4+t9aVxAA dkbplukUgNJ66iaKBkeCtPuYWrgsvHqdQF2AeTHyV26t/fO9am9+5ZPBSsG8kn85 auBxiK0obPiTjpwtyk4bS5RbOIkbuR64FttCIbqqJFoSu0w9WxDjhC6n2svzv75a PJz4BqtteVGhcj1fZ2sgSyQ+tnZgIKOMrbS6qY0SEfEJT04n+TwUPiOXYsFc0agB sj8z3jyZYWAYfgwcOCfbvxRgI1FOMP2VQguHbBrqfua4k83xa/ICYp8KhD2U1NLv PLS8GRZCw4/xa502eRstgkOkxDK2KDRy97Xcf/O7w3/3S7qtJHlA+uEl5+T6fijv Qk2OcxeX6fg9U1mgKpwZkjDwWv6vZdel0TOV/3YQY+0z2gnS6wKOgBtWx+TADX5r mPOsNdLllyFk0sYT7cHrxyFxzx9o84sLAvf2W9eIgiivA5KVwPIW4lRdg1XriKqU /qygGbVV7ZsBULVuAT6jAV8uboCdL4GN7yJhdQsh3ir6zPlJK38dnXmUtrCSNjx/ nJCfMlSwl0wJjd2gQFByhgnIewvwZQFPp46yQro7Xo6xwg/69vreArjHkJ3c+j93 uRVR2YcZJveuDxkOjDO7/7j3oRM1PSHOVpFtEb6f02ODXhASBSc= =0bzj -----END PGP SIGNATURE----- --8MH/SvyHYM/IHqV9--