From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=oFegp8J/; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 990F05A061A for ; Mon, 20 Oct 2025 02:18:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760919485; bh=CGgL/AtMBPgRszdDr7pwM9bchxtQeydbcbRVWuZDJgo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oFegp8J/hhOmiBhi+j4+zThIwbAudiHTgGrDxiR87afqzn/u1HxMbu5JhmOcseLkz 2ZAuTdqAErD8rU7H6wT0cEi+HgkNP1ag6lSak+1HzNRuhoo37Cz3bU4QnbczqBW7Wg 1Q5z8aLvEKK5Af7on8Ej8R2XbVvobfRftlBh5e43gQIp22TVu4gGsDjsXgOnBZUn47 tYi1x2UQdRd5YhU7EqVqleB5+4HXLn9oV9CQIBdvGrlkD0CfgEVcSwG1L7snWbDLIB NQzoTT4lOzaMtCek94BQwFhlOVjps8UjLbd2tWtIr/5nupKTGiARAu+A+fLPBBg3pP WHbbVHs3ftuEA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cqbcF1hHqz4wBG; Mon, 20 Oct 2025 11:18:05 +1100 (AEDT) Date: Mon, 20 Oct 2025 11:17:23 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v14 01/10] netlink: add subscription on changes in NDP/ARP table Message-ID: References: <20251015025521.1449156-1-jmaloy@redhat.com> <20251015025521.1449156-2-jmaloy@redhat.com> <20251019120730.01c2cf4f@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="69KNPSSerYoUFxzw" Content-Disposition: inline In-Reply-To: <20251019120730.01c2cf4f@elisabeth> Message-ID-Hash: J4OW4J2OSKA3DBHDEWSPOXC4LBQCIALA X-Message-ID-Hash: J4OW4J2OSKA3DBHDEWSPOXC4LBQCIALA X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --69KNPSSerYoUFxzw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 19, 2025 at 12:07:30PM +0200, Stefano Brivio wrote: > On Tue, 14 Oct 2025 22:55:12 -0400 > Jon Maloy wrote: [snip] > > + warn("neigh_msg_read() failed, error %i", errmsg->error); >=20 > But neigh_msg_read() isn't a function name (it's nl_neigh_msg_read()). > To avoid that, if you really need the function name, I'd suggest %s and > __func__. >=20 > However, here, I don't think you can say that the function failed. It's > just that we got an error from netlink. The function didn't do almost > anything. Maybe just "netlink error on neighbour notifier: ..."? I didn't catch this when I reviewed, but I think it's probably best to avoid function names in messages above debug() level. Rationale: debug() and trace() messages are aimed in large part towards developers, and can have whatever information is useful to them, warn(), err() and die() are aimed at users to whom function names are meaningless. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --69KNPSSerYoUFxzw Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj1f5IACgkQzQJF27ox 2Gf1Sw//Z3zTZ3Xk6COWNy2m4V2RIf0tcxsr50LEDmERSrI5XM7uoBshjKCnz6Oz Mhbn6gP+GHJNfpuCZhfgpD71F5qcKILjWyjc696szDzPXJwSt6CsuZl7PVQX9BAt 6eAKyKTLsCITjisBO8DcHUuBtlH9j2W0Hz3CycUccbL5yEODJZHKh4wcgcUuOD13 idRuZ10UdkC+cksd/ldxwXHOMkHaZhtNVGdnRkc4HNlRwtmrB9bBgjss/RrDrq3P R+u/gdpd7bfOFpnfKpC10Fib31bYcQ545ds/34n+wl/j4DL+E9jRufHA+yi/HAly gpq9FG/Yg+Cnn/wkZ9Jxen5ri/kC82LQQzc4SNtQB2LOg5JiHDbwuXzjlk8zlgbv sHoqMtq/D5Koh24P7xEj/oOrviVQj56jomghNqcgceyhhCCFveuGBbR5BIFbUjd9 joo9L+iHjtLj4Um4j7KxIa+oLhK9ptTlwjr9RA/Hno6lDNSXub7gEHPy2kkQb+5d 1vQ4oK1hU1gDDaHrLBjBAEPL0OCH21emEqMozbT6gOQ4K4ixCy3ztJIw26iWhDaX k3dmz6bQLt3zuyGZ+ZwtvEd6BVspxmleOqumFI5j67GMWxHe5wM0uVuhs8BcX6xm WjncroAVo2QtM6mzjuRB6JcApYvTVZQ1kRnCKnVKmmWwJFSxUOQ= =Soyp -----END PGP SIGNATURE----- --69KNPSSerYoUFxzw--