From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=BMzYkmVC; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 5CCD25A026F for ; Mon, 20 Oct 2025 03:36:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1760924161; bh=Q0RrZZA9U/d4PTPSdETC7yntbqBf6P18OjRnvR+S1w0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BMzYkmVCANVfwE4uHIbr4oOVZdx+ED+LQZj7p7QApy6dzJ7Qsr0ieTW1i3yhcAtAF mffyIt08+qJqfd46nh8LYR/7jMwy/0kIy2xweDq/4OcddG5zCOq+mzl+bYAU8dj1oM HQ1EXc3ZPSdtPDDzZBOKNFJNSSfoukGKuH/Wr4qtRbc9HNyeqsiP04Ch18rhj0MT0P 3mzvQyBxnz6e/pd+nWFsj2GKudo+/DvMfAUlpnyKgThcrx9CWyRGQA/3KADGNb/67p 5cJA6SBSpBMroqC0fdeJwu4Ciu6ktRHCdoM1p5LfDIwlCyI4X1FVzl6oRHJIKXzdT6 71cSEQEJTBUUQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cqdL90ZK8z4wBJ; Mon, 20 Oct 2025 12:36:01 +1100 (AEDT) Date: Mon, 20 Oct 2025 12:35:54 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v4 5/7] icmp: Use thread-based epoll management for ICMP flows Message-ID: References: <20251017103129.229412-1-lvivier@redhat.com> <20251017103129.229412-6-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IeKaHXEe5d7Lz1Mw" Content-Disposition: inline In-Reply-To: <20251017103129.229412-6-lvivier@redhat.com> Message-ID-Hash: KCZEEZU533UZEKHNOIFOBXMUF5655M2L X-Message-ID-Hash: KCZEEZU533UZEKHNOIFOBXMUF5655M2L X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --IeKaHXEe5d7Lz1Mw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 17, 2025 at 12:31:27PM +0200, Laurent Vivier wrote: > Store the thread number in the flow_common structure for ICMP ping > flows using flow_epollfd_set() and retrieve the corresponding epoll > file descriptor with flow_epollfd_get() instead of passing c->epollfd > directly. This makes ICMP consistent with the recent TCP changes and > follows the pattern established in previous commit. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > icmp.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/icmp.c b/icmp.c > index 56dfac6c958e..baddd8e5aacb 100644 > --- a/icmp.c > +++ b/icmp.c > @@ -149,7 +149,7 @@ unexpected: > static void icmp_ping_close(const struct ctx *c, > const struct icmp_ping_flow *pingf) > { > - epoll_del(c->epollfd, pingf->sock); > + epoll_del(flow_epollfd(&pingf->f), pingf->sock); > close(pingf->sock); > flow_hash_remove(c, FLOW_SIDX(pingf, INISIDE)); > } > @@ -206,11 +206,13 @@ static struct icmp_ping_flow *icmp_ping_new(const s= truct ctx *c, > if (pingf->sock > FD_REF_MAX) > goto cancel; > =20 > + flow_thread_set(&pingf->f, 0); > + > ref.type =3D EPOLL_TYPE_PING; > ref.flowside =3D FLOW_SIDX(flow, TGTSIDE); > ref.fd =3D pingf->sock; > =20 > - if (epoll_add(c->epollfd, EPOLLIN, &ref) < 0) { > + if (epoll_add(flow_epollfd(&pingf->f), EPOLLIN, &ref) < 0) { > close(pingf->sock); > goto cancel; > } > --=20 > 2.51.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --IeKaHXEe5d7Lz1Mw Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj1kfkACgkQzQJF27ox 2Gfo7A//bDNfziL3UBIxPjhVDnVo3bwPnfNEpz110MCQb4tPG1Cj1fFk81kxXXYT noHLK8njQWA25cOcxISeKHMbObwOE7e7xlNxJkz3hfk0HG8f5GWSAa0GeGOSuR4q eKM8PHVKJOmeApgs4LbLJqpGeSfwnkvRoUeLF4/LIAPYHBbrJFSAwTTwi9I+a+HO FHUK32HIXcd8dxRN25gVOyIqjmyqkJhAyTwxg+p5nUQ/Wctlob12XyKB+Y6S5w6y HmtyuzWzmBcQSZsuuqVO2vLBwmGFQrBy9+MhbypDQLDfNIV1f2fQsPiZYpeTCS4B K7EweWuqlu5yjb/VW1RAymEXbVXfZXev68tr2Vh8gToCvJXfWqz5nyIuckxX5Ldc KuWA82LsCy2E4TqHoFR7ZudOwp+JcxYvKUJCnnOWkdKBb2ssZZlH0WRkAT8eDsi9 8GMsyg2QZxigXuVr1zNbQBEOD0jGr7yXuh7Z51HhUz4Xkk5emZvxuzVKL/FJYEKS Yc8FvNX/7eLZHqqLteM7ukeGYROQkYr6R2lXZPpQs5dAVakS1r67gf5ZuwzmlKVA wat6k20S01MLrHhS9fxJ3Q12IppzjH9+t3ygiedfYKiRDPOh253G2nSyf11vTWx+ fN8HXS+VuD8lKJnm6hx7mAewdYZZMicyrO5Tuwe2zzYECQmPbog= =uJrX -----END PGP SIGNATURE----- --IeKaHXEe5d7Lz1Mw--