From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=lQSO96Ll; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 046CA5A026F for ; Mon, 27 Oct 2025 23:21:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761603696; bh=R9TILH3OdH8YheWw79TaP1SvKYAkrBBJFwCFslXq1BI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lQSO96Ll+llvb1K8Xk2zUGkJtJzTURYVcyVyV887ZI0hF6jm5yIdMAKUpeyP0nHK/ TjR67gG+/1V5E5nt5ecKplw56eYpY639S/EhravPdyc/5s/yzfnkBJJhRB8T10EpH1 Q1N+vZKEINLdfpFih0s0qpzrwahSQKDjP9zQgYGfhIjvWDdMdqnjdmWWx/FMhV2NQ5 0atkS28TO+G9rHR5eLfu9eNIRyDu+KjeNnw47k/f2JvkxLsQzOQZc7inYs8AJt5jCo iIay4JEy9hUZCHby3L+P0JPrupf/hwSa4sqJItGk9lpDQGIPqpG/GGvUavkSKtMova YJDnESOb78oMg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cwSf83LHLz4w9V; Tue, 28 Oct 2025 09:21:36 +1100 (AEDT) Date: Tue, 28 Oct 2025 09:20:45 +1100 From: David Gibson To: Yumei Huang Subject: Re: [PATCH v2] Add reverse Christmas tree to CONTRIBUTING.md Message-ID: References: <20251027090748.12307-1-yuhuang@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GRT/Xq7G7CTNNZm4" Content-Disposition: inline In-Reply-To: <20251027090748.12307-1-yuhuang@redhat.com> Message-ID-Hash: GMAGOHEVMESJ27Y7ATQDTQ67ZAI4LAXB X-Message-ID-Hash: GMAGOHEVMESJ27Y7ATQDTQ67ZAI4LAXB X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, sbrivio@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --GRT/Xq7G7CTNNZm4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 27, 2025 at 05:07:48PM +0800, Yumei Huang wrote: > Also fix the copyright line. >=20 > Suggested-by: Stefano Brivio > Signed-off-by: Yumei Huang Reviewed-by: David Gibson > --- > CONTRIBUTING.md | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md > index 75ad2a7..64c191f 100644 > --- a/CONTRIBUTING.md > +++ b/CONTRIBUTING.md > @@ -1,6 +1,6 @@ > > =20 > @@ -24,6 +24,10 @@ to prepare patches and participate in the email-based = review process. > =20 > * Edit the source code or documentation following the > [Linux kernel coding style](https://www.kernel.org/doc/html/latest/pro= cess/coding-style.html). > + When adding or editing local variable declarations, please use the rev= erse > + Christmas tree as described > + [here](https://www.kernel.org/doc/Documentation/process/maintainer-kvm= -x86.rst) > + and [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-m= ake-pyramids/). > =20 > * Stage your changes: > =20 > --=20 > 2.51.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --GRT/Xq7G7CTNNZm4 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj/8DgACgkQzQJF27ox 2Gc9fg/+OT8ueo5+HYT5BGUiDvky7gU6+NQxq7pKagI+147oxl1apM0R1EggAQZI wCYJQ4vAve+R0SIXzSvrRwHqkiDXE08Eo/LFRk/cQBRUKLIzu+pe1/tqmd8OMR13 Esq0CUB+wi/eZcjTkPxkh1vCQ979G3tOOI80/vqbtmRWl9vq4C95XFy/L64EaWFd s8PTyVKva56tvH8xFWLerH+5F/qVSTfmQeBeQ6BzQuJ9/NzLGYCdoUTvjLgsFflq VUc9b+9oWHZSmAOWttI+eymya+dZtSTHBUjXSxIFrKETw1pt2PIjN6LmB5QZtkHD PIx6TGsc4IIVQ3gxva4zdgpgkafYDrlpcvmGCPim4dDGlACeEG046ingPF8mUiPY zmfxKNSftxr+vw45sgE8ei8Yc91J5/keHxrWdxAd+nCscFe/qdlpiQ4YM+iZW9CN DvdoyR+VLtk44ZRhXBoq0FatPc8yajZNKmvbU8YHnPvGThrp0GIy4hR/KZ209WfT t3ZVxosk0XNketryvhFwHcg7bCc1gEI4LD/jwsTlVkbC/WTlj/YcOyK+2/F1hCoK 2w1r6jsmFirVv4SEePxXuM8YYIkJ/17lTY84M3k8GoNc+Cze3ucmkDRMi8mEZeU8 PAvoQTepg81F01i7PUlBP7ukXmLgsDyuEHHa57XsOav7pM+QLp4= =hCkU -----END PGP SIGNATURE----- --GRT/Xq7G7CTNNZm4--