From: David Gibson <david@gibson.dropbear.id.au>
To: Yumei Huang <yuhuang@redhat.com>
Cc: passt-dev@passt.top, sbrivio@redhat.com
Subject: Re: [PATCH] Add pyramid style rule to CONTRIBUTING.md
Date: Thu, 23 Oct 2025 11:40:10 +1100 [thread overview]
Message-ID: <aPl5aoORi2p8QzMm@zatzit> (raw)
In-Reply-To: <20251022043054.12491-1-yuhuang@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1437 bytes --]
On Wed, Oct 22, 2025 at 12:30:54PM +0800, Yumei Huang wrote:
> Also fix the copyright line.
>
> Suggested-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Yumei Huang <yuhuang@redhat.com>
Stefano, do we actually encourage that style for any "list of similar
items"? Or just for local variable declarations?
> ---
> CONTRIBUTING.md | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 75ad2a7..451cdd7 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -1,6 +1,6 @@
> <!---
> SPDX-License-Identifier: GPL-2.0-or-later
> -Copyright (c) 2025 Red Hat
> +Copyright Red Hat
> Author: Yumei Huang <yuhuang@redhat.com>
> -->
>
> @@ -24,6 +24,8 @@ to prepare patches and participate in the email-based review process.
>
> * Edit the source code or documentation following the
> [Linux kernel coding style](https://www.kernel.org/doc/html/latest/process/coding-style.html).
> + When adding or editing lists of similar items, please format in the pyramid
> + style as described [here](https://hisham.hm/2018/06/16/when-listing-repeated-things-make-pyramids/).
>
> * Stage your changes:
>
> --
> 2.47.0
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-10-23 0:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 4:30 Yumei Huang
2025-10-23 0:40 ` David Gibson [this message]
2025-10-23 2:27 ` Stefano Brivio
2025-10-27 3:05 ` Yumei Huang
2025-10-27 6:46 ` Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPl5aoORi2p8QzMm@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
--cc=yuhuang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).