From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Maloy <jmaloy@redhat.com>
Cc: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top
Subject: Re: [PATCH v15 1/9] netlink: add subscription on changes in NDP/ARP table
Date: Fri, 24 Oct 2025 15:03:38 +1100 [thread overview]
Message-ID: <aPr6mk0ARLX6eZ54@zatzit> (raw)
In-Reply-To: <20251024012933.1933642-2-jmaloy@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 918 bytes --]
On Thu, Oct 23, 2025 at 09:29:25PM -0400, Jon Maloy wrote:
> The solution to bug https://bugs.passt.top/show_bug.cgi?id=120
> requires the ability to translate from an IP address to its
> corresponding MAC address in cases where those are present in
> the ARP or NDP tables.
>
> To keep track of the contents of these tables we add a netlink
> based neighbour subscription feature.
>
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Though one nit
[snip]
> + if (!(ndm->ndm_state & NUD_VALID)) {
> + trace("neighbour notifier: %s unreachable, state: 0x%02x",
> + ip_str, ndm->ndm_state);
nd_state is a u16, so should that be 0x%04x?
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-10-24 4:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 1:29 [PATCH v15 0/9] Use true MAC address of LAN local remote hosts Jon Maloy
2025-10-24 1:29 ` [PATCH v15 1/9] netlink: add subscription on changes in NDP/ARP table Jon Maloy
2025-10-24 4:03 ` David Gibson [this message]
2025-10-24 8:14 ` Stefano Brivio
2025-10-24 1:29 ` [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents Jon Maloy
2025-10-24 5:51 ` David Gibson
2025-10-24 9:11 ` Stefano Brivio
2025-10-24 10:43 ` David Gibson
2025-10-24 1:29 ` [PATCH v15 3/9] arp/ndp: respond with true MAC address of LAN local remote hosts Jon Maloy
2025-10-24 5:52 ` David Gibson
2025-10-24 1:29 ` [PATCH v15 4/9] arp/ndp: send ARP announcement / unsolicited NA when neigbour entry added Jon Maloy
2025-10-24 5:54 ` David Gibson
2025-10-29 12:30 ` Stefano Brivio
2025-10-24 1:29 ` [PATCH v15 5/9] flow: add MAC address of LAN local remote hosts to flow Jon Maloy
2025-10-24 1:29 ` [PATCH v15 6/9] udp: forward external source MAC address through tap interface Jon Maloy
2025-10-24 1:29 ` [PATCH v15 7/9] tcp: " Jon Maloy
2025-10-24 1:29 ` [PATCH v15 8/9] tap: change signature of function tap_push_l2h() Jon Maloy
2025-10-24 1:29 ` [PATCH v15 9/9] icmp: let icmp use mac address from flowside structure Jon Maloy
2025-10-30 12:37 ` [PATCH v15 0/9] Use true MAC address of LAN local remote hosts Stefano Brivio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPr6mk0ARLX6eZ54@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=dgibson@redhat.com \
--cc=jmaloy@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).