On Thu, Oct 23, 2025 at 09:29:25PM -0400, Jon Maloy wrote:
> The solution to bug https://bugs.passt.top/show_bug.cgi?id=120
> requires the ability to translate from an IP address to its
> corresponding MAC address in cases where those are present in
> the ARP or NDP tables.
> 
> To keep track of the contents of these tables we add a netlink
> based neighbour subscription feature.
> 
> Signed-off-by: Jon Maloy <jmaloy@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

Though one nit
[snip]
> +	if (!(ndm->ndm_state & NUD_VALID)) {
> +		trace("neighbour notifier: %s unreachable, state: 0x%02x",
> +		      ip_str, ndm->ndm_state);

nd_state is a u16, so should that be 0x%04x?

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson