From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=vZz83X+T; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 896325A026F for ; Fri, 24 Oct 2025 06:03:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761278621; bh=TlDePnrSePQ5xMyBuKBf6ODvI62BMjJJ/PTtnuAuyLc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vZz83X+T5ot3ZhohF5mqxMo1ZjWJ4F+HRwSfDe38tDZsLvXrZrj/rtJ9kSw+C+VgR y+HWRv1eBkRDn6w5tkswWY6qFmaGHERC2Hqt/3YT7kcw5OvsxqJbmJFKjAGFVO1nS4 kyL8Sgj+N84OOtKbjuxeZtNxuxYnyw0rCOWKnTxwrh0cErbXX+xOkLKma2GLc8LE7T GOPBL1Rj4Yq8mlKWx1V7KEKsOVWEjTz1zcJ9FXZnwesgu9cT4kBuIbmK/GN1xk6Bu4 o8IvHEcqy25H34dwhBWQ/ApzZBZkudj8pYWQOO+J/IOnUlK3dJG2lYiqE/5F9z6fUJ z8gGEcFYdNJUQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ct8Qj35zDz4wML; Fri, 24 Oct 2025 15:03:41 +1100 (AEDT) Date: Fri, 24 Oct 2025 15:03:38 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v15 1/9] netlink: add subscription on changes in NDP/ARP table Message-ID: References: <20251024012933.1933642-1-jmaloy@redhat.com> <20251024012933.1933642-2-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="P3HTYEmzE3mustIX" Content-Disposition: inline In-Reply-To: <20251024012933.1933642-2-jmaloy@redhat.com> Message-ID-Hash: PKCAGMYUAV2HWU3KLZAVLS5NGXGLYP4G X-Message-ID-Hash: PKCAGMYUAV2HWU3KLZAVLS5NGXGLYP4G X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --P3HTYEmzE3mustIX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 23, 2025 at 09:29:25PM -0400, Jon Maloy wrote: > The solution to bug https://bugs.passt.top/show_bug.cgi?id=3D120 > requires the ability to translate from an IP address to its > corresponding MAC address in cases where those are present in > the ARP or NDP tables. >=20 > To keep track of the contents of these tables we add a netlink > based neighbour subscription feature. >=20 > Signed-off-by: Jon Maloy Reviewed-by: David Gibson Though one nit [snip] > + if (!(ndm->ndm_state & NUD_VALID)) { > + trace("neighbour notifier: %s unreachable, state: 0x%02x", > + ip_str, ndm->ndm_state); nd_state is a u16, so should that be 0x%04x? --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --P3HTYEmzE3mustIX Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj6+pkACgkQzQJF27ox 2GdjpRAAiHJtJhVAWT/zG2KnyVJi/+TFBOaRKYl+xi/LOFve6YfBzWtLkCjz+AhE v5yo8DJH52HBoHUjrlDIu69Awq2HHe/+1nQTm62x9DVourKpw06GaDckjA1/Tgkp UFWlVfsQeuq0KrevaQQmuFCvDtJ1Bt7r9EuLuwOEBbbBU/ZM24Srs1FoNIjNF4yZ vUOqfBZ2xNW0FyHYQUZpN+Q5XxdV3pCw+0Y2qYVYZoPcMKFH+sm3RKkex1TbNLKG 1X0lhBnCxUx62oYvI72LQhOl3EJvvN82b26q6NoKSvn3t9lulHGQTceaByPEqdWL 01rqU9Lxr9p/LE6N0YQ7N4ak+KE/L8xBeKfcI2/KfDJHwYVxNm59GIkIBVB93Bto sHICtAQ2yk926+wRgKnIcPy7MO5M0Z4CRxBR3nJKcy0wC/r8HY4/dVWJcYOyrfaM TS0xI1N33C3RcjswCxCdFvYppDjSyhEcRuYVMYdbPqxisl/udCGtca6Ylrj4KZMg lSox0BXAfgxO1m5S+54g4uB9P/ApHEuTPpw6OydbeYCvVUFOYMLJ24odIc2mgKTI u0A3keFNwEUvjSX7DuB6GfromikCdyKRry5FSXMjE5I7jhhlGMjEByks4bN9XgCB M7GZWMxbRMhnZQQU1nBsEUnxdl+Gp9asSud7gYM3xtSNKsRE55s= =y7pA -----END PGP SIGNATURE----- --P3HTYEmzE3mustIX--