From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=S9NLsUFU; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 6FD245A0619 for ; Fri, 24 Oct 2025 07:54:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761285250; bh=ur8b5i37aXFHXlvpSOHierJgN3BirM/3eINPkIUCTh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S9NLsUFUK3w83DjzZ+fVzPbSvGHl8oHvRuxgBvdUnCgNhf/Mimbe/iOlrkZFSNAtX jAXQEl9aMdwYEiitZDQ312kzGVr3LTEHnuUAamjvLbMImSZa/58ZevyKJfuu6mNEeL zsYXmpzwp1vF2TlIw/J18SThrJUhGeNXsQvd5LF1t1JqiIg4z8upItGctBj2iMS/T6 8ETQPVBXlxvKUE2WGjPXmPMSvBtwgHKR0ZiJLped3Clzbv83X7alZJo1nnUB7dGMYB X6cIXer8P+PANzSxcXPM8SDka15cPi7eeEnorgyOGCpOImK7Vjo6VusldL4B1ipHc5 5maxm3AyX4Bgg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ctBtB2Nt0z4wM1; Fri, 24 Oct 2025 16:54:10 +1100 (AEDT) Date: Fri, 24 Oct 2025 16:51:47 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents Message-ID: References: <20251024012933.1933642-1-jmaloy@redhat.com> <20251024012933.1933642-3-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uvD1wsMzhU9d0RR1" Content-Disposition: inline In-Reply-To: <20251024012933.1933642-3-jmaloy@redhat.com> Message-ID-Hash: USEXJ54UNQZNWQIFBYOFYBA32ESLZJZD X-Message-ID-Hash: USEXJ54UNQZNWQIFBYOFYBA32ESLZJZD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --uvD1wsMzhU9d0RR1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 23, 2025 at 09:29:26PM -0400, Jon Maloy wrote: > We add a cache table to keep track of the contents of the kernel ARP > and NDP tables. The table is fed from the just introduced netlink based > neigbour subscription function. >=20 > Signed-off-by: Jon Maloy Reviewed-by: David Gibson > diff --git a/fwd.c b/fwd.c > index 250cf56..93d83e3 100644 > --- a/fwd.c > +++ b/fwd.c > @@ -26,6 +26,7 @@ > #include "passt.h" > #include "lineread.h" > #include "flow_table.h" > +#include "netlink.h" > =20 > /* Empheral port range: values from RFC 6335 */ Not relevant to this review, but just noticed this mispelling of mine. Fix sent. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --uvD1wsMzhU9d0RR1 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj7E/IACgkQzQJF27ox 2GfpkxAAjjDFbfs002iMaE1JeQFFpJ7KBYjRv46Z2s297kVymf+Li22r3GVgIqlR BKVRkeFBKgWiiy+n9AkDEE05QtNUOGIMSnUE5+nr7dX6H94v+FkER4Ht1Xp0hnKX TRDNswId/2BiJnwOEkzOQa8cbT3U83NZztLZJ0OGtRNEXwkS6DlYfrs0vGQ0kC8W irBkVdW2gMmYU4bKSWDtgpbKbqnqAFadqAt3bcZtIH1sz5ZGvYBxNc+NGSr2VaAO Mc0hwBGrevDn/vLICzsNb1YiNk0p0anZvpKWspabYruMW7ijc11uCZFqv/KdQMAX E/TWNjlaTKTZQJMrzgSHBmkZ6bJDSIQuTfaQp8zPf69trSSDeEXgOQtpOYE3nhBx a6fHt9Sqxjp1saceWyL7nQl2iHCTiGDi6K0MMs3c5ANo1JsUWS1rPtexifkWXm2K ZwA7/EnpukVZqBecrZ2cDZJ+Z7FGR/lm++It3w/wVfCQaUFPy9AZuK/G7T19Ho3l alCqyUraSWO7ef2iM2LetWMldszInMWVNwuAURRcRFfbmo+jxVEEIZhs3IZcrFjE NBSMyavRJLHCYM3DNiqObND1k4Yw1D2xkQFUNqj7FL2s53Ph/VMloVTKwUF+7KeT cPYCwwAjd+CPYb7VJ4/SUyTpJTjG72uxPKcBHPTp7yjPhdi9I1I= =n0eG -----END PGP SIGNATURE----- --uvD1wsMzhU9d0RR1--