On Fri, Oct 24, 2025 at 11:11:43AM +0200, Stefano Brivio wrote:
> On Fri, 24 Oct 2025 16:51:47 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
> 
> > On Thu, Oct 23, 2025 at 09:29:26PM -0400, Jon Maloy wrote:
> > > We add a cache table to keep track of the contents of the kernel ARP
> > > and NDP tables. The table is fed from the just introduced netlink based
> > > neigbour subscription function.
> > > 
> > > Signed-off-by: Jon Maloy <jmaloy@redhat.com>  
> > 
> > Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> > 
> > > diff --git a/fwd.c b/fwd.c
> > > index 250cf56..93d83e3 100644
> > > --- a/fwd.c
> > > +++ b/fwd.c
> > > @@ -26,6 +26,7 @@
> > >  #include "passt.h"
> > >  #include "lineread.h"
> > >  #include "flow_table.h"
> > > +#include "netlink.h"
> > >  
> > >  /* Empheral port range: values from RFC 6335 */  
> > 
> > Not relevant to this review, but just noticed this mispelling of mine.
> 
> Misspelling. :)

Yeah, that.  🤦

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson