From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=n9dtrkCn; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id A2EE35A061A for ; Fri, 24 Oct 2025 12:56:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761303381; bh=WeIYUQpuoueCbG2as9bTyAPnlWeUjDAPNQ93fnR+6dk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n9dtrkCnomJKu5CjltrhdiRoKT6ujK/W8qHOl6Gvs28NrnuQntZYRHk8FbWbtSX7s KnQVgP+uGOe6IrZD+QFYPev3zqrVDxzRtQPkfHDfHDxDiyLwM2M6QMA9BVxaawcq/F Au5h/9y8rCqIL6osZt6Yu68WL2sYA4lxQ2MPugnq+/uM6R8q9+2MhalJevfy3zdwRh SxoklTfpJjtULqbxbuEjbCenh6OJPs0Fs6XQ9HPz+bk6Dj+U4WzXtKRsImh5vViNjp 1lP+wwpt5wYxZeXrTAvyHfJObMsZRqkrlfrzRN0MGnQDf0qdq5sq1fsW5Rlm0KQ5zL HWS5BfdP6a7+w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4ctKZs1MXxz4wM1; Fri, 24 Oct 2025 21:56:21 +1100 (AEDT) Date: Fri, 24 Oct 2025 21:43:15 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v15 2/9] fwd: Add cache table for ARP/NDP contents Message-ID: References: <20251024012933.1933642-1-jmaloy@redhat.com> <20251024012933.1933642-3-jmaloy@redhat.com> <20251024111143.1ad93bc7@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CXgD+K8GdbBCQwU5" Content-Disposition: inline In-Reply-To: <20251024111143.1ad93bc7@elisabeth> Message-ID-Hash: ER2VBHRDOPOFALVA6RV7XVTHEJIDMCE2 X-Message-ID-Hash: ER2VBHRDOPOFALVA6RV7XVTHEJIDMCE2 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --CXgD+K8GdbBCQwU5 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 24, 2025 at 11:11:43AM +0200, Stefano Brivio wrote: > On Fri, 24 Oct 2025 16:51:47 +1100 > David Gibson wrote: >=20 > > On Thu, Oct 23, 2025 at 09:29:26PM -0400, Jon Maloy wrote: > > > We add a cache table to keep track of the contents of the kernel ARP > > > and NDP tables. The table is fed from the just introduced netlink bas= ed > > > neigbour subscription function. > > >=20 > > > Signed-off-by: Jon Maloy =20 > >=20 > > Reviewed-by: David Gibson > >=20 > > > diff --git a/fwd.c b/fwd.c > > > index 250cf56..93d83e3 100644 > > > --- a/fwd.c > > > +++ b/fwd.c > > > @@ -26,6 +26,7 @@ > > > #include "passt.h" > > > #include "lineread.h" > > > #include "flow_table.h" > > > +#include "netlink.h" > > > =20 > > > /* Empheral port range: values from RFC 6335 */ =20 > >=20 > > Not relevant to this review, but just noticed this mispelling of mine. >=20 > Misspelling. :) Yeah, that. =F0=9F=A4=A6 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --CXgD+K8GdbBCQwU5 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmj7WD4ACgkQzQJF27ox 2GctrhAAjftuPhnDF9jeo4tTmO5yV7SlocovOKC9jWWtXO4bztCYafujgg9hsS4e lN0E9jqrJ/o6rrrbKk6Il5oFiWKUTcuA3tAcEi99JjXJV6JKDGGMDyOMd+ppqors AFS0mAKmM509puTFuC3NFFTsny535ePyvmzFm/1kjCncFa8uHRSHoePRsetin8Se inhWdrNoM3xPfvR5k9IGxk0zmQWk3FyuTs/yIhWoAah6azTfiIhzoHodIp7UBy5l ePvWeXz2cQb+t2PKCRwD0ELw6xtEwXT9zKbE83x6axh9NiRBsATZBw6FJO1/lBoD 9aKU8oYtde3FbHS8palJJX/vMkXugcKZGH9vPI5Ua8mIbyIDTJtD1LDTU/Qkfxjt e0LcPPEK/b6cXGGdAX87df1Gtl+TIEuD3X7dtDji57qsdfznxjt+ueanFLTYDwJy c/JcClk34jNSr8oVGcUGerkLbMAw/QJyCl/Sa9roIqVVDtw6vK9FihIEu0CPUFno TJSCDDJZhRjGiI1+SkifJgyWrzNwj36LQvce2isTQX6cla4GHIJ2bLeIwH6nTcr8 nP65UVSMF2sEVb5AV2xRX/YqohbZH3Bszynd3PpqUnOtEspN6REsut5Zs0x0lPl9 H/moUzAEl7vWx4amT4oft0j/4SbXfo6UO1fhLNCmnepYu/SxCaI= =aERw -----END PGP SIGNATURE----- --CXgD+K8GdbBCQwU5--