From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=kFUV9Tt+; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 96DE05A0619 for ; Wed, 29 Oct 2025 01:25:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1761697522; bh=0nhvVEbkcyYW6/XgGQfv3r4W6jlOfqAvzzF9ssDKDPU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kFUV9Tt+zBTS0yR2mfiDznrtYl+UcJCPs/uNw3+9rHnRycSxLqpIgfsPepLtrDyjP sl9Fv7Fe6SI2NA17NBokeh61xPhbcT3pfV1ALshTMKAfyuvwJHEPnur2hTLWK2VVFw XV4Gt9+xo+KUoVcWKj6Q+oC2vPf734dDt+iCmxZtYunRN3eTv1yEDK8F3nUIdXNPot eYNzrbo6iPY412asQgSKdkyYpVVTwbxr2+GfmMLFqdS6g/RHsCZd2HabjzgtgMtd+k /9j+vP0P6ErVnuuYUdMkOz3p7yeZn++bkUkIfdkdi9DvVL6/J/fVYZ4uKbV6DUZf0j 0+n97rwZjm+WA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4cx7LV4N5dz4wCm; Wed, 29 Oct 2025 11:25:22 +1100 (AEDT) Date: Wed, 29 Oct 2025 11:25:11 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2] tap: Update some function comments for accuracy Message-ID: References: <20251012234941.1433683-1-david@gibson.dropbear.id.au> <20251016014624.4e2e9bc8@elisabeth> <20251029001314.1abb8993@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6cxSFsrKLjXOdZok" Content-Disposition: inline In-Reply-To: <20251029001314.1abb8993@elisabeth> Message-ID-Hash: ZFIMZXT47K3KNIRKFK7VFO5GYUVDMVLE X-Message-ID-Hash: ZFIMZXT47K3KNIRKFK7VFO5GYUVDMVLE X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --6cxSFsrKLjXOdZok Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 29, 2025 at 12:13:14AM +0100, Stefano Brivio wrote: > On Thu, 16 Oct 2025 11:47:22 +1100 > David Gibson wrote: >=20 > > On Thu, Oct 16, 2025 at 01:46:24AM +0200, Stefano Brivio wrote: > > > On Mon, 13 Oct 2025 10:49:41 +1100 > > > David Gibson wrote: > > > =20 > > > > Several of the tap_push_*() functions have doc comments claiming th= ey take > > > > the context pointer, but don't. Some (tap_push_uh[46]) were broken= fairly > > > > recently, but others (tap_push_ip[46]h) have been broken for a long= time. > > > >=20 > > > > Regardless, fix all the doc comments. > > > >=20 > > > > Reported-by: Stefano Brivio > > > > Fixes: 82a839be9 ("tap: break out building of udp header from tap_u= dp4_send function") > > > > Fixes: 87e6a4644 ("tap: break out building of udp header from tap_u= dp6_send function") > > > > Fixes: 2dbc622f5 ("tap: Split tap_ip4_send() into UDP and ICMP vari= ants") > > > > Fixes: 9d8dd8b6f ("tap: Split tap_ip6_send() into UDP and ICMP vari= ants") > > > >=20 > > > > Signed-off-by: David Gibson =20 > > >=20 > > > Applied, with one minor change to tags (I plan to add some stuff, > > > including this bit, to the new CONTRIBUTING.md). > > >=20 > > > For consistency with the Linux kernel, we use SHAs abbreviated to 12 > > > digits there, even though 9-digit abbreviations (produced by default > > > git-publish settings, I guess) =20 > >=20 > > No, git-publish doesn't manage Fixes tags. It is the default for git > > blame, though, which is where I would have copied them from > >=20 > > > are unlikely to ever lead to any > > > conflict for us. > > >=20 > > > Well, that's true at least until the day you all discover > > > https://github.com/not-an-aardvark/lucky-commit, but at that point the > > > number of digits wouldn't make a difference. > > >=20 > > > So, to keep the consistency consistent, I changed those to 12-digit > > > forms and dropped the extra newline (also added by git-publish). If > > > you fancy a script checking that for you, see: > > >=20 > > > https://lore.kernel.org/all/20190220213729.49deb54f@redhat.com/ =20 > >=20 > > Thanks, I've put that into my local hooks. >=20 > Thanks. By the way, there's still the occasional blank line before > Signed-off-tag: in your patches, which I'm fairly sure comes from > git-publish. Nope, I'm pretty sure git-publish doesn't touch those, it's just me. I sometimes break up the tag lines in what seems like a more logical / readable manner. I can stop doing that if you'd prefer. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --6cxSFsrKLjXOdZok Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkBXuYACgkQzQJF27ox 2GcZ8g/9FUoMTAnNHCtPVOjNfCK8HW504LN7YdSCbvW1Ejjum23crF/VU1JGF2jU V/W1hHOm3a3T2ZMpYgMDDzwgnGr0clBNAURsK8ZT8bgg1uwmD6WtBC5UmSnnpfB+ aWgOK22vabWznnrWW7vH5BX0p446MUijayDWw4WeAEwiOXIjYOx1BY2f/9JA5P88 nFaGpndtCONa3NxVN+v2UsAIdlVoDR0tzDizlXQQhfP8rFWW4xcvL1xrkFm//Z4q uyguociv6R5IWxGtIYJPsaeIkGuk6WL5ejTaMmLi4T03GqXxX52etF7zEEco0fKO bL9QeslBq0ECsCyiJCh5PFaezz9lnnP8rzAdnxeREoEGtzgp2JB0YdgkoJQj5qbV NREBPxIXkkEAC9zA426YuMGjW52f9vqOHEBFyJ4TCDj3jA3JWsrm3u/WF/L4WBkM m0uEon10rxGdcycRKX+SUUtrXfosDSerosVXv3yy3/BwnICzR7ifVPTAZpaLpryo Z500yF4bTi69inyszBqQiTagcpqSz6UoBVq/WkWHHZtpT9LNcvOaxeiscfVLyJEN hUsqWG1ImSuUneTACUjnxo5mLTthknpgq1txzcp/FBj4qjsw24prtDWTqyESMvGT QOAYI8a7z6jIc4ZfvVGQ5UuuDehupx8EJ8ynF3Z/joHx/RgRkdw= =CykQ -----END PGP SIGNATURE----- --6cxSFsrKLjXOdZok--