From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=uF1yppbW; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 30BAB5A0619 for ; Mon, 03 Nov 2025 11:51:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1762167113; bh=NKa6aZZG55s55yO7KNxink/8s71/c/5w+LqqvHonaL4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uF1yppbWQN8qlsXuUzWgZGLjOteZqO2d2yscM25dj3Fho3jUnEeQzREa/LYJVqUj1 K0mL4IryOqJZWLMqc1UWVCZfUFwlM36YjzrdIOJRnAB5Ovw8jRfwr22hIb1dP2LrPS IydrU9fMRT+QxoFG1sT7zGfc4W/2ee63muhSXCuNbAbEMaMZHjSXq8vYPCN58dT+0U sNH5HDS/FUQuUa6EIvGndx5WSZh8AtrbPPgwDS0MPxQwdUl4j9YBu8ujQqPCbqvaMz vey47sjGajHPy25PHDpGQqbDEWYjCPgKIUY1bvHoYhl6+dv+qhKPRlIvMJFsG5LYsX JUFYssJWmuVjA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4d0T1519Zyz4wCk; Mon, 03 Nov 2025 21:51:53 +1100 (AEDT) Date: Mon, 3 Nov 2025 20:37:57 +1100 From: David Gibson To: Yumei Huang Subject: Re: [PATCH v7 5/5] tcp: Clamp the retry timeout Message-ID: References: <20251031054242.7334-1-yuhuang@redhat.com> <20251031054242.7334-6-yuhuang@redhat.com> <20251031093822.6fa93b7e@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bRU0itdir+cJkKhj" Content-Disposition: inline In-Reply-To: Message-ID-Hash: YMSQYQPKCEW32TBBR4T4LMPHCXPE3AR6 X-Message-ID-Hash: YMSQYQPKCEW32TBBR4T4LMPHCXPE3AR6 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Stefano Brivio , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --bRU0itdir+cJkKhj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2025 at 11:11:10AM +0800, Yumei Huang wrote: > On Fri, Oct 31, 2025 at 4:38=E2=80=AFPM Stefano Brivio wrote: > > > > On Fri, 31 Oct 2025 13:42:42 +0800 > > Yumei Huang wrote: [snip] > > > diff --git a/tcp.h b/tcp.h > > > index befedde..a238bb7 100644 > > > --- a/tcp.h > > > +++ b/tcp.h > > > @@ -59,6 +59,7 @@ union tcp_listen_epoll_ref { > > > * @fwd_out: Port forwarding configuration for outbound pack= ets > > > * @timer_run: Timestamp of most recent timer run > > > * @pipe_size: Size of pipes for spliced connections > > > + * @tcp_rto_max: Maximal retry timeout (in s) > > > > Nit: "maximal" has a slightly different meaning compared to "maximum". > > > > The highest value allowed for a field would typically be called > > "maximum", while "maximal" is more commonly used to indicate a value / > > element that's the biggest of all values. Yes, I know, it's complicated. >=20 > Yeah, it's complicated. Actually I get the word from networking/ip-sysctl= =2Erst. >=20 > tcp_rto_max_ms - INTEGER > Maximal TCP retransmission timeout (in ms). >=20 > "maximum" might be more appropriate as you explained. In mathematics, the difference is well defined. "maximal" means nothing else is bigger than it, "maximum" means everything else is smaller than it. Those are the same thing for a total order, but not for a partial order. Since integers have a total order, either would be correct here, according to mathematician's English. Of course, that only partly overlaps with everyday English usage. I think either would be fine, but "maximum" is probably slightly better. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --bRU0itdir+cJkKhj Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkId/QACgkQzQJF27ox 2GfIFg/6ArjXeXPmzNcMuIgiOXfMpQGWw2qeyHTE3LpeMkMIkZH1lqmz4co8yG80 s4DY0I42uOdifM+v7vhS2ACRvC/2NOX5tha884OOgVKNjpm16O0mPE5FIVmhO30m NX6zFswMLmAmiCAzoXMd1GL4BTlM3ALsaNqsUs0ZwUxwY+/0CQlWYFNVuuaFXE4s gsa9RqvTg8vk3q4z3f32D+xxa9cBZSSAMXl8YpCiu2nRzSWsiO6rz8PPtyiy8kRc 85+qkfN29XIWWiEFiYUUdbFVFMnEm9LvOJxLEgEDFKScxYnL2bs3+xIeCQCNVJuH cxXIpzV35eaq6+F3bzJrrSfL5k+YDsuYw5JarA0d7KVnsXzoN+dHlYTMwNhInp5f Lm55f+o8XHM+r8H3zjEU2yFIX/A3D4oWSt+MRLzNb6VJWHkL2YyJLPD/UJs1fmg8 i2MSQWimVjOoI9QkpKFdd7hlJ9R8n7aGpT79n5YWJdFmPYvGyVJfjeqOom0SeYrX Jr3DSdIih67oXivLrTKrFEKCB7zBhz6pTwWCdvtC0K2BwbdO6XOlbR/iO3kJ/wZI ubxlwZ9H7CBU94Pv9nWomsyM+P27iC50hFCiE/Pju7nLt24hleKO0b0gmRN1vgiK XWEOYtZNNl4Hb2WqYUwMftSYeKa+1rxTymKkN5SQxGoqXKaKFIY= =thkq -----END PGP SIGNATURE----- --bRU0itdir+cJkKhj--