From: David Gibson <david@gibson.dropbear.id.au>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: passt-dev@passt.top, Laurent Vivier <lvivier@redhat.com>
Subject: Re: [RFC PATCH 2/5] tcp: Fix coding style for comment to enum tcp_iov_parts
Date: Mon, 3 Nov 2025 22:03:01 +1100 [thread overview]
Message-ID: <aQiL5RQhTzczJtSF@zatzit> (raw)
In-Reply-To: <20251103101612.1412079-3-sbrivio@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1040 bytes --]
On Mon, Nov 03, 2025 at 11:16:09AM +0100, Stefano Brivio wrote:
> ...as I'm going to add a new value to it.
>
> Fixes: 95601237ef82 ("tcp: Replace TCP buffer structure by an iovec array")
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> tcp_internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tcp_internal.h b/tcp_internal.h
> index f55025c..19e8922 100644
> --- a/tcp_internal.h
> +++ b/tcp_internal.h
> @@ -57,7 +57,7 @@
> #define CONN_V4(conn) (!!inany_v4(&TAPFLOW(conn)->oaddr))
> #define CONN_V6(conn) (!CONN_V4(conn))
>
> -/*
> +/**
> * enum tcp_iov_parts - I/O vector parts for one TCP frame
> * @TCP_IOV_TAP tap backend specific header
> * @TCP_IOV_ETH Ethernet header
> --
> 2.43.0
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-11-03 11:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 10:16 [RFC PATCH 0/5] Pad all inbound frames to 802.3 minimum size if needed Stefano Brivio
2025-11-03 10:16 ` [RFC PATCH 1/5] tap: Pad non-batched frames to 802.3 minimum (60 bytes) " Stefano Brivio
2025-11-03 10:20 ` Stefano Brivio
2025-11-03 11:02 ` David Gibson
2025-11-03 11:00 ` David Gibson
2025-11-04 15:25 ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 2/5] tcp: Fix coding style for comment to enum tcp_iov_parts Stefano Brivio
2025-11-03 11:03 ` David Gibson [this message]
2025-11-04 15:18 ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 3/5] udp: Fix coding style for comment to enum udp_iov_idx Stefano Brivio
2025-11-03 11:03 ` David Gibson
2025-11-04 15:18 ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 4/5] tcp, udp: Pad batched frames to 60 bytes (802.3 minimum) in non-vhost-user modes Stefano Brivio
2025-11-03 11:58 ` David Gibson
2025-11-04 15:31 ` Laurent Vivier
2025-11-03 10:16 ` [RFC PATCH 5/5] tcp, udp: Pad batched frames for vhost-user modes to 60 bytes (802.3 minimum) Stefano Brivio
2025-11-04 15:50 ` Laurent Vivier
2025-11-04 16:09 ` Stefano Brivio
2025-11-04 16:28 ` Laurent Vivier
2025-11-04 17:26 ` Stefano Brivio
2025-11-05 3:49 ` David Gibson
2025-12-05 0:51 ` Stefano Brivio
2025-12-05 4:12 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQiL5RQhTzczJtSF@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).