From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=nVKRlhlY; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id C76515A0619 for ; Mon, 03 Nov 2025 12:03:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1762167821; bh=h88GQAn2MHNZGnroWXnJ3ql4pGsyn1roMgcEUNTcAck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nVKRlhlY44otQHZl/2H68YUbgIyPZ97ZOQIUcEcWE64y8o5JEN2Y12AijxIRdDwEi RKcHzLLCVas8KcmS50hqDBpqp+MhSQRcz2K+NHRX/DD+lhaphsHAW/Y/Sg8KS9H1VO 9GBSsx8tmLEesV0msPGdkbsFM0QFENAVfXHj8U0p17GNvL0/rGyN1tLLB91U5VhvaV NmA+XPnoYydMEQ33tulG19AHBR006V6nxsg2/J/4qYTG4xcFXDHAmc8XkXRPNIitwQ 1SIsWDUF3zb8bL/kkL9rofJ35no/5/kkElyPnLi6iJoUn5R2Mucyy9tRsigCPX/V9t rkevoqgW5/kAQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4d0TGj5t22z4wDR; Mon, 03 Nov 2025 22:03:41 +1100 (AEDT) Date: Mon, 3 Nov 2025 22:03:01 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [RFC PATCH 2/5] tcp: Fix coding style for comment to enum tcp_iov_parts Message-ID: References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nVHXf1EblBq3nUd6" Content-Disposition: inline In-Reply-To: <20251103101612.1412079-3-sbrivio@redhat.com> Message-ID-Hash: YYQDXJKBJXJWVNJMERWZY4HBEXSBO6VU X-Message-ID-Hash: YYQDXJKBJXJWVNJMERWZY4HBEXSBO6VU X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --nVHXf1EblBq3nUd6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2025 at 11:16:09AM +0100, Stefano Brivio wrote: > ...as I'm going to add a new value to it. >=20 > Fixes: 95601237ef82 ("tcp: Replace TCP buffer structure by an iovec array= ") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > tcp_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tcp_internal.h b/tcp_internal.h > index f55025c..19e8922 100644 > --- a/tcp_internal.h > +++ b/tcp_internal.h > @@ -57,7 +57,7 @@ > #define CONN_V4(conn) (!!inany_v4(&TAPFLOW(conn)->oaddr)) > #define CONN_V6(conn) (!CONN_V4(conn)) > =20 > -/* > +/** > * enum tcp_iov_parts - I/O vector parts for one TCP frame > * @TCP_IOV_TAP tap backend specific header > * @TCP_IOV_ETH Ethernet header > --=20 > 2.43.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --nVHXf1EblBq3nUd6 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkIi+UACgkQzQJF27ox 2Gd4pg//eBbcgCdXVBrBndVTu+0iweyW8MIqflnNsJKpuaQ9/tGQDcBjzIGEl0IG 4t2d65sbOYKaUgkZTnL4aR7fMyWrg7JORzCEOOR+s4NhGFqdPzHpomudhXETJIGW TzqxmI38J1CrCmOYXPsBgmTZPRU3PQpYx7LpDNngmjaaQBagYBMTimgYI5g3gbLE /Hbk2TD05ncZNpMMVdFU9wpiq66zsFmD4/QL3qJRp/tPfAkgNY5irq1dndLPesd3 f+pjC/SnBxqmvBO/y8cc2bjuZT9zuKs7ohbixL6R553jQORqUS9y1GqWjYQNprVT nJL40WQpHv6HXJvElGm8aeYNprUly+dEg//70eWBMiUXeNntFZE6tNmrHqnmzQh3 A3DOB5M6xTCghslgcwCAbxtzLszH8IGjuLQ6+UkvgFrCd1w4XFGwr4DogIBJvfZA xo+MS9ds33B6xWH2yOMrFCtxIsXLoRnaXnOI7Pr2vpV2ljwIsrp0obnwMhP0LEDp I29iaiFkFeVeM1G0YezQbe32ErTNJIDhwe2MAxdTw4PB8fQoBg6Y1bGMWC7UrjTs fmtKL4PUYTogYuvYsElCb8IdRvvIzmnw8o/lBMD3NaZMWAHqUdSSXv6scCpTjxXV RRoO00MOEZqTwwPW+YVQRq9/F9cYdy7C3PyKKIkiYy/UwjlO+WQ= =rTq5 -----END PGP SIGNATURE----- --nVHXf1EblBq3nUd6--