From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=DKe0TCvy; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E94E85A061B for ; Mon, 03 Nov 2025 12:03:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1762167821; bh=7Aub3enniHl+8wnDEWaYPq6jddgNh+aqsMjATIEi4bQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DKe0TCvyKAbpT5DUtXk73ntF2mdwO75cRbHaDpwkf1x5ZpEgf22iTpOy7fpE2FEkR bH88JMirjEIbSzftsfoBH506QbcOSrsL0zXLqUGUrprroSpvoAwSzg8Tg1ySQ0Suzm 3SRfyk8qc7AsM4uBhhitEs6nsg0kXWy2xz1uimT10c/aMRItcjQXY489rpj75/9XLA /tAg/qDxkciU6bvWJelsclQikuItAQwG1gLVFLK2CdQjzQ7g5RFBYDY49H7owobTGo F3CKQaKMHoJ2NudMnrzIkhwyMRV/S6P6Y+scPI5h/BVHtJz0Wbs/6YobLH9ydSmxBY +LYyZFHx9/OZQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4d0TGj62MMz4wLw; Mon, 03 Nov 2025 22:03:41 +1100 (AEDT) Date: Mon, 3 Nov 2025 22:03:37 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [RFC PATCH 3/5] udp: Fix coding style for comment to enum udp_iov_idx Message-ID: References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-4-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="1liFvxYTeVVEz6r3" Content-Disposition: inline In-Reply-To: <20251103101612.1412079-4-sbrivio@redhat.com> Message-ID-Hash: A5U77W3FU7KFY4I4L6ZIOZ4UH3WI2HVD X-Message-ID-Hash: A5U77W3FU7KFY4I4L6ZIOZ4UH3WI2HVD X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --1liFvxYTeVVEz6r3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2025 at 11:16:10AM +0100, Stefano Brivio wrote: > ...as I'm going to add a new value to it. >=20 > Fixes: 3f9bd867b585 ("udp: Split tap-bound UDP packets into multiple buff= ers using io vector") > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson > --- > udp.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/udp.c b/udp.c > index 9c00950..0e37e77 100644 > --- a/udp.c > +++ b/udp.c > @@ -164,11 +164,11 @@ udp_meta[UDP_MAX_FRAMES]; > =20 > /** > * enum udp_iov_idx - Indices for the buffers making up a single UDP fra= me > - * @UDP_IOV_TAP tap specific header > - * @UDP_IOV_ETH Ethernet header > - * @UDP_IOV_IP IP (v4/v6) header > - * @UDP_IOV_PAYLOAD IP payload (UDP header + data) > - * @UDP_NUM_IOVS the number of entries in the iovec array > + * @UDP_IOV_TAP tap specific header > + * @UDP_IOV_ETH Ethernet header > + * @UDP_IOV_IP IP (v4/v6) header > + * @UDP_IOV_PAYLOAD IP payload (UDP header + data) > + * @UDP_NUM_IOVS the number of entries in the iovec array > */ > enum udp_iov_idx { > UDP_IOV_TAP, > --=20 > 2.43.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --1liFvxYTeVVEz6r3 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkIjAgACgkQzQJF27ox 2GfBnw/+Kp5qsgm2ghiBW+VGbRmDtn3N3DCZIm+x84ss27u/zkqNGRDLljYG4Q+b CKnwi5lZpfVqS5Z4FzCT1FnDM+C9P8k5YeByn1m5HmmCXCWF+bqkIqe1WgHHB8j1 IgMPoXaK3yay07hlcNc79l4aeqToJTjDB592SSXpk6O4mkx6ri9fMauVPJpbHCoa o6TnjKGymWBh5PafI6DfXuB1oIrMZWg+Clq3B5b1s7wHJuc0lethVQ7+oJvXLx+5 JRsZGpxycYBMKrQ2QS6BXFLhAkQgGe/5XKc99D2l4ZTvkVpaZRudsqSz44zp65zW sQIULqVG8UI/IxgKxeQ1lngzZpVWqSDH7VWMF7YBCzmKVF+BgqpjUF4nI+tG1RXz D7jTLTox3nixGtBr+RlaEvvY6+6RHtTIT46+v5Sk+Z2SbbDlk9+fWsQ7SFTRCzKB KTWZEWT1oEs1bCsvYREInTEB/imMiSPbX/Ha+qkoGVv/jCvladtuxQlryYuZrMMS gCB4gS1XpHzApBIQ2PSDznlWSGWAekauACA/riECCPK3SpXduW2UgN0hV0YpFCJO WN4VSEJePJNBHWV5aC2por4z2zC7JPJ0rlqDrFjQr4Os6r50KII/XfA8b/b0EGDK mR4extT1so42OMJtqj0S8cKOJuys/ydWKEVNNTLfITUTJiFUCMA= =KTRR -----END PGP SIGNATURE----- --1liFvxYTeVVEz6r3--