From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=fJJ73BxX; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id CDCDC5A026F for ; Wed, 05 Nov 2025 04:59:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1762315142; bh=zdRFnzejzem0R/0bwo4R8C6+rr3g66KBdyc92qj4R9U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fJJ73BxXwIJ67LNioycOcGbsx7SN+gBQqGy8jJD46w6tSYF+H4TPLQM/VAd/SvfWS ZGf5KaBr0lkfsvQgYI91cmyDCsypAFxHvSrLyut8OrN5TzGYD0nUog2xzRbfsfumFk 8fEIYMeLwpcE2zJDyHRiYrodwI8/vXWxI0Oozykt53OmZzXl/z1fUHTCuRP5tp+XZ8 hbieRsxvq4ffg5d7rpbh+aEmWhc4LnC4z+MZHdZpWR7/iZpA3GU4s93hVz7HbzyML+ uSaQUnUMW5a0WlXb9KY36laRtNqNyJ2u/IH4eGkiXBD95EQpTeDZeyuT6TPYiFIhb5 5BYFcNFUOORVg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4d1Wlp5GgYz4wM7; Wed, 05 Nov 2025 14:59:02 +1100 (AEDT) Date: Wed, 5 Nov 2025 14:58:57 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [RFC PATCH 2/3] iov: Fix coding style of basic (non-IOV_TAIL) parts Message-ID: References: <20251103101629.1412331-1-sbrivio@redhat.com> <20251103101629.1412331-3-sbrivio@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zucEM/MXs+6+VkK2" Content-Disposition: inline In-Reply-To: <20251103101629.1412331-3-sbrivio@redhat.com> Message-ID-Hash: TFI5UNLV43HGCN2EQYP5ZABRRJL3GDJX X-Message-ID-Hash: TFI5UNLV43HGCN2EQYP5ZABRRJL3GDJX X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --zucEM/MXs+6+VkK2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 03, 2025 at 11:16:28AM +0100, Stefano Brivio wrote: > As I'm going to touch those in the next commit. >=20 > Signed-off-by: Stefano Brivio Reviewed-by: David Gibson Overall a big improvement to clarity, though one note below.a couple of not= es below. [snip] > /** > - * iov_to_buf() - Copy data from a scatter/gather I/O vector (struct iov= ec) to > - * a buffer efficiently. > - * > - * @iov: Pointer to the array of struct iovec describing the scatt= er/gather > - * I/O vector. > - * @iov_cnt: Number of elements in the iov array. > - * @offset: Offset within the first element of iov from where copying= should start. The old description is, I think, wrong... > - * @buf: Pointer to the destination buffer where data will be copi= ed. > - * @bytes: Total number of bytes to copy from iov to buf. > + * iov_to_buf() - Copy from iovec to flat buffer > + * @iov: Source iovec array > + * @iov_cnt: Number of elements in iovec array > + * @offset: Source offset altogether, counted in flattened iovec =2E..but the new one I can't parse. > + * @buf: Destination buffer > + * @bytes: Bytes to copy --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --zucEM/MXs+6+VkK2 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkKy4AACgkQzQJF27ox 2GfL3Q/+PR+HdlFGCwcXBgqItqgr8O+NWRHH8eyjLFqS1QEzaJqAR8o45JJypgtj VpEg8yTRMzjN7JR0JKLv9UkLyGbqhEjJJEEMjTykOUW958CBvGMadQq4dX2f7E1P N1qw2a2sGJSFA2fJUVctRm9H8jeY9FtGLy7MIMRhxGkXXAEPrDuxsDi6V2B5OQkc oitYzqGQz12lApyWIMzbkYyTBMhhuoiDv5LJANUDQ/PdagAxBPaUF/tEv5LkNQv0 sq9ukn+87Yc/r61CE7QwlObNHU9mTJAXEVE4uD84Q3EcJpv3evVY14PASiIITU98 ExL9bV0rDuhd/kaSm6t7LA6+17pS6q/OREfgTBW88FtQZ9JWvUEDLOQF9ozdSUMj W113Gcsc8WV1E+2oV+0cnatQcBDunBRUf2y/AN0EuVR1rdaJ7soXoQklzClnHs1P 8xRbzuSe8jmIrwZgET2QqUIc/ojLgEYs1owq06d79/YQHKNoI8sioANP7SNUSaFH z8EeIiQc0UhoPy7wkr6cTZzLR6jfgX4pUfQoZctKhhemTtBOhzDjG+rOIrSOHfVi mXyGPZhvgkzZccWqWx+HxzWx1XIb3uvFmLdeOusWNmrTTqEJ5B73Fna3GTUT+9rX NifLBEp2gRyA0GVv48/SoDohl7At/rcEFLFe/UVWSqXqsTueIik= =Q0XR -----END PGP SIGNATURE----- --zucEM/MXs+6+VkK2--