From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=yEIMAEpu; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 4772E5A0271 for ; Tue, 18 Nov 2025 01:17:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1763425035; bh=QPXYbIZqs+p+lubfM1fdiU7UNtwKulkwOBzc/IUzt58=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yEIMAEpuiw2htF32s9npsURKYQYyvQChuS2YwHR++fokJGxmDtdOKpXMu/412kK3M HLHCQ8B0Yf0PSQJEC/UmbR+Iy64xtaN7X5lwB+ajEPIX8u8eZemXBmq7hj1sY6IrqV feKHNAL35WOnpgwF+WYPdNiYRyiOXkZ4fxIDK6ZaY0237rPhMUSJkQHrLPY5uB/FYa F+KjaAeW3RyrQEWSPgMqP5Tkke+ZwiLwQVMY+KrdwKMccP1+ZPPongnoX8iegGIUK9 H9W5DHHysy+koyLCc95dIuZ6LA+5BaTao6CGtEwbv/dq+8Gk2uykHSTOJV7tDqtILd ZP4deoxlN5VPw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4d9QCv0qpFz56lV; Tue, 18 Nov 2025 11:17:15 +1100 (AEDT) Date: Tue, 18 Nov 2025 11:16:45 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH 1/4] vhost-user: Enable multiqueue Message-ID: References: <20251107143901.89955-1-lvivier@redhat.com> <20251107143901.89955-2-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="l5vbGcWggWos1vMI" Content-Disposition: inline In-Reply-To: Message-ID-Hash: OHJL46QU33NPH7SW7FCLRS34J5EDCQPG X-Message-ID-Hash: OHJL46QU33NPH7SW7FCLRS34J5EDCQPG X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --l5vbGcWggWos1vMI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 17, 2025 at 04:26:43PM +0100, Laurent Vivier wrote: > On 11/10/25 05:48, David Gibson wrote: > > > index aa7c869d9e56..c668159e29b4 100644 > > > --- a/vhost_user.c > > > +++ b/vhost_user.c > > > @@ -323,6 +323,7 @@ static bool vu_get_features_exec(struct vu_dev *v= dev, > > > uint64_t features =3D > > > 1ULL << VIRTIO_F_VERSION_1 | > > > 1ULL << VIRTIO_NET_F_MRG_RXBUF | > > > + 1ULL << VIRTIO_NET_F_MQ | > > Should this be conditional on max_virtqueues > 2? >=20 > I don't think it's needed as 1 qpair (2 virtqueues) is a valid value with= VIRTIO_NET_F_MQ: >=20 > https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.ht= ml#x1-2410001 >=20 > "The device MUST set max_virtqueue_pairs to between 1 and 0x8000 inclusiv= e, > if it offers VIRTIO_NET_F_MQ." Ok, that makes sense. I think I forgot this was offered features, not required features. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --l5vbGcWggWos1vMI Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmkbutsACgkQzQJF27ox 2Gdrdw//ZA6zBKMnh0YP20Nx8WphH4u/AMkVmKd6+GyJVumK/u8NwoQmmAItesuZ DyCASC34urY2FjLXdJb5s2VrTcMi/ryGvF6LdeQnUW/4Mhofs+0wn5TZVOmBWkfN 0CwA0e++rfGxI3O8XMGSn2Tp99KNz9hje4a7ZXq36fL+0wOlZVHBLF9bznYzVcv4 hZK7ZAtYdeiD+UQ+uwWr0BZlSb6vMVAGqoDka6ja2mlq7YaDJ71mWX4QEbzyoWVt Uc6b1UgMiCBL5+THlQ/mm72gX/hk3SX4y1L1mviZ9Fd94BEEvt1xUn07EkyPnMgU NnXEhzRZ4Cj8tWqcX0VcGYUmIZFz9GhIsY/0Lf+tK0xb+hzPpCYKpoiAMB593ebl WAxlv+E6dCmCWsGA5UmTLV7aLGrMD627B1/uu3MHDVtN58w3COZIukZhR0Z8usIe mWP3z63G+2KpeO3+ilw+VWiLVX78ZMBqapRGDoULiXT42XxGfxZWLCIPurjH1f8I RhwwLrkH+G2EDEJqAPMTscAJj7+r0EioOra2cvz5YwKa/4QPyXgFEMiQScWOwrOV FriGHAqRuh8N6ql3UBWEkO/4jWjpRa+PTy2Ju0wsKDwA8Om4GPzZ6oKkxOlpDAEV H1JdpWB5HqZLQGr0JQrWLStWdIOvdU6+a200KoFa5WqqsX5k8S8= =JLiz -----END PGP SIGNATURE----- --l5vbGcWggWos1vMI--