From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202510 header.b=HsasYjDl; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 1797E5A061A for ; Fri, 28 Nov 2025 02:02:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202510; t=1764291717; bh=Xh/7FVMNKmGU3HVO5/aAkVEwaIrO2mFwLQoGcWDuuh4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HsasYjDlCWEpmsFPTQqLG8kgzdWLeWZvsbP85pjX8a5uTUnCNb9x0Ba9r2M9ICjW6 JhjHXEpGlcE1xfHidMPrUwXNlIaWhFDQWmX0CI7cou45YrtqZhtZWpQNkTcMNa6+dA fI82uNDezvME7EVuONl6UmmEtzyKX9sD487eMWcnrvvEo06hsbYVyER9ajr5nUTv8u Kzakiea2iSansRh/QTc3gzWlTauQt63VtMfOR9op8YsDvcsY8coLOO2rjmGkPZskf+ 1ASBVYEx/BTm9VbTpa6qABdkWo+Gekvr+0dVZfI7zI260TV8XoORYxcNhYBD9L0CnS H0pOuggkxXQGg== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dHZks02h9z4wHJ; Fri, 28 Nov 2025 12:01:57 +1100 (AEDT) Date: Fri, 28 Nov 2025 11:54:38 +1100 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH v2 6/6] test: Add multiqueue support to vhost-user test infrastructure Message-ID: References: <20251121165902.1014964-1-lvivier@redhat.com> <20251121165902.1014964-7-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cI26KgczhjUMbiBc" Content-Disposition: inline In-Reply-To: Message-ID-Hash: GUI4TMWCRQWHZ2NJ6OZFBELIZPEGJDKP X-Message-ID-Hash: GUI4TMWCRQWHZ2NJ6OZFBELIZPEGJDKP X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --cI26KgczhjUMbiBc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 27, 2025 at 10:20:37AM +0100, Laurent Vivier wrote: > On 11/26/25 04:45, David Gibson wrote: > > > + > > > + if [ ${VHOST_USER_MQ} -gt 1 ]; then > > > + __qemu_netdev=3D"${__qemu_netdev} \ > > > + -device virtio-net,netdev=3Dv,mq=3Dtrue \ > > > + -netdev vhost-user,id=3Dv,chardev=3Dc,queues=3D${VHOST_USER_MQ}" > > > + else > > > + __qemu_netdev=3D"${__qemu_netdev} \ > > > + -device virtio-net,netdev=3Dv \ > > > + -netdev vhost-user,id=3Dv,chardev=3Dc" > > Is there a diffence for qemu between omitting queues=3D and using > > queues=3D1? If not we can simplify this. For the passt option it's > > worth explicitly not-setting it for the single-queue case, so that > > we're exercising the command line option as well. But exercising > > qemu's options is not our concern, so we can use queues=3D1 if it means > > the same thing as omitting it entirely. >=20 > I think the important parameter here is mq=3Dtrue that will set or not the > feature. This exercise the interface between QEMU and passt. Ah, good point, I missed that. > I will try to > see if we can set queues unconditionally (with 1 or more). >=20 > Thanks, > Laurent >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --cI26KgczhjUMbiBc Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmko8s0ACgkQzQJF27ox 2GdkQxAAiz6evIK7pQektjoXTw6YzQErdQltsEKOtNnmpiexBulxLLfivZVnmPVO uvArxw3d3hA+psg+zIFiMSbIHa+S7gEbwCXZQMfKRsolBUJcq45MPfG0uFbVDVzE cg7e/W2XLFEza2SEU5/HW9g7RmSUugn5o2xixwQ8G97iKyOeP38wAU+VdmWdhGhx W/88L2AW2ZJcD3bFM+E+rjkTPol/giG6ub9/mchrXCNOwe45eocUfMfEVmFTrFuf V4eV8yMPP/JdnG40qCMtBHWjbPUo4LNPhn9r6AwUOMPDKW35a3rUjcuTcUsGBgwF Na5Kt2/usskc4qdWOf3dLCBRCmSLkkpqanqD2MCiUyemQxlXSdAxOClykh21yiNa 9TnD0n34s34nFsNwqvI+GkyWBQvDN2QLuLdiloELJCLw1kKZGmigb8rIkpMMAN8A J0Awp9mbbtQjuW31ku3MnkwmK1Ryx7wJ2mj0XlT15pQJLOxAFIA+qG6A/E5BrRQQ fJ2AljLz5YsAybznGjE0TlruLM3aXSpvHZWTI9EKPAtUqWQb41N8xPkEEIVHHY+f B8H95jbPJjLgTvQkkkhg1hxSWh5OVd6cg3H/H3XUpgbl2cv3Rt17YM+IlCU1z1v0 L97/sFioQ4N/IrUWcFLq6aGD4oUp8JQsqDXLTa7wam3I5PwndIc= =w5Gt -----END PGP SIGNATURE----- --cI26KgczhjUMbiBc--