From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=ezA1QPov; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id CBBEC5A0271 for ; Mon, 08 Dec 2025 11:58:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1765191524; bh=Ykh34udkavo7ZyXrVIfgYA3tTo11urYB6486w3FrthI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ezA1QPovDwc8RhCZx7460TPgmb6Chftw8pWtGD+XyB6T4q9NyAnqJpr88yThXuoST OTw0xLGzKMTIzK391fqrdXzEdDygfJNgLBvHNdV02N3OdtwRp1R7boe55BlcJDpCnu 7bXk5oBHVWa6PF7f++nE8tZIimgjoBjW8y7vu0SDmZ5oDCrfWifteuki7t9wqBv1DG QkBGk6sfFQ+xjSxnCuwltFtO8xsanVZxCutG5FezDx+9R9bvyjhmTIV/zkelqY1xwV z8jBFeGQIVvxJCi20TDPHXjPI9tb/zLlzmp+blgjJFYRqcFVd96KfWTArlCvGgzXJp 7it3Fuai4s93w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dPzVr3rWwz4wCk; Mon, 08 Dec 2025 21:58:44 +1100 (AEDT) Date: Mon, 8 Dec 2025 19:28:46 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v2 3/9] tcp: Adaptive interval based on RTT for socket-side acknowledgement checks Message-ID: References: <20251208002229.391162-1-sbrivio@redhat.com> <20251208002229.391162-4-sbrivio@redhat.com> <20251208082212.5d2abb50@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MmKrXGhyAuzVJU09" Content-Disposition: inline In-Reply-To: <20251208082212.5d2abb50@elisabeth> Message-ID-Hash: NJNEC22HI3SUXDV4EOKQRYH7ULWBUIMS X-Message-ID-Hash: NJNEC22HI3SUXDV4EOKQRYH7ULWBUIMS X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Max Chernoff X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MmKrXGhyAuzVJU09 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 08, 2025 at 08:22:12AM +0100, Stefano Brivio wrote: > On Mon, 8 Dec 2025 16:41:21 +1100 > David Gibson wrote: >=20 > > On Mon, Dec 08, 2025 at 01:22:11AM +0100, Stefano Brivio wrote: [snip] > > > - flow_dbg(conn, "timer expires in %llu.%03llus", > > > - (unsigned long long)it.it_value.tv_sec, > > > - (unsigned long long)it.it_value.tv_nsec / 1000 / 1000); > > > + if (conn->flags & ACK_TO_TAP_DUE) { > > > + flow_trace(conn, "timer expires in %lu.%01llums", > > > + (unsigned long)it.it_value.tv_nsec / 1000 / 1000, > > > + (unsigned long long)it.it_value.tv_nsec / 1000); =20 > >=20 > > This doesn't look right - you need a % to exclude the whole > > milliseconds here for the fractional part. >=20 > Ah, oops, right, and on top of that this can be more than one second > but I forgot to add it. Fixed in v3. >=20 > > Plus, it looks like this > > is trying to compute microseconds, which would be 3 digits after the > > . in ms, but the format string accomodates only one. >=20 > That was intended, I wanted to show only the first digit of > microseconds given that the smallest values are hundreds of > microseconds, but changed anyway given the possible confusion. One digit is fine, but then you need tv_nsec / 100000, rather than nsec / 1000. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MmKrXGhyAuzVJU09 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmk2jD0ACgkQzQJF27ox 2GdKZBAAo6mSo6onWhuffAuvaCHMDHJ8INtlVLje29sTkqPYdBJdbpDLxujeCnzw TpVH0xalFugYs7sEC8xmln1wDq9E3eRKCIAVAgJ3tJqLW2TK72ec3Fvv3FluBgkE 5w8ilAwSV4VYXzI+/pdTmjVepx/n/e0XndCEATjj5l1mGdJ+MHQ/bG35GPRbMdAv FmrlvoCDe2KZ827tYUyHVym0z2nPlDU38BBYhu7Bj2UyQkA146z7dvgrY6J4gRph It76pfwAcNx37Tf48sGWmPR/sj6smILgRhdu0P125rLcsO83Kucpx+AZKxGx80G3 jv1HfTBe5raSx7Gu9rkrBvTIQl3unk39jaTQ0g3upVs4MRvMaRVFsvcLbjkdLRGn IuVcMYVgQcbPMclWs8NOYlXHOuxkl5aQ/ylEXoD/cBQ3Fpzbx6Kbr12gc1zNKc4o zm6H0Qd1MHSwEcx66I7m/UKnr6LtVEDwuSaEcSE2kcXVv3Avm/g0KZwZSLTzkjlk oo8BSJBLkpQ53FhvVyoWb5U9bWhg1IQ08iJmtGN0hOoBzZo+wH+jghl07yE1jsOW Lahv1QQ9Ma61N7do4FkUvc+iMz5Vr0FLLaaKMX+TocZIeSV8Z4wYGG/NhiBRU0e/ AZU2e5liCu+oIrK3AQYTu9cWcfAebFp9Fc47rPVamDZCgsgnzOo= =IGdE -----END PGP SIGNATURE----- --MmKrXGhyAuzVJU09--