From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=lkuRNJ0x; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id D22395A0271 for ; Tue, 09 Dec 2025 00:42:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1765237318; bh=cy58lmKlnxqs7HpEGEArv6MZoxbo+CIHMbAcp+qyL8E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lkuRNJ0xxMRtFCWZMSy4KpKpsbWaYB5lngf24MAq+tVjrL/2iyQxAH4gZZob42vEV OBpwY4AyUC3wYUlGitVL031JF9qWMef5a7aJaFqUgqJx1tm5MAthD11Oadu5p7JsMW JEQGtAHqvg+8eh8pGHHStjtSh+LyjP8Q/AjLdwEn/iYrRBHKYFRDx0gCX1ASjNXOIh FoV7P8s8l7/sCxW2x+MBKVDhw5sEoz4TiaKz4m2tDYlmiVy5iphITp83VHgtINLOID d3VDaRjfNAXCYB4twyqqzI4L3EYIvaFmuvSUiHjNvIDyKSN3HuM9juZRo0gsB2KIvp rruDsQItrpK5Q== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dQJRV6FGcz4wMS; Tue, 09 Dec 2025 10:41:58 +1100 (AEDT) Date: Tue, 9 Dec 2025 10:36:01 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] flow: Set EPOLLFD_ID_DEFAULT on newly allocated flows, not EPOLLFD_ID_INVALID Message-ID: References: <20251208212822.2721774-1-sbrivio@redhat.com> <20251208225400.6a054d22@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JuG79D/gfNHUkCW2" Content-Disposition: inline In-Reply-To: <20251208225400.6a054d22@elisabeth> Message-ID-Hash: XSDW54UDBSKFVP3VRUPOU2B34MLIP5RQ X-Message-ID-Hash: XSDW54UDBSKFVP3VRUPOU2B34MLIP5RQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Laurent Vivier X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --JuG79D/gfNHUkCW2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 08, 2025 at 10:54:00PM +0100, Stefano Brivio wrote: > On Mon, 8 Dec 2025 22:28:22 +0100 > Stefano Brivio wrote: >=20 > > We're somehow hitting: > >=20 > > ASSERTION FAILED in flow_epollfd (flow.c:362): f->epollid < ((1 << 8)= - 1) > >=20 > > on an inbound spliced connection, with a single forwarded port, an > > HTTP server in a Podman container, and a GET request. Reproducer at > > https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#comment-= 4473411 > >=20 > > printf 'FROM registry.fedoraproject.org/fedora:latest\nRUN /usr/bin/d= nf install -y httpd\nEXPOSE 80\nCMD ["-D", "FOREGROUND"]\nENTRYPOINT ["/usr= /sbin/httpd"]\n' > Containerfile > > podman build -t fedora-httpd $(pwd) > > podman run -d -p 8080:80 localhost/fedora-httpd > >=20 > > curl http://localhost:8080 > >=20 > > I guess we don't set EPOLLFD_ID_DEFAULT early enough on inbound spliced > > sockets for some reason and we get a socket event while we still have > > EPOLLFD_ID_INVALID set. > >=20 > > As we're not really using epoll identifiers yet, set > > EPOLLFD_ID_DEFAULT right away on newly allocated flows, while we > > figure this out. > >=20 > > Link: https://bodhi.fedoraproject.org/updates/FEDORA-2025-93b4eb64c3#co= mment-4473411 > > Signed-off-by: Stefano Brivio > > --- > > I just merged this, posting for awareness / review. >=20 > Ah, never mind, this makes it worse somehow: >=20 > 5.6384: Flow 0 (TCP connection (spliced)): SPLICE_CONNECT > 5.6384: Flow 0 (TCP connection (spliced)): ERROR on epoll_ctl(): No such = file or directory Does this imply you managed to reproduce locally? You hadn't as of your comment a few after the one linked. I also haven't managed to reproduce this. > ...still looking for a workaround / fix. >=20 > --=20 > Stefano >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --JuG79D/gfNHUkCW2 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmk3YNQACgkQzQJF27ox 2GcxGA//RW1mD2yLuN+KK0qL+oKmjzcTgqrg1JHB66svOxCoFzBbzjR8/iIxmH6O xSA21NzeN87MJoqofx7JSMBqeqPdwnkZ0jd0gZjvSEmm2dVCMwXrVWLQcpMJ3/wR 8wEkwrC9+rs4OO4MPeVulBQZksRy6OR3OA0efFMDqakXrdGxx1xefYJOD0cC3DVw LewHiky8GK1s2iFzkzHnubw4vQ4uOXS8PKVs4WsCwI5dEBjgf6BSJt21Q6E7h+lE WM/1IJUiXC3z2GNsmD4hV+lq96csIt+fG/Ch8FVOHEazQ7GWc5jF8wcvNVqlDWyA dEvNF5oa/cW6LvQ7xv+uun60vOSvNaApxew9JhAGZEqPTHog6rovG1+1fdgKHN+o w8KvsrLqsglCe/brnojcG5Ek+ug+zv16cbFYqfH+sQdCEIGKocy+AI4ZqhGZQS3C mUoP1QHt8sRM1Rg/fGTSiXbx4eaqmTddGyXvlWYg47CioRNxLWwVoyaG29qENueR wtrE0JHazNojZeDLIyesn04NBYx+ifKa1pzTvJDGX12QhzmtMw+C7yhKP3tB7Epw /EHCoadUqDV61vLdjsvvJQ+/WI6gAP54OAiVC0yBX6Q8rxe8wQu52Jn3Th9xgpXQ qPubZzN2/BwnvCp3lw30b0euqUbFbRZQ8kodShfAg11deqZ6GNc= =mVrL -----END PGP SIGNATURE----- --JuG79D/gfNHUkCW2--