From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=QlKXVy/0; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 2E2135A065B for ; Tue, 16 Dec 2025 04:21:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1765855288; bh=RfGJxMEd1UB+wMDq2ghRZCLHvqXmRStls3AjxMBY5lA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QlKXVy/0eWUBcfVeuCxwtonER3FcDxlmnaYZJXgYPh7Oj+nMsMmmn9BZF0uhVt6mV JfTsGg3E05xZJGWx+zlQjLpu3xEJJgp8iGBcNj4GmnL7cMdhWaNO30aQktcD13C0ug X9sXYFpEaqaEBrg/irt6qfYcQMhwmgMvOHWCNnF42ZQ3Hw/mr023baMzMe51E5CPYe 3TX5334HgN5IP3gnqM0BRosdbNNGs6EGnMRXE911RBsPF3FXUAXuPzILtnTs4ui6Zv lgr442eaKDiDyYDxxGnKvWZ28vh9NHBChuKLXxoBGaPncYfuPJ3Lkh5jshdSM71HjB yImaKF8oL4CBA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4dVhzX6J97z4wHf; Tue, 16 Dec 2025 14:21:28 +1100 (AEDT) Date: Tue, 16 Dec 2025 14:14:54 +1100 From: David Gibson To: Jon Maloy Subject: Re: [RFC 01/12] ip: Introduce multi-address data structures for IPv4 and IPv6 Message-ID: References: <20251215015441.887736-1-jmaloy@redhat.com> <20251215015441.887736-2-jmaloy@redhat.com> <4dd738bc-b5fa-4fee-81a1-e4cd74f15f69@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="AAP/rryKf6/wYm4M" Content-Disposition: inline In-Reply-To: <4dd738bc-b5fa-4fee-81a1-e4cd74f15f69@redhat.com> Message-ID-Hash: QUZHTBHRQA2JUHRFTO55CWLJT5AYYQ7B X-Message-ID-Hash: QUZHTBHRQA2JUHRFTO55CWLJT5AYYQ7B X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --AAP/rryKf6/wYm4M Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 15, 2025 at 08:58:32PM -0500, Jon Maloy wrote: >=20 >=20 > On 2025-12-15 17:05, Jon Maloy wrote: > >=20 > >=20 > > On 2025-12-15 04:40, David Gibson wrote: > [...] > > > > +struct ip4_addr_entry { > > > > +=A0=A0=A0 struct in_addr addr; > > > > +=A0=A0=A0 int prefix_len; > > > > +=A0=A0=A0 int permanent; > > >=20 > > > Might as well make these uint8_t and bool, respectively.=A0 There will > > > be some padding, but the overall structure will still be smaller. > > >=20 > > > Or, it might be worth considering replacing 'permanent' with a flags > > > mask, in case we have future uses for it. > >=20 > > Agree with that. I'll make that change, and if we ver need more we can > > replace the boolean with a bitmask. Yes, that's what I was implying. I think we will want some additional flags to indicate the origin of the address (command line, scraped =66rom host, observed from guest). > Provided we agree on keeping guest side subscriptions, we could mark > the address entries "guest_side" and "host_side", hence giving only > the owning side the right to remove/alter the entry. I don't think that quite makes sense as is. These are all guest side addresses. The main distinction is between addresses we're *telling* the guest to use (currently 'addr') and guests we've observed the guest to use (currently 'addr_seen'). Usually, those should have a 100% overlap, but we need to be clear on what the policy is when they don't. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --AAP/rryKf6/wYm4M Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmlAzp4ACgkQzQJF27ox 2Gcd3w/9HU4ibIKQO8F9Z/uncVQ9RBdAIuV9QHyWXRKqjUuMFoPUNjRsz/glO26f jUZKlIObr/6IxbX/xpxlpcN4vUten+hG/K1JULZC99oiTcWh3JwtIApuxdkqmZTH O6cGEIaA3QtD7bCAyhEljRq1E0NbPMuERBSZ927c01b86mvZYc0sFUML6X9tblw9 SmWiXqDqYhrfOmX6ayPaab6CEjPA0VHnW5kHCEVAwsNgb/V836Og7Qfcxkld7g1p peOMyMCOItzF4b+mbRPczyFcIW1Rcrnw63GBwzUTmb/DrXuq0KM9eM0otmMlsjRe iigesNyyRhxmteN4L9/VU2980q9aeviYPzKRQ4cEljLYEWBR/Yt1/KjINxgLGCVk VP7E6tV1/Wzjj1xMiwyK0RKXU4/CEeuSoyHqOmQxdThxM8YUzEHX0Zji7WECrwSl SnRCWj7XGKEyF32U9lXD8H3y/07UorlW4ducFGXs5B42jwEHJ/L07XYLP1cIx6Em 6KTo1fakHGRLq05Qm7/QuxBNcDDHDVgZZAt5wUKZeDUFQoYD6z6bPJxB7lln3YKU 2vseMF3HRpgQOrgG6XcPhHKUY310yiW3/eFQ+KMSbp0wZ0cKSc+GTmTRM2agtutf Vgs8Wj6zpPn3IOmuOzJ3t6hWMvQbg9Hp0XCerU67DTfXzYd32yc= =Ltmo -----END PGP SIGNATURE----- --AAP/rryKf6/wYm4M--