From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=dum9meth; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 69F1E5A004E for ; Wed, 14 Jan 2026 01:42:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1768351319; bh=uwA/vRh8Os9eknjwTOkls7dQS4nt5Php8tbgmRhmUUc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dum9meth8k1qV7MqmSVjxz1u/qp4OoXmhoYVHIZzdcmOi11KkTD04R8H0MxswkbJb YLdsgP/rWz6jm7xXLnKJkU44A9vWIwizG+/losDWH9VDP+B0mEr/kbQlWW7wCaH8Ek R6aLIBXAsJdcv/KG+Dm1TOJLOLh0YWJgO29Hld08ms4V2YMJhrMvp9xHqcWAhrzfsL rxaUPB9HvjSoCO6fwidLBKt3L1TzYLeJ9YuSArNhZLxTayqDU6uynXzIWLY5g1Wa18 zK5wattKJT2fI4a2SoDBrgmwIJS6FcWgo5Ko3yyzj/TODMJLwLmNfAjS58t66Mt7zM iAKv57f3hFoMw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4drS472dVSz4wRD; Wed, 14 Jan 2026 11:41:59 +1100 (AEDT) Date: Wed, 14 Jan 2026 10:53:01 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH v3 02/14] conf, fwd: Keep a table of our port forwarding configuration Message-ID: References: <20260108022948.2657573-1-david@gibson.dropbear.id.au> <20260108022948.2657573-3-david@gibson.dropbear.id.au> <20260113002610.5168fd6a@elisabeth> <20260113231326.6bc2ecf2@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QchgvEgEUVXa8kf9" Content-Disposition: inline In-Reply-To: <20260113231326.6bc2ecf2@elisabeth> Message-ID-Hash: KZIDT5TSDU4XY4LXODZTT5VHY6HJPC55 X-Message-ID-Hash: KZIDT5TSDU4XY4LXODZTT5VHY6HJPC55 X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --QchgvEgEUVXa8kf9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 13, 2026 at 11:13:26PM +0100, Stefano Brivio wrote: > On Tue, 13 Jan 2026 16:12:02 +1100 > David Gibson wrote: >=20 > > On Tue, Jan 13, 2026 at 12:26:10AM +0100, Stefano Brivio wrote: > > > > > > On Thu, 8 Jan 2026 13:29:36 +1100 > > > David Gibson wrote: > > > =20 > > > > +/** > > > > + * fwd_rules_print() - Print forwarding rules for debugging > > > > + * @fwd: Table to print > > > > + */ > > > > +void fwd_rules_print(const struct fwd_ports *fwd) > > > > +{ > > > > + unsigned i; > > > > + > > > > + for (i =3D 0; i < fwd->count; i++) { > > > > + const struct fwd_rule *rule =3D &fwd->rules[i]; > > > > + const char *weak =3D rule->flags & FWD_WEAK ? " WEAK" : ""; =20 > > >=20 > > > Should we print " might fail" or " can fail" instead of " WEAK"? This > > > is for users. =20 > >=20 > > Good point. THough I'm not sure "might fail" or "can fail" is > > terribly clear in context either. I've gone with " (best effort)" for > > now. >=20 > Or maybe " (if available)"? I feel like that's also kind of vague. Available where, exactly? > I always find "best effort" a bit ambiguous > because, well, it's a pretty good effort, being it's the best one, but > it actually means we'll just give it a quick try, I'm thinking of it as "best effort" for the rule as a whole: we attempt it for every component port. > once. That's no longer true after 7/14: we'll call fwd_listen_sync() every second from fwd_scan_ports_timer(). That's intended for the FWD_SCAN rules, but it also means we'll re-attempt listens for any FWD_WEAK ports we previously failed on. > No strong preference though, "best effort" is rather idiomatic anyway. I'll keep it as-is for now, but I'm open to different wordings if a clearly better one occurs to one of us. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --QchgvEgEUVXa8kf9 Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmlm2s8ACgkQzQJF27ox 2GeyJA/9G8L3fZh3ZaSauNNH/y+FTvaeWdXI37tns92+A4xiLynKco6pyFv+0MYt BGp2c2puKwBUPCuI23VFCnuU31BX1HhscYTKIypnO0vlRcJ6yS2R9Yb0lpH3xpY5 fbkW3vfgishH2GuB7Y7MAMXMHqyk8fDgoIy/UjLnsjP39wfyqIJo2aZZf/RSdB8X 59a6uV6Nqec/gsH/9zx6avrdrqXxSaZCeBEI3jD9c5BAUnRyOgUtYD6u7nCTa41m nWf033kTwzCFxzSeqd/HFGWUrtX8D3Ty2kXDbdREIjzqmRjMaEKtpgAlVTdp/oCA 7Y8fd288EGn2oe3ho6kZCSCOk4bQ7d+NCez1b5J1A1JOOtuAeXnsmo3Y2Oh6E1v0 AsQvLe2L/mbAwV71RZlUYupxOY/uguj1S6YiG+G2XjeD8GXvTBvWCXC/9fj1PXll rvwXdBj7Li2ZqVnfZdfBV/88mYaXKv+bDIdcI8TaVLcdNGPV/ukQjaUZidZPshUh sdIrkEo/Xj2oFlK5plPpKaxYhn5FKZ1Qmr7O5IDx5v+9I7SUu2HA9xLYVPThayRj enAmuU7SJHW+N9TgjU23zpMlXKHEBGDtpMSpJMpD6UYMN2kWAYa/kr7ckyuCH/17 NbBjUwvEHnl4fETkMUeX2fXKiMcPAIr/tt4HSwcwx5i0rwaG4UU= =bZzh -----END PGP SIGNATURE----- --QchgvEgEUVXa8kf9--