From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=PVL178jM; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 8BB1B5A004E for ; Wed, 14 Jan 2026 02:18:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1768353516; bh=djU0Xmsd4HVhFZZkWrjN4lTnpTh0+wzIUM01aFyLTpM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PVL178jMWJ1JLGFat28WIqh/Jm9YwoULkF+U6Ayh+CY3LB3niFVt3E0Wv1Pyrb6T5 xVtY1XfH9YZD6+xmd3h7wGnINcF/lW1OpQKGBLV7Cx1l9E2Hl7W/UbY6+pG9QwAfCb AkxFn04Vxg8Jx4qEguT6k88VDZK6dJ7RlmREYkqtSlUVcTcnnpOwgCb1lY2jaCC1bA +lf2asslnFOV4IbsOLdo10y4FXVwOpb1/hb+2RulhRBelHRhejzvgePo+Xj1OuQDoC DzlvaBdUxy3lKG9OeIpC9WNzvfbXcgb/YDjhDaUupcaJwFOB+pCw8a0UjOv2imNniL PiMJezVxd9FWQ== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4drStN15yNz4wRG; Wed, 14 Jan 2026 12:18:36 +1100 (AEDT) Date: Wed, 14 Jan 2026 12:11:43 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH 3/3] igmp: Remove apparently unneeded suppression Message-ID: References: <20260113035415.685242-1-david@gibson.dropbear.id.au> <20260113035415.685242-4-david@gibson.dropbear.id.au> <20260114003503.412fc9d1@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VSAa3M4bN5axrvEB" Content-Disposition: inline In-Reply-To: <20260114003503.412fc9d1@elisabeth> Message-ID-Hash: E2CEVIDJM6MAEUNZHUQ6YB3VG2JCYV2N X-Message-ID-Hash: E2CEVIDJM6MAEUNZHUQ6YB3VG2JCYV2N X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --VSAa3M4bN5axrvEB Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 14, 2026 at 12:35:03AM +0100, Stefano Brivio wrote: > On Tue, 13 Jan 2026 14:54:15 +1100 > David Gibson wrote: >=20 > > cppcheck-2.19.1 complains that the unusedFunction suppression in igmp.c > > doesn't match. That seems like a cppcheck bug, because the function > > clearly *is* unused. The function exists because otherwise the compiler > > fails because "ISO C forbids an empty translation unit". > >=20 > > mld.c contains an identical unused definition for the same reason, but > > without the suppression. It doesn't seem to have caused unusedFunction > > warnings, so maybe cppcheck counts the non-empty translation unit > > requirement as a "use" of the function? >=20 > No idea why, but with this patch and cppcheck 2.16.0 I'm getting: >=20 > igmp.c:16:0: style: The function 'unused' is never used. [unusedFunction] > __attribute__((__unused__)) static void unused(void) { } > ^ >=20 > ...I guess we needed one and exactly one suppression between mld.c and > igmp.c, even though it's two different translation units. Huh. Weird. > Anyway, whatever, it's too old to make sense. Upgraded to 2.19.0, no > error there, I guess it should be good enough for everybody. Works for me. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --VSAa3M4bN5axrvEB Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmlm7U4ACgkQzQJF27ox 2Gee+A/8CQIEuZuhd+QKHSi20RdTqz56CSQxGJ5nVT6w2G2/EAvTRyKPWwlusskV cKPiE7QxSMspMUWmlROKnwhvZkWBRHNebIvK792G5baMbQF/u5r2CTOCYSvfog6p a44T8ZgGpeAiv7633Fe/NdhXdQLdii394l8OR4ifF3u4nibtS5bnji0aUk+sf1nc wAM0oy9IQMllfcsgAKdCWsmSndmlXo+IPA4zmlxvXH7bK8lTMaavbTLLfGFOnmtW HXvApDyMehmv7tgjnOAi1QIPeWPm28I9zIFBWQsa87+RR3yI3BdkeOiJFQtaN7Cz FCGrqsfZbalGsmg87GncUUGA7Z0RqXdOzeaV7sRs6cjKr4UEVeTW2kiwtAtXyU2p xiUiJi2Ais5DODHVt6kIOPKN+iI6NM9Ty+j+mgLnEMyYB7WRjJ+tnsw+4Bm92W3F OvaaHVDFiloI34BvhUmUfsVU9M9Km8bTq2k+hiWkaPm3f4xLG8Qb/pQlQPteq+vR XEmyMk8b/GuOeinLYIYLpNL29GNc5/Wpke8WDh3JSgr6VcVS/LhN++oByJGx7Gma ZbQJ7MFEPr0YUS1FNcLEEzceNy/WvrFwzHJYxFZdyi7PiX+FcumuqtbIKH0Sx24A s3hwuDkrrmpFYdC4C5TAzTUTlLBAxpRarSoIFhX2pDtKVd0pPjo= =As+K -----END PGP SIGNATURE----- --VSAa3M4bN5axrvEB--