From: David Gibson <david@gibson.dropbear.id.au>
To: Laurent Vivier <lvivier@redhat.com>
Cc: passt-dev@passt.top
Subject: Re: [PATCH] virtio: Remove duplicate VIRTQUEUE_MAX_SIZE definition
Date: Wed, 4 Feb 2026 22:20:04 +1000 [thread overview]
Message-ID: <aYM5dMk99st7X7bA@zatzit> (raw)
In-Reply-To: <20260204120847.1311589-1-lvivier@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 944 bytes --]
On Wed, Feb 04, 2026 at 01:08:47PM +0100, Laurent Vivier wrote:
> VIRTQUEUE_MAX_SIZE is already defined in virtio.h, which virtio.c
> includes. Remove the redundant local definition.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> virtio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/virtio.c b/virtio.c
> index 447137ee83dd..7e31e799f881 100644
> --- a/virtio.c
> +++ b/virtio.c
> @@ -83,8 +83,6 @@
> #include "virtio.h"
> #include "vhost_user.h"
>
> -#define VIRTQUEUE_MAX_SIZE 1024
> -
> /**
> * vu_gpa_to_va() - Translate guest physical address to our virtual address.
> * @dev: Vhost-user device
> --
> 2.52.0
>
--
David Gibson (he or they) | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you, not the other way
| around.
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-02-04 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 12:08 Laurent Vivier
2026-02-04 12:20 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYM5dMk99st7X7bA@zatzit \
--to=david@gibson.dropbear.id.au \
--cc=lvivier@redhat.com \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).