From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=Lq23uJVF; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 80A795A0652 for ; Wed, 04 Feb 2026 13:21:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1770207712; bh=uX85c4OkPh/7RWT01HHohBMookCwsGQSyJ7myb1yUhY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lq23uJVF1cVV5iqNXEGTyLpTForFpaHIteM4w80RSE9uXo7Yu1BHsYuJKgHACh/KQ XeI5aSwLyFCZW007eTkERMSEcwWC9xQiuuOshq9kXS+2XSr3rTPBEcecApcdK3tKLi s224f96S1MtRznOrmBiNWzwPzYcA2P382YTtnmEPdTaI1FKXydAUUEggTxU1h0mjvc W6X6acYghP+l8oAF35pCZ58tbw2z0gNYx8+nBgQnOUztT20YknY7MrfFlwV1mLNJSa lAmzvUv9WCzlc9Mnb3C0Q/HUyfujAE2+g8aPtwvIkkctFGkBVS1Ou7Cy4exCDZ8kdm 689bsS1ouVWEA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4f5fc000MRz4w2R; Wed, 04 Feb 2026 23:21:51 +1100 (AEDT) Date: Wed, 4 Feb 2026 22:20:04 +1000 From: David Gibson To: Laurent Vivier Subject: Re: [PATCH] virtio: Remove duplicate VIRTQUEUE_MAX_SIZE definition Message-ID: References: <20260204120847.1311589-1-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tgaL5EDxvSgMTGpk" Content-Disposition: inline In-Reply-To: <20260204120847.1311589-1-lvivier@redhat.com> Message-ID-Hash: VLOGDCRKZZHPTXFJABCKQVHDZYJ4SIYQ X-Message-ID-Hash: VLOGDCRKZZHPTXFJABCKQVHDZYJ4SIYQ X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --tgaL5EDxvSgMTGpk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 04, 2026 at 01:08:47PM +0100, Laurent Vivier wrote: > VIRTQUEUE_MAX_SIZE is already defined in virtio.h, which virtio.c > includes. Remove the redundant local definition. >=20 > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > virtio.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/virtio.c b/virtio.c > index 447137ee83dd..7e31e799f881 100644 > --- a/virtio.c > +++ b/virtio.c > @@ -83,8 +83,6 @@ > #include "virtio.h" > #include "vhost_user.h" > =20 > -#define VIRTQUEUE_MAX_SIZE 1024 > - > /** > * vu_gpa_to_va() - Translate guest physical address to our virtual addr= ess. > * @dev: Vhost-user device > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --tgaL5EDxvSgMTGpk Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmDOWcACgkQzQJF27ox 2Ge1Ww/8CtgPw03Se7Am5TeVgklRUjdCM7R17nXT9x92ZkcYwN7o3NICZYL712vV W9jmgz99xuB/1ujS1emLSQZqvs2Iw+kChuXnuQpY2HIMpHkOW13h3X7EVN0who6O 0vAxFG8KZ1+FUtpZ9cEkZlWQ7u0AXMvFLoWOV2u8NZC8Mucw91w+FrI7ah3Q57HG 92is9y3CKFfi64gN7MUE/Xc/L6FycwE3AHNk2dxxhuBxvhji6vnplSyABrI17psG 3ZU8Edre3lulE9xImyAsk/y5A3KjJOpKmOIhGBXAyVo5ngcdBa5LIGO6g3mZex9s BsCS41URrKVcLXqfXZnA5eACZkgnC2UAoTttmInb/jX8WoOMAQUVcyzUVNLmzguk LWyyAuxdWd4tXZQ9g60N5SJ0rdk2NgphKA3ygD2suon5ex31XofyS+dSz452Q92k O1+DEabhowDj+2ZE7QnRhmEXSefVHtft0Egtcm5otp4b/3skTatq/e0/x2H3BuHP +y2GHFTHfgKFJxUGs/4wcmjEv0PkaxLZWwOAqaiouFe9LWAvP/psOAfXn5Pgaahj +/aceTt/INkQlKWDdimGB4k6DFB+7LN+Ik8fdc/wBertFXD43hRtxBPp6ZclnxKm XCWkBRmMOnwAkku4l2a0GuG4QgL2tUJO/xFPd/UmrZNnXxZ7GaQ= =Xygt -----END PGP SIGNATURE----- --tgaL5EDxvSgMTGpk--