From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=PCwFSa4t; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id E86335A0652 for ; Wed, 04 Feb 2026 13:51:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1770209461; bh=n7DYqrEDcrUFJMR5hKUnA1AVQ+A1J1boBVat031CtMk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PCwFSa4td08RhvUn/b9x+3gSV7/doz1nkHaar8XpibrR0igIBFW2aR7hrdQvxP14/ lk+JATyiiJEnjBOsEoRUI4WXK0y8O/DaRtOp2NPOePMHqUMQjD/6ZlOvm3UKlFMwNC CUMxWnGt/f61WYIc6+OBJnZp9DwGf1Fo3+JX8lvDmsQM1yL1jRKsXnI9ohGVqY0sqq dgBlGh3NgZdOK41bEIKwog2LUWXTNVPkc0x7J+YP3O2sET0SPCrv7gAszmlcYJEBu5 ELVWrT4rIF9G1EiJkOM7yNF4lpqr5PpyffekeZ1M2nHIGu6rGRWUb24MDWvZTHYdN0 mdpRScmtVO53w== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4f5gFd188lz4wDP; Wed, 04 Feb 2026 23:51:01 +1100 (AEDT) Date: Wed, 4 Feb 2026 22:50:52 +1000 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v3 01/11] conf: Support CIDR notation for -a/--address option Message-ID: References: <20260130214447.2540791-1-jmaloy@redhat.com> <20260130214447.2540791-2-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Jp7xtS6b8wrubIVQ" Content-Disposition: inline In-Reply-To: <20260130214447.2540791-2-jmaloy@redhat.com> Message-ID-Hash: OYH3XIPHOTFIPPVHHJY7PH4RRAITSNPT X-Message-ID-Hash: OYH3XIPHOTFIPPVHHJY7PH4RRAITSNPT X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --Jp7xtS6b8wrubIVQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2026 at 04:44:37PM -0500, Jon Maloy wrote: > Extend the -a/--address option to accept addresses in CIDR notation > (e.g., 192.168.1.1/24 or 2001:db8::1/64) as an alternative to using > separate -a and -n options. >=20 > We add a new inany_prefix_pton() helper function that: > - Parses address strings with optional /prefix_len suffix > - Validates prefix length based on address family (0-32 for IPv4, > 0-128 for IPv6), including handling of IPv4-to-IPv6 mapping case. > - Returns identified address family, if any. >=20 > For IPv4, the prefix length is stored in ip4.prefix_len when provided. > Mixing -n and CIDR notation results in an error to catch likely user > mistakes. >=20 > Also fix a bug in conf_ip4_prefix() that was incorrectly using the > global 'optarg' instead of its 'arg' parameter. >=20 > Signed-off-by: Jon Maloy >=20 > --- > v3: Fixes after feedback from Laurent, David and Stefano > Notably, updated man page for the -a option >=20 > v4: Fixes based on feedback from David G: > - Handling prefix length adjustment when IPv4-to-IPv6 mapping > - Removed redundant !IN6_IS_ADDR_V4MAPPED(&addr.a6) test > - Simplified tests of acceptable address types > - Merged documentation and code commits > - Some documentation text clarifications >=20 > v5: - Moved address/prefix parsing into a refactored > inany_prefix_pton() function. > - inany_prefix_pton() now only caluclates IPv6 style > prefix lengths > - Stricter distinction between error causes. > - Some refactoring of the 'case a:' branch in conf() > - Some small fixes in passt.1 > --- > conf.c | 58 +++++++++++++++++++++++++++++------------------- > inany.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > inany.h | 1 + > ip.c | 21 ++++++++++++++++++ > ip.h | 2 ++ > passt.1 | 17 ++++++++++----- > 6 files changed, 139 insertions(+), 28 deletions(-) >=20 > diff --git a/conf.c b/conf.c > index 2942c8c..98d5d17 100644 > --- a/conf.c > +++ b/conf.c > @@ -682,7 +682,7 @@ static int conf_ip4_prefix(const char *arg) > return -1; > } else { > errno =3D 0; > - len =3D strtoul(optarg, NULL, 0); > + len =3D strtoul(arg, NULL, 0); > if (len > 32 || errno) > return -1; > } > @@ -896,7 +896,7 @@ static void usage(const char *name, FILE *f, int stat= us) > " a zero value disables assignment\n" > " default: 65520: maximum 802.3 MTU minus 802.3 header\n" > " length, rounded to 32 bits (IPv4 words)\n" > - " -a, --address ADDR Assign IPv4 or IPv6 address ADDR\n" > + " -a, --address ADDR Assign IPv4 or IPv6 address ADDR[/PREFIXLEN]\n" > " can be specified zero to two times (for IPv4 and IPv6)\n" > " default: use addresses from interface with default route\n" > " -n, --netmask MASK Assign IPv4 MASK, dot-decimal or bits\n" > @@ -1498,6 +1498,7 @@ void conf(struct ctx *c, int argc, char **argv) > const char *optstring =3D "+dqfel:hs:F:I:p:P:m:a:n:M:g:i:o:D:S:H:461t:u= :T:U:"; > const char *logname =3D (c->mode =3D=3D MODE_PASTA) ? "pasta" : "passt"; > char userns[PATH_MAX] =3D { 0 }, netns[PATH_MAX] =3D { 0 }; > + bool prefix_from_cidr =3D false, prefix_from_opt =3D false; > bool copy_addrs_opt =3D false, copy_routes_opt =3D false; > enum fwd_ports_mode fwd_default =3D FWD_NONE; > bool v4_only =3D false, v6_only =3D false; > @@ -1808,35 +1809,46 @@ void conf(struct ctx *c, int argc, char **argv) > c->mtu =3D mtu; > break; > } > - case 'a': > - if (inet_pton(AF_INET6, optarg, &c->ip6.addr) && > - !IN6_IS_ADDR_UNSPECIFIED(&c->ip6.addr) && > - !IN6_IS_ADDR_LOOPBACK(&c->ip6.addr) && > - !IN6_IS_ADDR_V4MAPPED(&c->ip6.addr) && > - !IN6_IS_ADDR_V4COMPAT(&c->ip6.addr) && > - !IN6_IS_ADDR_MULTICAST(&c->ip6.addr)) { > - if (c->mode =3D=3D MODE_PASTA) > - c->ip6.no_copy_addrs =3D true; > - break; > - } > - > - if (inet_pton(AF_INET, optarg, &c->ip4.addr) && > - !IN4_IS_ADDR_UNSPECIFIED(&c->ip4.addr) && > - !IN4_IS_ADDR_BROADCAST(&c->ip4.addr) && > - !IN4_IS_ADDR_LOOPBACK(&c->ip4.addr) && > - !IN4_IS_ADDR_MULTICAST(&c->ip4.addr)) { > + case 'a': { > + union inany_addr addr =3D { 0 }; You're unconditionally calling inany_prefix_pton(), so you shouldn't need to initialise this. > + int prefix_len =3D 0; Or this. > + int af; > + > + af =3D inany_prefix_pton(optarg, &addr, &prefix_len); You need to check for errors from inany_prefix_pton(). > + if (inany_is_unspecified(&addr) || > + inany_is_multicast(&addr) || > + inany_is_loopback(&addr) || > + IN6_IS_ADDR_V4COMPAT(&addr.a6)) > + die("Invalid address: %s", optarg); For sanity / extensibility, it probably also makes to fail here if af is not either AF_INET or AF_INET6. > + > + if (prefix_len && !prefix_from_opt) > + prefix_from_cidr =3D true; > + else if (prefix_len) > + die("Can't mix CIDR with -n"); > + > + if (af =3D=3D AF_INET) { > + c->ip4.addr =3D *inany_v4(&addr); > + c->ip4.prefix_len =3D prefix_len ? prefix_len - 96 : > + ip4_class_prefix_len(&c->ip4.addr); > if (c->mode =3D=3D MODE_PASTA) > c->ip4.no_copy_addrs =3D true; > - break; > + } else if (af =3D=3D AF_INET6) { > + c->ip6.addr =3D addr.a6; > + if (c->mode =3D=3D MODE_PASTA) > + c->ip6.no_copy_addrs =3D true; > + } else { > + die("Invalid prefix length: %d", prefix_len); This error message does not seem to match the conditions that trigger it. > } > - > - die("Invalid address: %s", optarg); > break; > + } > case 'n': > + if (prefix_from_cidr) > + die("Can't use both -n and CIDR prefix length"); > c->ip4.prefix_len =3D conf_ip4_prefix(optarg); > if (c->ip4.prefix_len < 0) > die("Invalid netmask: %s", optarg); > - > + prefix_from_opt =3D true; > break; > case 'M': > parse_mac(c->our_tap_mac, optarg); > diff --git a/inany.c b/inany.c > index 7680439..00d44e0 100644 > --- a/inany.c > +++ b/inany.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > =20 > #include "util.h" > #include "ip.h" > @@ -57,3 +58,70 @@ int inany_pton(const char *src, union inany_addr *dst) > =20 > return 0; > } > + > +/** inany_prefix_pton - Parse an IPv[46] address with prefix length adju= stment "adjustment" doesn't make sense to me here. > + * @src: IPv[46] address string > + * @dst: output buffer, filled with parsed address > + * @prefix_len: pointer to prefix length > + * > + * Return: AF_INET for IPv4, AF_INET6 for IPv6, -1 on error I'm not particularly convinced that returning the address family here is useful, since the caller can call inany_v4() just as easily as we can. But if we do return the address family, the it probably makes more sense to use AF_UNSPEC for errors, rather than -1, since it's not - strictly speaking - guaranteed that one of the AF_* constants has the value -1. > + */ > +int inany_prefix_pton(char *src, union inany_addr *dst, int *prefix_len) If we are returning an address family, the return type should be sa_family_= t. > +{ > + bool mapped =3D false; > + struct in6_addr a6; > + struct in_addr a4; > + char *slash; > + char *end; > + int af; > + > + *prefix_len =3D 0; As noted below, 0 is not a suitable value for "missing prefix", because 0 length prefixes are real and important. I think it would be better to make the prefix length non-optional for this functional. The caller can fall back to inany_pton() if this fails. That makes this function more easily reusable for cases where we _require_ a prefix length. > + > + /* Check for presence of /prefix_len suffix */ > + slash =3D strchr(src, '/'); > + if (slash) > + *slash =3D '\0'; > + > + /* Read address */ > + if (inet_pton(AF_INET, src, &a4)) { > + inany_from_af(dst, AF_INET, &a4); > + af =3D AF_INET; > + } else if (inet_pton(AF_INET6, src, &a6)) { > + inany_from_af(dst, AF_INET6, &a6); > + af =3D AF_INET6; > + if (inany_v4(dst)) > + mapped =3D true; > + } else { > + memset(dst, 0, sizeof(*dst)); > + return -1; > + } > + > + if (!slash) > + return mapped ? AF_INET : af; You can avoid messing around with the mapped temporary by unconditionally deriving the address family from inany_v4(). > + > + /* Read prefix_len - /0 is not allowed */ /0 should be allowed. It doesn't make much sense for -a, but it's valid and important if we use this in future for routes (a 0 length prefix indicates a default route). > + errno =3D 0; > + *prefix_len =3D strtoul(slash + 1, &end, 10); > + if (errno || *end || *prefix_len =3D=3D 0) > + return -1; > + > + if (mapped) { > + /* IPv4-mapped: prefix already in IPv6 format, must be 96-128 */ > + if (*prefix_len < 96 || *prefix_len > 128) > + return -1; > + return AF_INET; > + } > + > + if (af =3D=3D AF_INET) { > + /* Native IPv4: convert to IPv6 format */ > + if (*prefix_len > 32) > + return -1; > + *prefix_len +=3D 96; If you make this adjustment before the previous stanza you again don't need the 'mapped' local and can use inany_v4(). > + return AF_INET; > + } > + > + /* Native IPv6: keep as-is */ > + if (*prefix_len > 128) > + return -1; And if you move this before the if (mapped) stanza, you can remove the duplicated check for > 128. > + return AF_INET6; > +} > diff --git a/inany.h b/inany.h > index 61b36fb..316ee44 100644 > --- a/inany.h > +++ b/inany.h > @@ -295,5 +295,6 @@ static inline void inany_siphash_feed(struct siphash_= state *state, > =20 > const char *inany_ntop(const union inany_addr *src, char *dst, socklen_t= size); > int inany_pton(const char *src, union inany_addr *dst); > +int inany_prefix_pton(char *src, union inany_addr *dst, int *prefix_len); > =20 > #endif /* INANY_H */ > diff --git a/ip.c b/ip.c > index 9a7f4c5..40dc24e 100644 > --- a/ip.c > +++ b/ip.c > @@ -13,6 +13,8 @@ > */ > =20 > #include > +#include > + > #include "util.h" > #include "ip.h" > =20 > @@ -67,3 +69,22 @@ found: > *proto =3D nh; > return true; > } > + > +/** > + * ip4_class_prefix_len() - Get class based prefix length for IPv4 addre= ss > + * @addr: IPv4 address > + * > + * Return: prefix length based on address class, or 32 for other > + */ > +int ip4_class_prefix_len(const struct in_addr *addr) > +{ > + in_addr_t a =3D ntohl(addr->s_addr); > + > + if (IN_CLASSA(a)) > + return 32 - IN_CLASSA_NSHIFT; > + if (IN_CLASSB(a)) > + return 32 - IN_CLASSB_NSHIFT; > + if (IN_CLASSC(a)) > + return 32 - IN_CLASSC_NSHIFT; > + return 32; > +} > diff --git a/ip.h b/ip.h > index 5830b92..bd28640 100644 > --- a/ip.h > +++ b/ip.h > @@ -135,4 +135,6 @@ static const struct in_addr in4addr_broadcast =3D { 0= xffffffff }; > #define IPV6_MIN_MTU 1280 > #endif > =20 > +int ip4_class_prefix_len(const struct in_addr *addr); > + > #endif /* IP_H */ > diff --git a/passt.1 b/passt.1 > index db0d662..53537c4 100644 > --- a/passt.1 > +++ b/passt.1 > @@ -156,10 +156,14 @@ By default, the advertised MTU is 65520 bytes, that= is, the maximum 802.3 MTU > minus the length of a 802.3 header, rounded to 32 bits (IPv4 words). > =20 > .TP > -.BR \-a ", " \-\-address " " \fIaddr > +.BR \-a ", " \-\-address " " \fIaddr\fR[/\fIprefix_len\fR] > Assign IPv4 \fIaddr\fR via DHCP (\fByiaddr\fR), or \fIaddr\fR via DHCPv6= (option > 5) and an \fIaddr\fR-based prefix via NDP Router Advertisement (option t= ype 3) > for an IPv6 \fIaddr\fR. > +An optional /\fIprefix_len\fR (1-32 for IPv4, 1-128 for IPv6) can be > +appended in CIDR notation (e.g. 192.0.2.1/24). This is an alternative to > +using the \fB-n\fR, \fB--netmask\fR option. Mixing CIDR notation with > +\fB-n\fR results in an error. > This option can be specified zero (for defaults) to two times (once for = IPv4, > once for IPv6). > By default, assigned IPv4 and IPv6 addresses are taken from the host int= erfaces > @@ -172,10 +176,13 @@ is assigned for IPv4, and no additional address wil= l be assigned for IPv6. > .TP > .BR \-n ", " \-\-netmask " " \fImask > Assign IPv4 netmask \fImask\fR, expressed as dot-decimal or number of bi= ts, via > -DHCP (option 1). > -By default, the netmask associated to the host address matching the assi= gned one > -is used. If there's no matching address on the host, the netmask is dete= rmined > -according to the CIDR block of the assigned address (RFC 4632). > +DHCP (option 1). Alternatively, the prefix length can be specified using= CIDR > +notation with the \fB-a\fR, \fB--address\fR option (e.g. \fB-a\fR 192.0.= 2.1/24). > +Mixing \fB-n\fR with CIDR notation results in an error. > +If no address is indicated, the netmask associated with the adopted host= address, > +if any, is used. If an address is indicated, but without a prefix length= , the > +netmask is determined based on the corresponding network class. In all o= ther > +cases, the netmask is determined by using the indicated prefix length. > =20 > .TP > .BR \-M ", " \-\-mac-addr " " \fIaddr > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --Jp7xtS6b8wrubIVQ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmDQJ8ACgkQzQJF27ox 2Gf/6Q/9HauPs1K8zsvXKUzZFDbNxZyvqd/MtIHThvOzeF1hbWgAVUrzVtpa+fJN I5YiqzJGJ4/UwAx9UvwW5QTjyvg9I7QWCGPgyjSyO4HK0UPm5AX9eA5AlexCa4Mw yN1xXsNJSCIC6lT0JVrRGG2M8R81YoBatdm0iJTXbuQfdrTDG6Fg7KAreM2UmQ1r akLl/JH09oKYhDDUqQQBLIUBtdrmuqxOrbQTvvTOssfuyeWkzDCAvRKM9p/osK/D /Lom/K02t9YGRoTQQtyGk2kqBnIQlQw8rzcU0YeYiLBmCTkXl1mF0OR66PVfTyNF bbSr1iXG5o8g27/gL4AcuOShO7hE3dvtfkncW+KDxVk7vBVWfos5wekzO2UO0nRG MN8LSxKhCER12cx3l8wNXXNnpbanmrqf5KZOWzAPHCXwYUmu2Uk2OzFJJpYz+hps zroo+7XCYLe45ryvLjDTdvhvMG72/L4TB6KEQHSnauzxyiXycS2cjFWDTBSFeo2/ q01wJ+ngI2TCMycSRN6VyM1U3fffrFpCDRLOwkPkdq/HkElY+GzsaCkOK+2Qa6qk C/d87Gam23slJb3EBnOFwCWt6lMyGeuxzrP71ozK+0gvpwDpJOgCC64GykqrGf3E +GsSay51pS7LZhYrpxyblD2AlYgKndKk6HsB9VFmMwnjdPrfjwk= =wPWT -----END PGP SIGNATURE----- --Jp7xtS6b8wrubIVQ--