From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=RtsnloZO; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id 9752E5A0271 for ; Fri, 06 Feb 2026 09:47:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1770367630; bh=oWV8hCLWI1DogOx6maocQkZp1PdJGqv+tQVAgg52fRo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RtsnloZO/YsexTNv+6gm1MGYRZlj68A0TNVpgLtXlikSLx27NqVOtb0OOEf76iYGm 9pj5jrFGIqkrIVu9NTeFAsa+EiHE5EdhlGExBdYe9FIbK0kFnh6J5YrYFd9R9SAyuy V2XGSQrIRC1UXruly5o4N6aeJ5h5NTofhvlDrSvN6yGjIM92lEpc8ugaLw/EBCe16D usOegbPVNbqavwi6Lb/jWVrmyuNK3Va1gF90dxejU8ohIdoGZmBDdoJCdDP1OFA2CC vYZQmQbC/Ly9TixvMYB0dLUlUqFIIc3OoLqDhNYBFV1S6VXaD2F5ql04B9AuOmZ8Ab iUwGuDQOfTWgw== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4f6nlL2TJQz4w9T; Fri, 06 Feb 2026 19:47:10 +1100 (AEDT) Date: Fri, 6 Feb 2026 19:34:29 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v3 05/11] arp: Check all configured addresses in ARP filtering Message-ID: References: <20260130214447.2540791-1-jmaloy@redhat.com> <20260130214447.2540791-6-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="x4nk3GSnIU6b6C1D" Content-Disposition: inline In-Reply-To: <20260130214447.2540791-6-jmaloy@redhat.com> Message-ID-Hash: 5S7HWOAOILANG7IE32QAHYXLW5XJ44WY X-Message-ID-Hash: 5S7HWOAOILANG7IE32QAHYXLW5XJ44WY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --x4nk3GSnIU6b6C1D Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2026 at 04:44:41PM -0500, Jon Maloy wrote: > As a preparation for handling multiple addresses, we update ignore_arp() > to check against all addresses in the unified addrs[] array using the > for_each_addr() macro. >=20 > Signed-off-by: Jon Maloy Reviewed-by: David Gibson Except that I think updates I've suggested to for_each_addr() will require small updates here too. >=20 > --- > v3: Adapted to single-array changes earlier in this series > --- > arp.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/arp.c b/arp.c > index f16beac..c493f9e 100644 > --- a/arp.c > +++ b/arp.c > @@ -41,6 +41,8 @@ > static bool ignore_arp(const struct ctx *c, > const struct arphdr *ah, const struct arpmsg *am) > { > + const struct inany_addr_entry *e; > + > if (ah->ar_hrd !=3D htons(ARPHRD_ETHER) || > ah->ar_pro !=3D htons(ETH_P_IP) || > ah->ar_hln !=3D ETH_ALEN || > @@ -53,10 +55,10 @@ static bool ignore_arp(const struct ctx *c, > !memcmp(am->sip, am->tip, sizeof(am->sip))) > return true; > =20 > - /* Don't resolve the guest's assigned address, either. */ > - if (first_v4(c) && > - !memcmp(am->tip, inany_v4(&first_v4(c)->addr), sizeof(am->tip))) > - return true; > + /* Don't resolve any of the guest's addresses */ > + for_each_addr(c, e, AF_INET) > + if (!memcmp(am->tip, inany_v4(&e->addr), sizeof(am->tip))) > + return true; > =20 > return false; > } > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --x4nk3GSnIU6b6C1D Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmFp4sACgkQzQJF27ox 2GfyTw//R1pJQedk7JZLKqwpvDRW38no9ykp20V5l4hjPQBiDAqxgGZ79WkxhqQx zZTZLqUcW/TEhDZMygubpDzkXUI6P/Z+MgVtKNjkdA4+9Lnmv3cTGT9V4AkpyGSi V1Aw7jpDpTYvoLIGJotmGpAPa0ekEyaccNC7yEKscDT9VXm/WyZ6NHFvnrKre/B+ WgnnNC/wNZ/59fr2BJ8bvypK19LZIdcY+hbca4OajcxWLnQh7xAeHCGDTqP56Hdy 0Y/zG1UHxIvw93NIlZrG1D4HVSoksfnasG1oRHOTClsn4igZyVxOGrXU3j2jTU30 hkJK9ZOBrqcEvYy6hv4ZFmToaOm9/LYJWT7E1UxJTn7Sq15RDGHr3INHKMM19kVI 1UA6H0tETAODIgOk6N1dyUOwr4gBZNsROcO0kxY5csTU6nvRc3NR70I3NAs1rZCG 71eN4YZI15EfZx2vWxoV+h3tuYSpDY9ebIwWrhkIRvRm6NkOnQjNce19P4rn9jjM kxgNqcxUAXdMgJxfUwzwKF2V7X52JV3BLOUq2dDN7iuCQxZQ1ksOJqEczDig2ni1 N56kbV74EEbIfswX1LmfYHNJ3xjgv/JgRoW5s45gH9krn3ZQPcAG0TqHHxJ2tcGQ Wm+y6DyNR0VqislK+ceJtSnYLFz1gq6yHAUJlAd+B/0uOVGxo94= =9ZCy -----END PGP SIGNATURE----- --x4nk3GSnIU6b6C1D--