From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202512 header.b=V71FS7pj; dkim-atps=neutral Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by passt.top (Postfix) with ESMTPS id 89F985A0271 for ; Fri, 06 Feb 2026 09:50:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202512; t=1770367840; bh=do3kOQB4Rs4pTBVPP4rkkqi1WpI9rIzYaRlejAKLv2M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V71FS7pjuMf01vt4q6OKQIwysfXGVNPMeU0Fdm8PkV7GwUmPfu/NUeezViUKHDw7w baTED2k3wE2vjvAibpNDuJb395pbCoZEKbXofrCHd/eDaIm23pxn9s7XHXBDZ4C1CX 22UAoxZMFaCKX5HShyqQtAO5UWdxuYMUk+LtWsyyp8FS23sEIZ3jsNSFYj7kFKaoWo rf1bvw7TNNHFkCveciiuJjh+IFIngh6UOb2kCPKyVsZIFlKMthKWV+zs4QltTCNvtS QKdhvKdOIXuyHegGbM2jlYnh2h06sInE6ijsaorHl3NvrP2hfOUcbnl9rYtzb+DYck drmmhO0+ukHbA== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4f6nqN1rfpz4wB8; Fri, 06 Feb 2026 19:50:40 +1100 (AEDT) Date: Fri, 6 Feb 2026 19:50:34 +1100 From: David Gibson To: Jon Maloy Subject: Re: [PATCH v3 08/11] migrate: Rename v1 address functions to v2 for clarity Message-ID: References: <20260130214447.2540791-1-jmaloy@redhat.com> <20260130214447.2540791-9-jmaloy@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MMTD2BXHaNDt65gb" Content-Disposition: inline In-Reply-To: <20260130214447.2540791-9-jmaloy@redhat.com> Message-ID-Hash: UEIEGYORGYCRO5Z5G2Z2HQXFUGPVRZRL X-Message-ID-Hash: UEIEGYORGYCRO5Z5G2Z2HQXFUGPVRZRL X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: sbrivio@redhat.com, dgibson@redhat.com, passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --MMTD2BXHaNDt65gb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 30, 2026 at 04:44:44PM -0500, Jon Maloy wrote: > Some migration address structures and functions have a _v1 suffix. > This is confusing, since they are currently handling version 2 of > the migration protocol. We are now going to introduce a new version > 3 of the protocol, so we choose to give these functions the correct > suffix _v2 instead. This is in correspondence with current reality, > and will help make a clearer distinction between the old and the new > versions of those functions. I think the historical reason for this is that those specific components didn't change format from v1 to v2. But, given that v1 existed only very briefly and is not now supported, that's not very relevant. So, Reviewed-by: David Gibson And furthermore I think it makes sense to apply this independent of the rest of the series. > Signed-off-by: Jon Maloy > --- > migrate.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/migrate.c b/migrate.c > index 48d63a0..7398d26 100644 > --- a/migrate.c > +++ b/migrate.c > @@ -29,13 +29,13 @@ > #define MIGRATE_MAGIC 0xB1BB1D1B0BB1D1B0 > =20 > /** > - * struct migrate_seen_addrs_v1 - Migratable guest addresses for v1 stat= e stream > + * struct migrate_seen_addrs_v2 - Migratable guest addresses for v2 prot= ocol > * @addr6: Observed guest IPv6 address > * @addr6_ll: Observed guest IPv6 link-local address > * @addr4: Observed guest IPv4 address > * @mac: Observed guest MAC address > */ > -struct migrate_seen_addrs_v1 { > +struct migrate_seen_addrs_v2 { > struct in6_addr addr6; > struct in6_addr addr6_ll; > struct in_addr addr4; > @@ -43,7 +43,7 @@ struct migrate_seen_addrs_v1 { > } __attribute__((packed)); > =20 > /** > - * seen_addrs_source_v1() - Copy and send guest observed addresses from = source > + * seen_addrs_source_v2() - Copy and send guest observed addresses from = source > * @c: Execution context > * @stage: Migration stage, unused > * @fd: File descriptor for state transfer > @@ -51,10 +51,10 @@ struct migrate_seen_addrs_v1 { > * Return: 0 on success, positive error code on failure > */ > /* cppcheck-suppress [constParameterCallback, unmatchedSuppression] */ > -static int seen_addrs_source_v1(struct ctx *c, > +static int seen_addrs_source_v2(struct ctx *c, > const struct migrate_stage *stage, int fd) > { > - struct migrate_seen_addrs_v1 addrs =3D { > + struct migrate_seen_addrs_v2 addrs =3D { > .addr6 =3D c->ip6.addr_seen, > .addr6_ll =3D c->ip6.addr_ll_seen, > .addr4 =3D c->ip4.addr_seen, > @@ -71,17 +71,17 @@ static int seen_addrs_source_v1(struct ctx *c, > } > =20 > /** > - * seen_addrs_target_v1() - Receive and use guest observed addresses on = target > + * seen_addrs_target_v2() - Receive and use guest observed addresses on = target > * @c: Execution context > * @stage: Migration stage, unused > * @fd: File descriptor for state transfer > * > * Return: 0 on success, positive error code on failure > */ > -static int seen_addrs_target_v1(struct ctx *c, > +static int seen_addrs_target_v2(struct ctx *c, > const struct migrate_stage *stage, int fd) > { > - struct migrate_seen_addrs_v1 addrs; > + struct migrate_seen_addrs_v2 addrs; > =20 > (void)stage; > =20 > @@ -100,8 +100,8 @@ static int seen_addrs_target_v1(struct ctx *c, > static const struct migrate_stage stages_v2[] =3D { > { > .name =3D "observed addresses", > - .source =3D seen_addrs_source_v1, > - .target =3D seen_addrs_target_v1, > + .source =3D seen_addrs_source_v2, > + .target =3D seen_addrs_target_v2, > }, > { > .name =3D "prepare flows", > --=20 > 2.52.0 >=20 --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --MMTD2BXHaNDt65gb Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmFq1UACgkQzQJF27ox 2GexjxAAkTus9ukfeJ+XNiWgpj7M32uuYOsVLkwI6EXMeuNXKOFvDI4w2G5DQQOr V0uveJe59m7gJIZiLo4hliyr8zKhA9Icth6I5hOb+9KH0JVnsJUrWFIfinpzxEKI 3okeyyNWRtgV4rEAMQ4PTSunzsckff/v6fw+l1DXQGiHL6rg1kWXOBraJqCWiEMA U6Yo6dADejc2nyFB7c/9aWkENZVpyDDNWJjLtH4NtGK+NyUNCcUQTkJlbgZxfBFz ayVrZzcv/FEDOFnLnyttATZLZizzZyOF6iqViRrA6vR3z3kSN2I8JWRnHPDxVekO oH8rvRGld/ricf85jgl5plew58zKs875VIOqgKkfmtT8554B2NZmutrTnmO9MdHF aI3+h3Cr5bHfZYJNlYLCkJHTSjqC1L6+4WbTT4nybR5yPzsKoGpWRCKE5cuCoVss y2uklN8AV2i+c0XJD5AypoFgq53RY3EQmXINKw6LbqSx71kxIRMpfmY485W5Z+R4 Pkm6Hd69hcT4/OPrF0CNjxUmQ2M3MaWKOfuLMMJlw0YrPJw21YJ5kVO3rs2Ryonl DYFXkquW/wwBntBqsneM9lOOEVZP4t7Y8lXm3DcLZbM3lBVAWgVSIZfXOMeBQ4BO 3stC6vT4gGdQY0gfOCL5nh0GchcrMudcsPLmJ2HqOcuaQOSMgu8= =LtrT -----END PGP SIGNATURE----- --MMTD2BXHaNDt65gb--