From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=gibson.dropbear.id.au header.i=@gibson.dropbear.id.au header.a=rsa-sha256 header.s=202602 header.b=HLwqFC1f; dkim-atps=neutral Received: from mail.ozlabs.org (mail.ozlabs.org [IPv6:2404:9400:2221:ea00::3]) by passt.top (Postfix) with ESMTPS id D95415A004E for ; Thu, 26 Feb 2026 00:24:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=202602; t=1772061840; bh=u2dsZhGnyDTKOgWj2QkciyZj5ns9ICzTd9sNza03Kjo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HLwqFC1fruRlgs33AnDzDLWSJDN4QOZ4zOWFgEJf0qStLTzUNSnzMuZqpFhvMhVaS /IIFpGjkQ1OSPddNHJtncPKc/aeRBWQPHfl4XcslhpCzBWoLQP43SASzEmVMAKO8aL DZiDI+vQtly8XYt/72zIswWHVquevwgktUzkHFjElRhdu6pdP2k4UT0t3ipNY+u6UO GdFsaWjRfdG02iIHwNyb5d6ydo5XIiJ6y2tbBrIITYM0lKYc2lLjI26SMXI31kH7hR u01U9pFZdB+A1ti5TsHIl8snoVUCz2RKHdEc6M8pGkV2gBe85tyMF3ekVIDErkXMuS snyoly86eUY2g== Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4fLrJJ4Sy2z4wDN; Thu, 26 Feb 2026 10:24:00 +1100 (AEDT) Date: Thu, 26 Feb 2026 10:23:52 +1100 From: David Gibson To: Stefano Brivio Subject: Re: [PATCH] Add missing includes to headers Message-ID: References: <20260223183530.2c040c94@elisabeth> <20260224103253.3a633773@elisabeth> <20260224185343.249a499a@elisabeth> <20260224210317.585fe9e8@elisabeth> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4S0MN2yoAKaqxftv" Content-Disposition: inline In-Reply-To: <20260224210317.585fe9e8@elisabeth> Message-ID-Hash: Z5IW33TOGXDU67PFYBSXEWXXG2AYXKKY X-Message-ID-Hash: Z5IW33TOGXDU67PFYBSXEWXXG2AYXKKY X-MailFrom: dgibson@gandalf.ozlabs.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Foley , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: --4S0MN2yoAKaqxftv Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 24, 2026 at 09:03:18PM +0100, Stefano Brivio wrote: > On Tue, 24 Feb 2026 13:52:04 -0500 > Peter Foley wrote: >=20 > > On Tue, Feb 24, 2026 at 12:53=E2=80=AFPM Stefano Brivio wrote: > >=20 > > > > > > What I was suggesting was to sprinkle the code with beauties such as: > > > > > > /* NOLINTNEXTLINE(misc-include-cleaner) */ > > > =20 > >=20 > > Unfortunatly it needs to go before the usage, not the include. >=20 > Ah, right, of course. >=20 > > > before each "offending" include line... assuming it works, and > > > assuming we need perhaps 20-30 of them. But if it's a lot more, then > > > that's not a reasonable option either. > >=20 > > I get "72 warnings treated as errors" when running clang-tidy with my > > current set of patches. >=20 > Ugh. Yet another alternative could be to enable misc-include-cleaner for > headers only, which would probably need a separate invocation of > clang-tidy. >=20 > I'm not sure if that will work at all though. If it doesn't, I'm out of > ideas... maybe we should simply go back to your original patch, in that > case, and you'll just get to "fix" things as they break (hopefully > infrequently) in the future. Kind if what we want is to apply the check in relation to local "" headers, but not <> system headers. Unfortunately, I don't know if there's any way to do that. --=20 David Gibson (he or they) | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you, not the other way | around. http://www.ozlabs.org/~dgibson --4S0MN2yoAKaqxftv Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEO+dNsU4E3yXUXRK2zQJF27ox2GcFAmmfhHQACgkQzQJF27ox 2GeHSA/+MlA1JkNQXQmolv7j30oxZ4t/8/og+p89+D9lUDCf+TX66GdFMXWA/9Ae 1H1ZYdwtuwbUaAeZnuMd0bp1HN53e8wX0XEPM+XSV8KlQNLcnZOeGcxOGSTLsLV2 Ht4+pCpIGBgOg/eOQRk9QnmHGWw2hsXCd1OLwgTQG+gyBRY7fiwhGKrHYk9knmaa J0Q/p71xr+BgmOLWCaoivZIosn8P/J4GzRR6aDAWY8I99/Hz3/6DOh2XGiM9r9Yo odwB3DXkZyehE964G/LD0b3U8qmOplCLLvhNGJaWaWUhp+vTFuI0+83ogdQ96BjM uAEzIFCIY8v8fT1Yu2pzlygbOdZxGsLQ6r5lmsFaYXJ1JtTrZBa9hp/PMYf6/ZWl jiySWeyfn4hWXQyr8PlxJanQJztTIa1Dx6nsIn6K1mLO6eiBZlMNoS5wr2WYy3/W OHqdOyoAPYorPuftnnKq+RBI8UnL6oZY9Etv+z2nv4jA0EKf0GGFDTFbqH8pMla4 ztQ02yFJw8ZoUE/NmbEe8ZIsaGXDVBTqReeytRXOEtvKHEEy4PEHoasVR+aRXrZv eW9aBm5eIR4RO05V0W72UOo0hhr06M9NSlsJdXhNlcy31QcGq4ebnOkeux4X2NuG HQQW3Wc2FTsfX1L38cfEIBW5pyQWAZwAaGEItesMIW6M4nUCfBk= =RdJP -----END PGP SIGNATURE----- --4S0MN2yoAKaqxftv--