Re: [PATCH] Fix build when HAS_GETRANDOM is undefined

[David Gibson <david@gibson.dropbear.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

On Mon, Feb 23, 2026 at 12:27:39PM -0500, Peter Foley wrote:
> e.g.
> util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'?
>  1163 |                 ret = read(dev_random, (char *)buf + random_read,
> 
> Signed-off-by: Peter Foley <pefoley@google.com>

Oops, that's mildly embarrassing.

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  util.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/util.c b/util.c
> index db27431..a4f2be4 100644
> --- a/util.c
> +++ b/util.c
> @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen)
>  		ret = getrandom((char *)buf + random_read,
>  				buflen - random_read, GRND_RANDOM);
>  #else
> -		ret = read(dev_random, (char *)buf + random_read,
> +		ret = read(fd, (char *)buf + random_read,
>  			   buflen - random_read);
>  #endif
>  
> @@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen)
>  	}
>  
>  #ifndef HAS_GETRANDOM
> -	close(dev_random);
> +	close(fd);
>  #endif
>  
>  	if (random_read < buflen)
> -- 
> 2.53.0.371.g1d285c8824-goog
> 

-- 
David Gibson (he or they)	| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you, not the other way
				| around.
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]